Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'local_send_to_resource' hook #3139

Merged
merged 1 commit into from
May 31, 2021
Merged

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented May 31, 2021

It was registered per domain, not per host type, what caused exometer to create one metric per domain.

It can be removed as 'ejabberd_local' was the only module handling it.
This unexpected type of stanza shouldn't be handled by modules as well.

It was registered per domain, not per host type,
  what caused exometer to create one metric per domain.

It can be removed as 'ejabberd_local' was the only module handling it.
This unexpected type of stanza shouldn't be handled by modules as well.
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #3139 (95c54a7) into master (cf515ef) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3139   +/-   ##
=======================================
  Coverage   79.46%   79.46%           
=======================================
  Files         395      395           
  Lines       32191    32187    -4     
=======================================
- Hits        25580    25579    -1     
+ Misses       6611     6608    -3     
Impacted Files Coverage Δ
src/mongoose_hooks.erl 92.20% <ø> (-0.10%) ⬇️
src/ejabberd_local.erl 77.60% <85.71%> (+0.43%) ⬆️
src/ejabberd.erl 45.00% <0.00%> (-10.00%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 75.14% <0.00%> (-2.26%) ⬇️
src/mod_bosh_socket.erl 77.63% <0.00%> (-1.56%) ⬇️
src/global_distrib/mod_global_distrib_utils.erl 64.48% <0.00%> (-0.94%) ⬇️
src/pubsub/mod_pubsub_db_mnesia.erl 92.40% <0.00%> (-0.43%) ⬇️
src/ejabberd_c2s.erl 89.35% <0.00%> (+0.07%) ⬆️
src/mod_muc_room.erl 77.45% <0.00%> (+0.11%) ⬆️
src/ejabberd_s2s_out.erl 60.41% <0.00%> (+1.60%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf515ef...95c54a7. Read the comment docs.

@chrzaszcz chrzaszcz marked this pull request as ready for review May 31, 2021 15:55
Copy link
Collaborator

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@DenysGonchar DenysGonchar merged commit dd68251 into master May 31, 2021
@DenysGonchar DenysGonchar deleted the local-send-to-resource-fix branch May 31, 2021 16:05
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants