fixing race condition in carboncopy_SUITE #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem in unavailable_resources_dont_get_carbons test case sequence. The presence from Alice1 could be delivered to Alice2 faster than the message from Bob. In this case Alice1 also can receive carbonecopy from Bob as a 3rd message, but it fetches and checks only 2 messages.
NelsonVides
approved these changes
Jun 1, 2021
DenysGonchar
force-pushed
the
fixing-race-condition-in-carboncopy_SUITE
branch
from
aa501a7
to
9f5a888
Compare
Codecov Report
@@ Coverage Diff @@
## master #3144 +/- ##
==========================================
+ Coverage 79.41% 79.44% +0.03%
==========================================
Files 396 396
Lines 32419 32419
==========================================
+ Hits 25745 25755 +10
+ Misses 6674 6664 -10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing race condition in unavailable_resources_dont_get_carbons test case of carboncopy_SUITE