Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating mod_stream_management module #3149

Merged
merged 5 commits into from
Jun 8, 2021

Conversation

DenysGonchar
Copy link
Collaborator

@DenysGonchar DenysGonchar commented Jun 1, 2021

This PR introduces dynamic domains support for mod_stream_management.
Some tests in sm_SUITE are disabled for dynamic domains because they depend on another modules that do not support dynamic domains yet.

@DenysGonchar DenysGonchar force-pushed the updating-mod_stream_management-module branch from 87acc6a to 2aa31b7 Compare June 1, 2021 15:24
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #3149 (f1cb05c) into master (85e657c) will increase coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3149      +/-   ##
==========================================
+ Coverage   79.51%   79.54%   +0.02%     
==========================================
  Files         397      397              
  Lines       32321    32322       +1     
==========================================
+ Hits        25701    25709       +8     
+ Misses       6620     6613       -7     
Impacted Files Coverage Δ
src/mod_stream_management.erl 84.61% <78.78%> (ø)
src/ejabberd_c2s.erl 89.29% <100.00%> (+<0.01%) ⬆️
src/ejabberd.erl 45.00% <0.00%> (-10.00%) ⬇️
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/event_pusher/mod_event_pusher_sns.erl 83.56% <0.00%> (-5.48%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 86.60% <0.00%> (-1.79%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 76.83% <0.00%> (-0.57%) ⬇️
src/mod_roster.erl 76.62% <0.00%> (-0.24%) ⬇️
src/mod_muc_room.erl 77.06% <0.00%> (+0.17%) ⬆️
src/mod_bosh_socket.erl 79.19% <0.00%> (+0.31%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85e657c...f1cb05c. Read the comment docs.

to create a full list of sm_SUITE test cases that depend on other modules and should be skipped at big_tests/dynamic_domains.spec,
we can disable modules one by one at big_tests/test.config and run sm_SUITE for a static config.
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I only have minor comments.

big_tests/tests/sm_SUITE.erl Outdated Show resolved Hide resolved
big_tests/tests/sm_SUITE.erl Outdated Show resolved Hide resolved
big_tests/tests/sm_SUITE.erl Outdated Show resolved Hide resolved
big_tests/tests/sm_SUITE.erl Outdated Show resolved Hide resolved
big_tests/tests/sm_SUITE.erl Show resolved Hide resolved
@DenysGonchar DenysGonchar force-pushed the updating-mod_stream_management-module branch from 50ad6bb to f1cb05c Compare June 8, 2021 08:38
@chrzaszcz chrzaszcz merged commit 647b6fb into master Jun 8, 2021
@chrzaszcz chrzaszcz deleted the updating-mod_stream_management-module branch June 8, 2021 09:58
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants