cleaning up some issues with multitenancy support #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenysGonchar
force-pushed
the
multi-tenancy-cleanup
branch
from
f2004dc
to
6ccae3f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3158 +/- ##
==========================================
+ Coverage 79.82% 79.83% +0.01%
==========================================
Files 396 396
Lines 32255 32266 +11
==========================================
+ Hits 25748 25761 +13
+ Misses 6507 6505 -2
Continue to review full report at Codecov.
|
to get the list of all the modules that miss declaration of dynamic_domains feature, run these commands: test-runner.sh --preset pgsql_mnesia --skip-cover --skip-small-tests --spec dynamic_domains.spec grep -r "dynamic_domains_feature_is_not_supported:" _build/*/rel/mongooseim/log | sed -E "s/.*dynamic_domains_feature_is_not_supported: ([^ ]*) .*/\1/" | sort -u
…ype if module doesn't explicitly declare support for this feature
DenysGonchar
force-pushed
the
multi-tenancy-cleanup
branch
2 times, most recently
from
5ab429a
to
5877191
Compare
The @~2 commit is cherry-picked from beekeeper's repo. it addes declaration of dynamic_domains feature support to some modules. To see the full list of the changed modules use this command: git show --name-only --pretty="format:" @~2 | sed -r "s_.*/(.*)\.erl_\1_p;d" | sort The conversion of 'mod_commands' and 'mod_muc_light_commands' modules seems to be done, however there's no integration testing enabled for that modules in dynamic_domains.spec Other modules (except mod_mam_meta) are dynamically initialised during the execution of the tests currently configured in dynamic_domains.spec, however there's no waranty that all of them are fully converted and tested. So ideally we should recheck all of them, here is the list of that modules: * mod_mam * mod_mam_cache_user * mod_mam_meta * mod_mam_mnesia_prefs * mod_mam_muc * mod_mam_muc_cache_user * mod_mam_muc_rdbms_arch * mod_mam_muc_rdbms_async_pool_writer * mod_mam_rdbms_arch * mod_mam_rdbms_async_pool_writer * mod_mam_rdbms_prefs * mod_mam_rdbms_user * mod_muc * mod_muc_light * mod_muc_log
DenysGonchar
force-pushed
the
multi-tenancy-cleanup
branch
from
5877191
to
5baa21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR introduces the following changes:
dynamic_domainsfeature support at gen_moddynamic_domainssupport for 'mod_commands' and 'mod_muc_light_commands' modules. Quick check shows that these modules are converted, however there is no proper testing done for them. these 2 modules are changed mostly for alignment with bkpr's codebase.