Fix user cache #3161
Merged
Fix user cache #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3161 +/- ##
==========================================
+ Coverage 79.82% 79.84% +0.02%
==========================================
Files 396 396
Lines 32255 32255
==========================================
+ Hits 25748 25755 +7
+ Misses 6507 6500 -7
Continue to review full report at Codecov.
|
chrzaszcz
approved these changes
Jun 23, 2021
As the tables are created per-host-type, a table can have more than one domain within, and so there's no unique key properly defined, considering that the same namepart can be used in two different domains, and the same domain contains many nameparts. Restore it as a set, and actually fix the key inserted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the tables are created per-host-type, a table can have more than one
domain within, and so there's no unique key properly defined,
considering that the same namepart can be used in two different domains,
and the same domain contains many nameparts.
The cache was broken because, as a set where the domain is the key, inserted users would always override previous. If namepart is the key, two users with the same namepart in different domains would also override each other. So the whole pair needed to be made the key as a 1-tuple.