Multitenancy/privacy #3189

NelsonVides · 2021-07-20T16:21:16Z

This also takes the chance that we're modifying the default config to enable mod_cache_users, which wasn't enabled before.

codecov · 2021-07-20T16:33:58Z

Codecov Report

Merging #3189 (a9c7461) into master (a4d7d2f) will increase coverage by 0.00%.
The diff coverage is 91.71%.

@@           Coverage Diff           @@
##           master    #3189   +/-   ##
=======================================
  Coverage   80.28%   80.29%           
=======================================
  Files         397      397           
  Lines       32430    32447   +17     
=======================================
+ Hits        26037    26052   +15     
- Misses       6393     6395    +2

Impacted Files	Coverage Δ
src/mod_private.erl	`84.21% <ø> (ø)`
src/privacy/mod_privacy_mnesia.erl	`78.26% <60.00%> (ø)`
src/privacy/mod_privacy_riak.erl	`78.43% <78.43%> (ø)`
src/mod_blocking.erl	`86.84% <100.00%> (+0.54%)`	⬆️
src/mongoose_hooks.erl	`95.10% <100.00%> (ø)`
src/privacy/mod_privacy.erl	`86.61% <100.00%> (ø)`
src/privacy/mod_privacy_rdbms.erl	`80.51% <100.00%> (ø)`
src/auth/ejabberd_auth_internal.erl	`86.11% <0.00%> (-1.86%)`	⬇️
src/global_distrib/mod_global_distrib_utils.erl	`64.48% <0.00%> (-0.94%)`	⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d7d2f...a9c7461. Read the comment docs.

chrzaszcz

I debugged the big test failures and found an issue. I am not sure if it is the only one, please make sure there are no more things like this one. Maybe we could just omit the dependency change in this PR and do it separately?

chrzaszcz · 2021-07-26T08:13:02Z

src/mod_blocking.erl

+deps(_HostType, Opts) ->
+    [{mod_privacy, Opts, hard}].


Some tests stop mod_privacy without stopping mod_blocking, e.g. mod_global_distrib_SUITE in line 196:

ModulesToStop = [mod_offline, mod_privacy, mod_roster, mod_last],

After that, modules are started with gen_mod_deps, which does not start mod_privacy as it is a dependency of mod_blocking. This makes big tests fail.

mongoose-im · 2021-07-26T09:27:54Z

small_tests_24 / small_tests / 7db8730
Reports root / small

internal_mnesia_24 / internal_mnesia / 7db8730
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

dynamic_domains_24 / pgsql_mnesia / 7db8730
Reports root/ big
OK: 1615 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

dynamic_domains_23 / pgsql_mnesia / 7db8730
Reports root/ big
OK: 1615 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

small_tests_22 / small_tests / 7db8730
Reports root / small

small_tests_23 / small_tests / 7db8730
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 7db8730
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

ldap_mnesia_22 / ldap_mnesia / 7db8730
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 7db8730
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 7db8730
Reports root/ big
OK: 3103 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_94.137345@localhost/res1">>},
        {<<"id">>,<<"ca3d6b5e-a84c-4127-9fb4-4017280a2bc1">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"112694e8-2e01-4ddd-ab75-70fd040daf8e">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_94.137345@localhost/res1' id='ca3d6b5e-a84c-4127-9fb4-4017280a2bc1' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='112694e8-2e01-4ddd-ab75-70fd040daf8e'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,393}]},
    {jingle_SUITE,
      '-res...

Report log

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 7db8730
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 282 / Auto-skipped: 0

pgsql_mnesia_22 / pgsql_mnesia / 7db8730
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 7db8730
Reports root/ big
OK: 3074 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

mam_SUITE:rdbms_async_pool_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster

{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log

pgsql_mnesia_23 / pgsql_mnesia / 7db8730
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 7db8730
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 7db8730
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 285 / Auto-skipped: 0

vkatsuba · 2021-07-26T10:18:10Z

src/privacy/mod_privacy_riak.erl

+    ),
+    mongoose_riak:delete(?BKT_LISTS_NAMES(HostType), key(LUser, LServer)).
+
+%% TODO


This TODO stuff should be implemented in other PR?

Yeah, unless anybody know how to implement this for riak, in riak keys are the whole jid as a binary, I don't know how to tell riak to remove keys by a pattern-match 🤔

For this case when those keys will not deleted from riak - what will happens if we will try to put duplicate keys? It's can be provide tests for such a case and make sure that it does not break logic in other places?
Other question is - if we do not delete the keys, does this mean that the keys will be stored forever and gradually clutter up the space?

Keys are the entire jid of the user, so reinserting it would mean I guess reinserting this user's configuration. This hasn't changed, if the old logic was correct, the new one is as well, all that has changed is the key name.
This new hook remove_domain is related to multitenancy, and no modules had it a month ago. I just don't know how to implement such thing for riak in this case, but I'm pretty confident riak and mod_privacy is not used by anyone, so I wasn't in a hurry to implement this new callback. Still, we should investigate how to delete keys based on a pattern for riak.

vkatsuba

LGTM.

arcusfelis

added some comments

big_tests/tests/privacy_SUITE.erl

priv/pg.sql

src/privacy/mod_privacy.erl

priv/mysql.sql

priv/mssql2012.sql

mongoose-im · 2021-07-26T16:12:53Z

small_tests_24 / small_tests / 190e39b
Reports root / small

small_tests_22 / small_tests / 190e39b
Reports root / small

dynamic_domains_24 / pgsql_mnesia / 190e39b
Reports root/ big
OK: 1615 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

dynamic_domains_23 / pgsql_mnesia / 190e39b
Reports root/ big
OK: 1615 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / 190e39b
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

small_tests_23 / small_tests / 190e39b
Reports root / small

ldap_mnesia_22 / ldap_mnesia / 190e39b
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 190e39b
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 190e39b
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 190e39b
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 282 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 190e39b
Reports root/ big
OK: 3103 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_35.142848@localhost/res1">>},
        {<<"id">>,<<"5e3a396b-396b-4311-a1c0-6d9673034dc8">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"d9a1f71c-903b-4713-b0b2-c538cfcb951a">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_35.142848@localhost/res1' id='5e3a396b-396b-4311-a1c0-6d9673034dc8' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='d9a1f71c-903b-4713-b0b2-c538cfcb951a'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,393}]},
    {jingle_SUITE,
      '-res...

Report log

pgsql_mnesia_24 / pgsql_mnesia / 190e39b
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

pgsql_mnesia_22 / pgsql_mnesia / 190e39b
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 190e39b
Reports root/ big
OK: 3074 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

mam_SUITE:rdbms_simple_prefs_cases:messages_filtered_when_prefs_default_policy_is_never

{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log

pgsql_mnesia_23 / pgsql_mnesia / 190e39b
Reports root/ big
OK: 3150 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

amp_big_SUITE:basic:error_deliver_to_stranger_test

{error,
  {test_case_failed,
    {has_stanzas_but_shouldnt,
      {client,
        <<"alicE_error_deliver_to_stranger_test_69.415217@localhost/res1">>,
        escalus_tcp,<0.2870.0>,
        [{event_manager,<0.2745.0>},
         {server,<<"localhost">>},
         {username,
           <<"alicE_error_deliver_to_stranger_test_69.415217">>},
         {resource,<<"res1">>}],
        [{event_client,
           [{event_manager,<0.2745.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_error_deliver_to_stranger_test_69.415217">>},
            {resource,<<"res1">>}]},
         {resource,<<"res1">>},
         {username,
           <<"alicE_error_deliver_to_stranger_test_69.415217">>},
         {server,<<"localhost">>},
         {host,<<"localhost">>},
         {port,5222},
         {auth,{escalus_auth,auth_plain}},
         {wspath,undefined},
         {username,
           <<"alicE_error_deliver_to_stranger_test_69.415217">>},
         {server,<<"localhost">>},
         {password,<<"matygrysa">>},
         {stream_id,<<"aea6a540e8a8bc81">>}]},
      [{xmlel,<<"stream:error">>,[],
         [{xmlel,<<"conflict">>,
            [{<<"xmlns">>,
            <<"urn:ietf:params:xml:ns:xmpp-streams">>}],
            []},
          {xmlel,<<"text">>,
            [{<<"xml:lang">>,<<"en">>},
             {<<"xmlns">>,
            <<"urn:ietf:params:xml:ns:xmpp-streams">>}],
            [{xmlcdata,<<"Replaced by new connection">>}]}]},
       {xmlstreamend,<<...

Report log

riak_mnesia_24 / riak_mnesia / 190e39b
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 285 / Auto-skipped: 0

arcusfelis

good :)

chrzaszcz

Good changes, I like that migrations are already included.
I have a few minor comments.

big_tests/tests/privacy_SUITE.erl

chrzaszcz · 2021-07-27T06:22:21Z

big_tests/tests/privacy_SUITE.erl

+    [
+     block_jid_message,


Minor: no reason to change this, especially that other lists do not contain such extra newlines.

That was for me to be able to comment out test cases easily, without removing the list opening bracket. I have it like that in many other test suites.

chrzaszcz · 2021-07-27T06:26:13Z

big_tests/tests/privacy_SUITE.erl

+    [
+     {group, management},


Minor: no reason to change this, especially that other lists do not contain such extra newlines.

include/mod_privacy.hrl

chrzaszcz · 2021-07-27T06:33:15Z

priv/mssql2012.sql

@@ -181,11 +181,12 @@ GO
 SET ANSI_PADDING ON
 GO
 CREATE TABLE [dbo].[privacy_default_list](
+	[server] [nvarchar](250) NOT NULL,


Note: the PRIMARY KEY constraint below implies NOT NULL for both columns.

chrzaszcz · 2021-07-27T06:34:00Z

priv/mysql.sql

+    server varchar(250) NOT NULL,
+    username varchar(250) NOT NULL,


Note: the PRIMARY KEY constraint below implies NOT NULL for both columns.

chrzaszcz · 2021-07-27T06:38:10Z

priv/mssql2012.sql

@@ -200,6 +201,7 @@ GO
 SET ANSI_PADDING ON
 GO
 CREATE TABLE [dbo].[privacy_list](
+	[server] [nvarchar](250) NOT NULL,


Note: for other DBs we have a primary key here. Maybe it would be good to add it for MS SQL as well for consistency.

chrzaszcz · 2021-07-27T06:39:00Z

priv/pg.sql

 );

 CREATE TABLE privacy_list (
+    server varchar(250) NOT NULL,


Minor, note: PRIMARY KEY implies NOT NULL.

chrzaszcz · 2021-07-27T06:43:02Z

src/privacy/mod_privacy.erl

 updated_list(_, #userlist{name = SameName}, #userlist{name = SameName} = New) -> New;
 updated_list(_, Old, _) -> Old.

-
+%% ------------------------------------------------------------------


Minor: I like the single lines more, less clutter in the code.

mongoose-im · 2021-07-27T07:36:47Z

small_tests_24 / small_tests / b02ac0c
Reports root / small

internal_mnesia_24 / internal_mnesia / b02ac0c
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

small_tests_22 / small_tests / b02ac0c
Reports root / small

dynamic_domains_24 / pgsql_mnesia / b02ac0c
Reports root/ big
OK: 1615 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

dynamic_domains_23 / pgsql_mnesia / b02ac0c
Reports root/ big
OK: 1615 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

small_tests_23 / small_tests / b02ac0c
Reports root / small

ldap_mnesia_22 / ldap_mnesia / b02ac0c
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / b02ac0c
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / b02ac0c
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

pgsql_mnesia_22 / pgsql_mnesia / b02ac0c
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / b02ac0c
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 282 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / b02ac0c
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / b02ac0c
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / b02ac0c
Reports root/ big
OK: 3068 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / b02ac0c
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / b02ac0c
Reports root/ big
OK: 1737 / Failed: 1 / User-skipped: 285 / Auto-skipped: 0

dynamic_domains_SUITE:with_mod_dynamic_domains_test:packet_handling_for_subdomain

{error,
  {{badrpc,
     {'EXIT',
       {timeout,
         [{meck_proc,wait,6,
            [{file,
               "/home/circleci/app/_build/default/lib/meck/src/meck_proc.erl"},
             {line,171}]},
          {meck,wait,5,[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       meck,wait,
       [3,mod_dynamic_domains_test,process_packet,5,500]],
      [{file,"/home/circleci/app/big_tests/tests/distributed_helper.erl"},
       {line,117}]},
    {dynamic_domains_SUITE,'-packet_handling_for_subdomain/1-fun-3-',1,
      [{file,
         "/home/circleci/app/big_tests/tests/dynamic_domains_SUITE.erl"},
       {line,113}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

mongoose-im · 2021-07-27T07:51:37Z

small_tests_24 / small_tests / a9c7461
Reports root / small

internal_mnesia_24 / internal_mnesia / a9c7461
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

small_tests_22 / small_tests / a9c7461
Reports root / small

dynamic_domains_24 / pgsql_mnesia / a9c7461
Reports root/ big
OK: 1615 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

dynamic_domains_23 / pgsql_mnesia / a9c7461
Reports root/ big
OK: 1615 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

small_tests_23 / small_tests / a9c7461
Reports root / small

ldap_mnesia_22 / ldap_mnesia / a9c7461
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / a9c7461
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / a9c7461
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / a9c7461
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / a9c7461
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 282 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / a9c7461
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

pgsql_mnesia_22 / pgsql_mnesia / a9c7461
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / a9c7461
Reports root/ big
OK: 3071 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted

{error,
  {{assertMatch,
     [{module,mod_event_pusher_rabbit_SUITE},
      {line,435},
      {expression,
        "get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
      {pattern,
        "# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
      {value,
        #{<<"from_user_id">> => <<"[email protected]">>,
        <<"message">> => <<>>,
        <<"to_user_id">> =>
          <<"alice_unnamed_66.369271@localhost/res1">>}}]},
   [{mod_event_pusher_rabbit_SUITE,
      '-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
      [{file,
         "/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
       {line,435}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pgsql_mnesia_23 / pgsql_mnesia / a9c7461
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / a9c7461
Reports root/ big
OK: 1750 / Failed: 2 / User-skipped: 285 / Auto-skipped: 0

mod_ping_SUITE:server_ping:server_ping_pong

{error,{{badmatch,[{[<<"localhost">>,mod_ping,ping_response],
          {expected_diff,5},
          {before_story,0},
          {after_story,4}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

mod_ping_SUITE:server_ping_kill:server_ping_pong

{error,{{badmatch,[{[<<"localhost">>,mod_ping,ping_response],
          {expected_diff,5},
          {before_story,10},
          {after_story,14}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

NelsonVides added the WIP 🚧 label Jul 20, 2021

This comment has been minimized.

Sign in to view

NelsonVides force-pushed the multitenancy/privacy branch from e8daf28 to 656530f Compare July 20, 2021 16:42

This comment has been minimized.

Sign in to view

NelsonVides force-pushed the multitenancy/privacy branch from 9dbf4f2 to a7d71c0 Compare July 21, 2021 08:58

This comment has been minimized.

Sign in to view

NelsonVides force-pushed the multitenancy/privacy branch from 661aaf5 to 74f90aa Compare July 21, 2021 09:30

This comment has been minimized.

Sign in to view

NelsonVides force-pushed the multitenancy/privacy branch from 74f90aa to 1168279 Compare July 21, 2021 13:12

This comment has been minimized.

Sign in to view

NelsonVides force-pushed the multitenancy/privacy branch 2 times, most recently from add5d5f to 5d5f5e7 Compare July 21, 2021 14:47

This comment has been minimized.

Sign in to view

NelsonVides force-pushed the multitenancy/privacy branch from 5d5f5e7 to 5a21b22 Compare July 21, 2021 16:04

This comment has been minimized.

Sign in to view

chrzaszcz reviewed Jul 26, 2021

View reviewed changes

NelsonVides added 10 commits July 26, 2021 10:20

Parallelise mod_privacy test suite

3f8c222

Move to subdir

d8aa922

Enable mod_privacy in host_config

a83767c

Enable mod_cache_users in prod

fe453d8

Decouple tests from server names

aac4229

Add host_types into mod_privacy

14ca6c8

Migrate rdbms schema for mod_privacy

0edc465

Implement multitenancy for mod_privacy

2e13431

Test multitenancy

0d2c315

Add discovery capabilities to mod_privacy

dab65a5

Fix xref

a04752a

NelsonVides force-pushed the multitenancy/privacy branch from 5a21b22 to a04752a Compare July 26, 2021 08:23

This comment has been minimized.

Sign in to view

fix mod_blocking

7db8730

NelsonVides marked this pull request as ready for review July 26, 2021 09:55

NelsonVides added waiting-for-review and removed WIP 🚧 labels Jul 26, 2021

vkatsuba reviewed Jul 26, 2021

View reviewed changes

vkatsuba approved these changes Jul 26, 2021

View reviewed changes

arcusfelis reviewed Jul 26, 2021

View reviewed changes

NelsonVides requested a review from arcusfelis July 26, 2021 16:01

arcusfelis approved these changes Jul 26, 2021

View reviewed changes

chrzaszcz reviewed Jul 27, 2021

View reviewed changes

chrzaszcz approved these changes Jul 27, 2021

View reviewed changes

NelsonVides force-pushed the multitenancy/privacy branch from 190e39b to b02ac0c Compare July 27, 2021 07:26

Apply review

a9c7461

NelsonVides force-pushed the multitenancy/privacy branch from b02ac0c to a9c7461 Compare July 27, 2021 07:41

chrzaszcz merged commit f351a3d into master Jul 27, 2021

chrzaszcz deleted the multitenancy/privacy branch July 27, 2021 08:52

Premwoik added this to the 5.0.0 milestone Oct 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multitenancy/privacy #3189

Multitenancy/privacy #3189

NelsonVides commented Jul 20, 2021 •

edited

Loading

This comment has been minimized.

codecov bot commented Jul 20, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

chrzaszcz left a comment

chrzaszcz Jul 26, 2021 •

edited

Loading

This comment has been minimized.

mongoose-im commented Jul 26, 2021 •

edited

Loading

vkatsuba Jul 26, 2021

NelsonVides Jul 26, 2021

vkatsuba Jul 26, 2021

NelsonVides Jul 26, 2021

vkatsuba left a comment

arcusfelis left a comment

mongoose-im commented Jul 26, 2021 •

edited

Loading

arcusfelis left a comment

chrzaszcz left a comment

chrzaszcz Jul 27, 2021

NelsonVides Jul 27, 2021

chrzaszcz Jul 27, 2021

chrzaszcz Jul 27, 2021

chrzaszcz Jul 27, 2021

chrzaszcz Jul 27, 2021

chrzaszcz Jul 27, 2021

chrzaszcz Jul 27, 2021

mongoose-im commented Jul 27, 2021 •

edited

Loading

mongoose-im commented Jul 27, 2021 •

edited

Loading

		server varchar(250) NOT NULL,
		username varchar(250) NOT NULL,

Multitenancy/privacy #3189

Multitenancy/privacy #3189

Conversation

NelsonVides commented Jul 20, 2021 • edited Loading

This comment has been minimized.

codecov bot commented Jul 20, 2021 • edited Loading

Codecov Report

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

chrzaszcz left a comment

Choose a reason for hiding this comment

chrzaszcz Jul 26, 2021 • edited Loading

Choose a reason for hiding this comment

This comment has been minimized.

mongoose-im commented Jul 26, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vkatsuba left a comment

Choose a reason for hiding this comment

arcusfelis left a comment

Choose a reason for hiding this comment

mongoose-im commented Jul 26, 2021 • edited Loading

arcusfelis left a comment

Choose a reason for hiding this comment

chrzaszcz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mongoose-im commented Jul 27, 2021 • edited Loading

mongoose-im commented Jul 27, 2021 • edited Loading

NelsonVides commented Jul 20, 2021 •

edited

Loading

codecov bot commented Jul 20, 2021 •

edited

Loading

chrzaszcz Jul 26, 2021 •

edited

Loading

mongoose-im commented Jul 26, 2021 •

edited

Loading

mongoose-im commented Jul 26, 2021 •

edited

Loading

mongoose-im commented Jul 27, 2021 •

edited

Loading

mongoose-im commented Jul 27, 2021 •

edited

Loading