Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rebar_faster_deps #3201

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Remove rebar_faster_deps #3201

merged 1 commit into from
Jul 30, 2021

Conversation

vkatsuba
Copy link
Contributor

Related also to #2760,

@vkatsuba
Copy link
Contributor Author

GHA

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #3201 (10371ac) into master (6ce018f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3201      +/-   ##
==========================================
- Coverage   80.28%   80.26%   -0.02%     
==========================================
  Files         397      397              
  Lines       32461    32461              
==========================================
- Hits        26060    26055       -5     
- Misses       6401     6406       +5     
Impacted Files Coverage Δ
src/mod_roster_mnesia.erl 72.72% <0.00%> (-21.22%) ⬇️
src/ejabberd_sm.erl 83.93% <0.00%> (-0.66%) ⬇️
src/ejabberd_c2s.erl 89.20% <0.00%> (-0.08%) ⬇️
src/mod_last.erl 87.87% <0.00%> (+1.51%) ⬆️
src/mam/mod_mam_elasticsearch_arch.erl 86.84% <0.00%> (+1.75%) ⬆️
src/mod_last_rdbms.erl 95.83% <0.00%> (+4.16%) ⬆️
src/elasticsearch/mongoose_elasticsearch.erl 84.61% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ce018f...10371ac. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 30, 2021

small_tests_24 / small_tests / 10371ac
Reports root / small


internal_mnesia_24 / internal_mnesia / 10371ac
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0


small_tests_22 / small_tests / 10371ac
Reports root / small


dynamic_domains_24 / pgsql_mnesia / 10371ac
Reports root/ big
OK: 1641 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / 10371ac
Reports root/ big
OK: 1641 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


small_tests_23 / small_tests / 10371ac
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 10371ac
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 10371ac
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / 10371ac
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 10371ac
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 282 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 10371ac
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 10371ac
Reports root/ big
OK: 3068 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / 10371ac
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 10371ac
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 10371ac
Reports root/ big
OK: 3085 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 10371ac
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 285 / Auto-skipped: 0

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NelsonVides NelsonVides merged commit a3e39fd into master Jul 30, 2021
@NelsonVides NelsonVides deleted the deps/remove-rebar_faster_deps branch July 30, 2021 10:23
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants