-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host types for mod_vcard #3221
Merged
Merged
Host types for mod_vcard #3221
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a80a285
Dynamic domains support for mod_vcard_rdbms
arcusfelis 6473973
Host type support for mod_vcard Mnesia, Riak and Ldap backends
arcusfelis b20ee5f
Format iolist in ctl as string
arcusfelis 0491a31
Add info to pool_not_started error
arcusfelis c904089
Add logging of ejabberdctl in big tests
arcusfelis 7f3c00a
Use new api for vcard command api
arcusfelis bd64ea2
Fix dialyzer/xref errors
arcusfelis fde34a8
Use new loop function in cluster_commands_SUITE
arcusfelis 767915d
Add escaping to fix tests
arcusfelis cc73bc5
Rename configured_host to configured_host_type
arcusfelis 493644d
Add vcard suites into dynamic_domains.spec
arcusfelis 0246e1b
Adapt vcard_simple_SUITE for dynamic domains
arcusfelis 23f04d9
Don't try to detect previous mod_vcard settings, just use a helper
arcusfelis 2b05908
Short syntax for hooks in mod_vcard
arcusfelis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -44,12 +44,19 @@ run(Cmd, Args, Opts) -> | |||||
run(Cmd, Args, Opts, Timeout) -> | ||||||
Port = erlang:open_port({spawn_executable, Cmd}, | ||||||
[exit_status, {args, Args} | Opts]), | ||||||
loop(Cmd, Port, [], Timeout). | ||||||
loop(Cmd, Args, Port, [], Timeout). | ||||||
|
||||||
loop(Cmd, Port, Data, Timeout) -> | ||||||
loop(Cmd, Args, Port, Data, Timeout) -> | ||||||
receive | ||||||
{Port, {data, NewData}} -> loop(Cmd, Port, Data++NewData, Timeout); | ||||||
{Port, {exit_status, ExitStatus}} -> {Data, ExitStatus} | ||||||
{Port, {data, NewData}} -> loop(Cmd, Args, Port, Data++NewData, Timeout); | ||||||
{Port, {exit_status, ExitStatus}} -> | ||||||
log_command(Cmd, Args, Data, ExitStatus), | ||||||
{Data, ExitStatus} | ||||||
after Timeout -> | ||||||
erlang:error(#{reason => timeout, command => Cmd}) | ||||||
end. | ||||||
|
||||||
log_command(Cmd, Args, Data, ExitStatus) -> | ||||||
Pattern = lists:flatten(lists:duplicate(length(Args), " ~s")), | ||||||
ct:log("Execute ~s " ++ Pattern ++ "~nResult ~p~nExitStatus ~p", | ||||||
[Cmd] ++ Args ++ [Data, ExitStatus]). | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe fix the space as well?