-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset last_event_id once mongoose_domain_core starts #3226
Conversation
This tells to the service, that it needs to read the complete database. But it assumes that the service process is down, so it would not overwrite the last_event_id we set here. To ensure that the service is down if the core is down, the core and service processes should be supervised with rest_for_one strategy. Which is in a separate PR.
small_tests_24 / small_tests / d0880a6 internal_mnesia_24 / internal_mnesia / d0880a6 small_tests_22 / small_tests / d0880a6 dynamic_domains_24 / pgsql_mnesia / d0880a6 dynamic_domains_23 / pgsql_mnesia / d0880a6 small_tests_23 / small_tests / d0880a6 ldap_mnesia_24 / ldap_mnesia / d0880a6 ldap_mnesia_22 / ldap_mnesia / d0880a6 ldap_mnesia_23 / ldap_mnesia / d0880a6 pgsql_mnesia_22 / pgsql_mnesia / d0880a6 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d0880a6 pgsql_mnesia_24 / pgsql_mnesia / d0880a6 pgsql_mnesia_23 / pgsql_mnesia / d0880a6 mysql_redis_24 / mysql_redis / d0880a6 mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted{error,
{{assertMatch,
[{module,mod_event_pusher_rabbit_SUITE},
{line,435},
{expression,
"get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
{pattern,
"# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
{value,
#{<<"from_user_id">> => <<"[email protected]">>,
<<"message">> => <<>>,
<<"to_user_id">> =>
<<"alice_unnamed_37.948766@localhost/res1">>}}]},
[{mod_event_pusher_rabbit_SUITE,
'-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
[{file,
"/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
{line,435}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} mssql_mnesia_24 / odbc_mssql_mnesia / d0880a6 riak_mnesia_24 / riak_mnesia / d0880a6 |
Codecov Report
@@ Coverage Diff @@
## master #3226 +/- ##
=======================================
Coverage 80.31% 80.32%
=======================================
Files 398 398
Lines 32505 32506 +1
=======================================
+ Hits 26108 26111 +3
+ Misses 6397 6395 -2
Continue to review full report at Codecov.
|
Can you explain how this proposal solves my question at #3224 (comment)? I'm not sure I understand how the new testcase deals with the issue I had. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, after internal discussion this seems to be the right answer, this will get QA-ed soon enough anyway.
This tells to the service, that it needs to read the complete database.
But it assumes that the service process is down, so it would not
overwrite the last_event_id we set here.
To ensure that the service is down if the core is down,
the core and service processes should be supervised with rest_for_one strategy.
Which should be done in a separate PR. Though, it does not required to fix the "join cluster" issue.
This PR addresses MIM-1470