Properly handle get_subhosts in mod_mam_muc_rdbms_arch #3231
Conversation
|
small_tests_24 / small_tests / badb426 internal_mnesia_24 / internal_mnesia / badb426 small_tests_22 / small_tests / badb426 dynamic_domains_24 / pgsql_mnesia / badb426 dynamic_domains_23 / pgsql_mnesia / badb426 small_tests_23 / small_tests / badb426 ldap_mnesia_22 / ldap_mnesia / badb426 ldap_mnesia_24 / ldap_mnesia / badb426 ldap_mnesia_23 / ldap_mnesia / badb426 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / badb426 pgsql_mnesia_24 / pgsql_mnesia / badb426 mysql_redis_24 / mysql_redis / badb426 mam_SUITE:rdbms_async_cache_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}pgsql_mnesia_23 / pgsql_mnesia / badb426 mssql_mnesia_24 / odbc_mssql_mnesia / badb426 pgsql_mnesia_22 / pgsql_mnesia / badb426 riak_mnesia_24 / riak_mnesia / badb426 |
Codecov Report
@@ Coverage Diff @@
## master #3231 +/- ##
==========================================
+ Coverage 80.30% 80.31% +0.01%
==========================================
Files 398 398
Lines 32524 32526 +2
==========================================
+ Hits 26117 26122 +5
+ Misses 6407 6404 -3
Continue to review full report at Codecov.
|
src/mam/mod_mam_muc_rdbms_arch.erl
Outdated
| MucHostPattern = gen_mod:get_module_opt(HostType, mod_muc_light, host, | ||
| mod_muc_light:default_host()), | ||
| LightHostPattern = gen_mod:get_module_opt(HostType, mod_muc, host, | ||
| mod_muc:default_host()), |
There was a problem hiding this comment.
Could you swap these variable names as you are already changing these lines?
arcusfelis
force-pushed
the
mu-fix-get_subhosts-in-mam-muc
branch
from
badb426
to
98e05f5
Compare
|
small_tests_24 / small_tests / 98e05f5 internal_mnesia_24 / internal_mnesia / 98e05f5 dynamic_domains_24 / pgsql_mnesia / 98e05f5 small_tests_22 / small_tests / 98e05f5 dynamic_domains_23 / pgsql_mnesia / 98e05f5 small_tests_23 / small_tests / 98e05f5 ldap_mnesia_23 / ldap_mnesia / 98e05f5 ldap_mnesia_22 / ldap_mnesia / 98e05f5 pgsql_mnesia_24 / pgsql_mnesia / 98e05f5 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 98e05f5 pgsql_mnesia_22 / pgsql_mnesia / 98e05f5 pgsql_mnesia_23 / pgsql_mnesia / 98e05f5 mysql_redis_24 / mysql_redis / 98e05f5 mssql_mnesia_24 / odbc_mssql_mnesia / 98e05f5 carboncopy_SUITE:all:unavailable_resources_dont_get_carbons{error,{{assertion_failed,assert_many,false,[is_presence,is_presence],[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,story,4,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}carboncopy_SUITE:all:prop_forward_sent_chat_messages{error,
{{assertEqual,
[{module,carboncopy_SUITE},
{line,277},
{expression,
"proper : quickcheck ( proper : conjunction ( [ { PropName , Property } ] ) , [ verbose , long_result , { numtests , 3 } ] )"},
{expected,true},
{value,
[[{forward_sent,
[{5,<<"Draws on apace; four happy days bring in">>}]}]]}]},
[{carboncopy_SUITE,run_prop,2,
[{file,"/home/circleci/app/big_tests/tests/carboncopy_SUITE.erl"},
{line,277}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}riak_mnesia_24 / riak_mnesia / 98e05f5 |
Proposed changes include: