Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mod_time multitenancy ready #3255

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Make mod_time multitenancy ready #3255

merged 1 commit into from
Sep 10, 2021

Conversation

NelsonVides
Copy link
Collaborator

As in the title, this was a very simple PR.

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #3255 (bb0829b) into master (cdfd7b9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3255      +/-   ##
==========================================
+ Coverage   80.31%   80.33%   +0.01%     
==========================================
  Files         398      398              
  Lines       32565    32566       +1     
==========================================
+ Hits        26155    26161       +6     
+ Misses       6410     6405       -5     
Impacted Files Coverage Δ
src/mod_last.erl 86.36% <ø> (ø)
src/mod_time.erl 92.85% <100.00%> (+0.54%) ⬆️
src/mongoose_tcp_listener.erl 76.59% <0.00%> (-4.26%) ⬇️
src/domain/mongoose_domain_loader.erl 75.47% <0.00%> (-1.89%) ⬇️
src/global_distrib/mod_global_distrib_utils.erl 64.48% <0.00%> (-0.94%) ⬇️
src/mod_muc_log.erl 77.88% <0.00%> (ø)
src/mod_muc_room.erl 77.18% <0.00%> (+0.23%) ⬆️
src/mod_roster.erl 79.41% <0.00%> (+0.24%) ⬆️
src/ejabberd_sm.erl 84.59% <0.00%> (+0.32%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.85% <0.00%> (+0.42%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdfd7b9...bb0829b. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 9, 2021

small_tests_24 / small_tests / bb0829b
Reports root / small


internal_mnesia_24 / internal_mnesia / bb0829b
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 290 / Auto-skipped: 0


small_tests_22 / small_tests / bb0829b
Reports root / small


dynamic_domains_24 / pgsql_mnesia / bb0829b
Reports root/ big
OK: 1730 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / bb0829b
Reports root/ big
OK: 1730 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


small_tests_23 / small_tests / bb0829b
Reports root / small


ldap_mnesia_23 / ldap_mnesia / bb0829b
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / bb0829b
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / bb0829b
Reports root/ big
OK: 3076 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted
{error,
  {{assertMatch,
     [{module,mod_event_pusher_rabbit_SUITE},
      {line,435},
      {expression,
        "get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
      {pattern,
        "# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
      {value,
        #{<<"from_user_id">> =>
          <<"[email protected]/bOb_unnamed_56.828942">>,
        <<"message">> => <<"Hi there!">>,
        <<"to_user_id">> =>
          <<"alice_unnamed_56.990022@localhost/res1">>}}]},
   [{mod_event_pusher_rabbit_SUITE,
      '-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
      [{file,
         "/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
       {line,435}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


pgsql_mnesia_22 / pgsql_mnesia / bb0829b
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / bb0829b
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / bb0829b
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / bb0829b
Reports root/ big
OK: 1909 / Failed: 1 / User-skipped: 286 / Auto-skipped: 0

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate
{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_11.293007@localhost/res1">>},
        {<<"id">>,<<"1b4826d6-ba04-462f-9b22-2a2a77457ea9">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"f959f0e6-5d22-4954-b41e-8733a98f5104">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_11.293007@localhost/res1' id='1b4826d6-ba04-462f-9b22-2a2a77457ea9' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='f959f0e6-5d22-4954-b41e-8733a98f5104'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,393}]},
    {jingle_SUITE,
      '-res...

Report log


mssql_mnesia_24 / odbc_mssql_mnesia / bb0829b
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / bb0829b
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 289 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrzaszcz chrzaszcz merged commit ddd3533 into master Sep 10, 2021
@chrzaszcz chrzaszcz deleted the multitenancy/mod_time branch September 10, 2021 06:25
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants