-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mod_time multitenancy ready #3255
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3255 +/- ##
==========================================
+ Coverage 80.31% 80.33% +0.01%
==========================================
Files 398 398
Lines 32565 32566 +1
==========================================
+ Hits 26155 26161 +6
+ Misses 6410 6405 -5
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / bb0829b internal_mnesia_24 / internal_mnesia / bb0829b small_tests_22 / small_tests / bb0829b dynamic_domains_24 / pgsql_mnesia / bb0829b dynamic_domains_23 / pgsql_mnesia / bb0829b small_tests_23 / small_tests / bb0829b ldap_mnesia_23 / ldap_mnesia / bb0829b ldap_mnesia_22 / ldap_mnesia / bb0829b mysql_redis_24 / mysql_redis / bb0829b mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted{error,
{{assertMatch,
[{module,mod_event_pusher_rabbit_SUITE},
{line,435},
{expression,
"get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
{pattern,
"# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
{value,
#{<<"from_user_id">> =>
<<"[email protected]/bOb_unnamed_56.828942">>,
<<"message">> => <<"Hi there!">>,
<<"to_user_id">> =>
<<"alice_unnamed_56.990022@localhost/res1">>}}]},
[{mod_event_pusher_rabbit_SUITE,
'-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
[{file,
"/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
{line,435}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} pgsql_mnesia_22 / pgsql_mnesia / bb0829b pgsql_mnesia_24 / pgsql_mnesia / bb0829b pgsql_mnesia_23 / pgsql_mnesia / bb0829b elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / bb0829b jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"iq">>,
[{<<"from">>,<<"error.480@localhost">>},
{<<"to">>,
<<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_11.293007@localhost/res1">>},
{<<"id">>,<<"1b4826d6-ba04-462f-9b22-2a2a77457ea9">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"jingle">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
{<<"action">>,<<"session-terminate">>},
{<<"sid">>,<<"f959f0e6-5d22-4954-b41e-8733a98f5104">>}],
[{xmlel,<<"reason">>,[],
[{xmlel,<<"general-error">>,[],[]},
{xmlel,<<"sip-error">>,
[{<<"code">>,<<"480">>}],
[{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
"<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_11.293007@localhost/res1' id='1b4826d6-ba04-462f-9b22-2a2a77457ea9' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='f959f0e6-5d22-4954-b41e-8733a98f5104'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
[{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
{line,393}]},
{jingle_SUITE,
'-res... mssql_mnesia_24 / odbc_mssql_mnesia / bb0829b riak_mnesia_24 / riak_mnesia / bb0829b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
As in the title, this was a very simple PR.