-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dynamic domains in mod_sic #3258
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3258 +/- ##
==========================================
- Coverage 80.33% 80.33% -0.01%
==========================================
Files 398 398
Lines 32566 32570 +4
==========================================
+ Hits 26163 26164 +1
- Misses 6403 6406 +3
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / 90b7e48 internal_mnesia_24 / internal_mnesia / 90b7e48 dynamic_domains_24 / pgsql_mnesia / 90b7e48 dynamic_domains_23 / pgsql_mnesia / 90b7e48 small_tests_22 / small_tests / 90b7e48 small_tests_23 / small_tests / 90b7e48 ldap_mnesia_24 / ldap_mnesia / 90b7e48 ldap_mnesia_23 / ldap_mnesia / 90b7e48 pgsql_mnesia_24 / pgsql_mnesia / 90b7e48 ldap_mnesia_22 / ldap_mnesia / 90b7e48 pgsql_mnesia_22 / pgsql_mnesia / 90b7e48 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 90b7e48 pgsql_mnesia_23 / pgsql_mnesia / 90b7e48 mssql_mnesia_24 / odbc_mssql_mnesia / 90b7e48 mysql_redis_24 / mysql_redis / 90b7e48 riak_mnesia_24 / riak_mnesia / 90b7e48 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good in general, I have one minor comment.
small_tests_24 / small_tests / 2108f0d internal_mnesia_24 / internal_mnesia / 2108f0d dynamic_domains_24 / pgsql_mnesia / 2108f0d small_tests_22 / small_tests / 2108f0d dynamic_domains_23 / pgsql_mnesia / 2108f0d small_tests_23 / small_tests / 2108f0d ldap_mnesia_22 / ldap_mnesia / 2108f0d ldap_mnesia_24 / ldap_mnesia / 2108f0d pgsql_mnesia_24 / pgsql_mnesia / 2108f0d mysql_redis_24 / mysql_redis / 2108f0d pgsql_mnesia_22 / pgsql_mnesia / 2108f0d ldap_mnesia_23 / ldap_mnesia / 2108f0d mssql_mnesia_24 / odbc_mssql_mnesia / 2108f0d pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_34.762886@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_34.762886@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"fien/DvFN2n5jaq6Jb3YRg==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/app/big_tests/tests/pep_SUITE.erl"},
{line,382}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 2108f0d pgsql_mnesia_23 / pgsql_mnesia / 2108f0d riak_mnesia_24 / riak_mnesia / 2108f0d |
Co-authored-by: Nelson Vides <[email protected]>
small_tests_24 / small_tests / 6755787 internal_mnesia_24 / internal_mnesia / 6755787 small_tests_22 / small_tests / 6755787 dynamic_domains_24 / pgsql_mnesia / 6755787 small_tests_23 / small_tests / 6755787 dynamic_domains_23 / pgsql_mnesia / 6755787 ldap_mnesia_24 / ldap_mnesia / 6755787 jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"iq">>,
[{<<"from">>,<<"error.480@localhost">>},
{<<"to">>,
<<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_54.885791@localhost/res1">>},
{<<"id">>,<<"b4f46449-c1b6-48fd-88ee-f14d0d4d98a2">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"jingle">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
{<<"action">>,<<"session-terminate">>},
{<<"sid">>,<<"e22b9eb8-4aab-4479-9f19-76e511ca7f3d">>}],
[{xmlel,<<"reason">>,[],
[{xmlel,<<"general-error">>,[],[]},
{xmlel,<<"sip-error">>,
[{<<"code">>,<<"480">>}],
[{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
"<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_54.885791@localhost/res1' id='b4f46449-c1b6-48fd-88ee-f14d0d4d98a2' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='e22b9eb8-4aab-4479-9f19-76e511ca7f3d'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
[{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
{line,393}]},
{jingle_SUITE,
'-res... ldap_mnesia_22 / ldap_mnesia / 6755787 ldap_mnesia_23 / ldap_mnesia / 6755787 mssql_mnesia_24 / odbc_mssql_mnesia / 6755787 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 6755787 pgsql_mnesia_22 / pgsql_mnesia / 6755787 pgsql_mnesia_23 / pgsql_mnesia / 6755787 pgsql_mnesia_24 / pgsql_mnesia / 6755787 mysql_redis_24 / mysql_redis / 6755787 riak_mnesia_24 / riak_mnesia / 6755787 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
This PR adds support for dynamic domains in mod_sic and adapts tests.