-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dynamic domains in mod_http_upload #3267
Conversation
small_tests_24 / small_tests / c781985 internal_mnesia_24 / internal_mnesia / c781985 small_tests_22 / small_tests / c781985 small_tests_23 / small_tests / c781985 dynamic_domains_24 / pgsql_mnesia / c781985 dynamic_domains_23 / pgsql_mnesia / c781985 ldap_mnesia_22 / ldap_mnesia / c781985 ldap_mnesia_24 / ldap_mnesia / c781985 ldap_mnesia_23 / ldap_mnesia / c781985 pgsql_mnesia_22 / pgsql_mnesia / c781985 pgsql_mnesia_23 / pgsql_mnesia / c781985 pgsql_mnesia_24 / pgsql_mnesia / c781985 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / c781985 mssql_mnesia_24 / odbc_mssql_mnesia / c781985 dynamic_domains_SUITE:with_mod_dynamic_domains_test:iq_handling_for_subdomain{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"to">>,<<"subdomain2.example.test">>},
{<<"type">>,<<"get">>},
{<<"id">>,<<"a7a7fd2275f0982bca949caeb8f7cc55">>}],
[{xmlel,<<"query">>,[{<<"xmlns">>,<<"dummy.namespace">>}],[]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"subdomain2.example.test">>},
{<<"to">>,<<"[email protected]/res1">>},
{<<"type">>,<<"error">>},
{<<"xml:lang">>,<<"en">>},
{<<"id">>,<<"a7a7fd2275f0982bca949caeb8f7cc55">>}],
[{xmlel,<<"query">>,[{<<"xmlns">>,<<"dummy.namespace">>}],[]},
{xmlel,<<"error">>,
[{<<"code">>,<<"404">>},{<<"type">>,<<"cancel">>}],
[{xmlel,<<"remote-server-not-found">>,
[{<<"xmlns">>,
<<"urn:ietf:params:xml:ns:xmpp-stanzas">>}],
[]},
{xmlel,<<"text">>,
[{<<"xmlns">>,
<<"urn:ietf:params:xml:ns:xmpp-stanzas">>}],
[{xmlcdata,<<"From s2s (waiting)">>}]}]}]},
"<iq from='subdomain2.example.test' to='[email protected]/res1' type='error' xml:lang='en' id='a7a7fd2275f0982bca949caeb8f7cc55'><query xmlns='dummy.namespace'/><error code='404' type='cancel'><remote-server-not-found xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/><text xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>From s2s (waiting)</text></error></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib... mysql_redis_24 / mysql_redis / c781985 riak_mnesia_24 / riak_mnesia / c781985 mod_ping_SUITE:server_ping:server_ping_pong{error,{{badmatch,[{[<<"localhost">>,mod_ping,ping_response],
{expected_diff,5},
{before_story,0},
{after_story,4}}]},
[{escalus_mongooseim,post_story_check_metrics,1,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
{line,74}]},
{escalus_mongooseim,maybe_check_metrics_post_story,1,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
{line,51}]},
{escalus_story,story,4,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,75}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} mssql_mnesia_24 / odbc_mssql_mnesia / c781985 |
Codecov Report
@@ Coverage Diff @@
## master #3267 +/- ##
==========================================
+ Coverage 80.20% 80.23% +0.02%
==========================================
Files 398 398
Lines 32562 32563 +1
==========================================
+ Hits 26117 26126 +9
+ Misses 6445 6437 -8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR adds missing support for dynamic domains in
mod_http_upload
and adapts tests. It also replaceshost
withhost_type
inservice_admin_extra_upload
.