Enable `rdbms_SUITE` and `persistent_cluster_id_SUITE` for dynamic domains #3287

Premwoik · 2021-09-17T11:12:26Z

This PR:

adapts and enables rdbms_SUITE and persistent_cluster_id_SUITE for dynamic domains.
replaces host with host_type in mongoose_rdbms and mongoose_helper

mongoose-im · 2021-09-17T11:23:15Z

small_tests_24 / small_tests / cb82dd6
Reports root / small

internal_mnesia_24 / internal_mnesia / cb82dd6
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 290 / Auto-skipped: 0

small_tests_22 / small_tests / cb82dd6
Reports root / small

ldap_mnesia_22 / ldap_mnesia / cb82dd6
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0

pgsql_mnesia_22 / pgsql_mnesia / cb82dd6
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

codecov · 2021-09-17T11:31:08Z

Codecov Report

Merging #3287 (cb5db58) into master (40943d6) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #3287      +/-   ##
==========================================
- Coverage   80.27%   80.24%   -0.04%     
==========================================
  Files         398      398              
  Lines       32560    32560              
==========================================
- Hits        26137    26127      -10     
- Misses       6423     6433      +10

Impacted Files	Coverage Δ
src/rdbms/mongoose_rdbms.erl	`61.69% <71.42%> (+0.80%)`	⬆️
src/mod_roster_riak.erl	`81.53% <0.00%> (-15.39%)`	⬇️
src/elasticsearch/mongoose_elasticsearch.erl	`76.92% <0.00%> (-7.70%)`	⬇️
src/mam/mod_mam_rdbms_async_pool_writer.erl	`66.66% <0.00%> (-3.93%)`	⬇️
src/global_distrib/mod_global_distrib_receiver.erl	`78.88% <0.00%> (-2.23%)`	⬇️
src/mam/mod_mam_elasticsearch_arch.erl	`85.08% <0.00%> (-1.76%)`	⬇️
src/ejabberd_sm.erl	`84.26% <0.00%> (-0.33%)`	⬇️
src/mod_muc_room.erl	`77.18% <0.00%> (+0.05%)`	⬆️
src/pubsub/mod_pubsub.erl	`73.23% <0.00%> (+0.05%)`	⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40943d6...cb5db58. Read the comment docs.

mongoose-im · 2021-09-17T11:32:32Z

small_tests_24 / small_tests / cb5db58
Reports root / small

internal_mnesia_24 / internal_mnesia / cb5db58
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 290 / Auto-skipped: 0

small_tests_22 / small_tests / cb5db58
Reports root / small

small_tests_23 / small_tests / cb5db58
Reports root / small

dynamic_domains_24 / pgsql_mnesia / cb5db58
Reports root/ big
OK: 2544 / Failed: 0 / User-skipped: 148 / Auto-skipped: 0

dynamic_domains_23 / pgsql_mnesia / cb5db58
Reports root/ big
OK: 2543 / Failed: 1 / User-skipped: 148 / Auto-skipped: 0

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join

{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>],
              [<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>,<<"example4.com">>]}}}

Report log

ldap_mnesia_24 / ldap_mnesia / cb5db58
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0

ldap_mnesia_22 / ldap_mnesia / cb5db58
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / cb5db58
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / cb5db58
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / cb5db58
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

pgsql_mnesia_22 / pgsql_mnesia / cb5db58
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / cb5db58
Reports root/ big
OK: 3047 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / cb5db58
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / cb5db58
Reports root/ big
OK: 3063 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

mam_SUITE:rdbms_async_pool_mam_all:mam06:retract_message

{error,
  {{badmatch,
     {forwarded_message,<<"alicE_retract_message_76.989170@localhost">>,
       <<"alicE_retract_message_76.989170@localhost/res1">>,<<"q1">>,
       <<"BJ1FFAQSPM81">>,
       <<"alice_retract_message_76.989170@localhost/res1">>,
       <<"2021-09-17T11:46:17Z">>,
       <<"bOb_retract_message_76.989170@localhost/res1">>,
       <<"alice_retract_message_76.989170@localhost/res1">>,<<"chat">>,
       <<"OH, HAI!">>,
       [{xmlel,<<"origin-id">>,
          [{<<"xmlns">>,<<"urn:xmpp:sid:0">>},
           {<<"id">>,<<"orig-id-1">>}],
          []}],
       [],false,undefined}},
   [{mam_SUITE,expect_tombstone_and_retraction_message,2,
      [{file,"/home/circleci/app/big_tests/tests/mam_SUITE.erl"},
       {line,3150}]},
    {mam_SUITE,'-retract_message/1-fun-0-',4,
      [{file,"/home/circleci/app/big_tests/tests/mam_SUITE.erl"},
       {line,1864}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / cb5db58
Reports root/ big
OK: 1733 / Failed: 2 / User-skipped: 319 / Auto-skipped: 0

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_85.584012@localhost/res1">>},
        {<<"id">>,<<"5f5a1ba9-f582-4ffc-b137-d9bad8f3a6bf">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"4a20aafd-39ef-4655-8588-826fe233ffeb">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_85.584012@localhost/res1' id='5f5a1ba9-f582-4ffc-b137-d9bad8f3a6bf' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='4a20aafd-39ef-4655-8588-826fe233ffeb'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,393}]},
    {jingle_SUITE,
      '-res...

Report log

mod_ping_SUITE:server_ping:server_ping_pong

{error,{{badmatch,[{[<<"localhost">>,mod_ping,ping_response],
          {expected_diff,5},
          {before_story,0},
          {after_story,4}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

dynamic_domains_23 / pgsql_mnesia / cb5db58
Reports root/ big
OK: 2544 / Failed: 0 / User-skipped: 148 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / cb5db58
Reports root/ big
OK: 3100 / Failed: 2 / User-skipped: 211 / Auto-skipped: 0

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_37.532078@localhost/res1">>},
        {<<"id">>,<<"9e2a99e1-b42c-4291-b114-4832f1e12014">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"cd209a05-1385-4b03-9a47-5ce07be726dc">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_37.532078@localhost/res1' id='9e2a99e1-b42c-4291-b114-4832f1e12014' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='cd209a05-1385-4b03-9a47-5ce07be726dc'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,393}]},
    {jingle_SUITE,
      '-res...

Report log

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_47.580828@localhost/res1">>},
        {<<"id">>,<<"9bfeaa99-ad06-4213-bdc7-4d8024fd7eeb">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"be39b790-2dae-47c2-b9a8-3c7fba5792a1">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_47.580828@localhost/res1' id='9bfeaa99-ad06-4213-bdc7-4d8024fd7eeb' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='be39b790-2dae-47c2-b9a8-3c7fba5792a1'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,393}]},
    {jingle_SUITE,
      '-res...

Report log

dynamic_domains_23 / pgsql_mnesia / cb5db58
Reports root/ big
OK: 2544 / Failed: 0 / User-skipped: 148 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / cb5db58
Reports root/ big
OK: 3100 / Failed: 2 / User-skipped: 211 / Auto-skipped: 0

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_93.265131@localhost/res1">>},
        {<<"id">>,<<"8c6c9300-743c-455d-872b-003dab801048">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"81900e48-20f2-4f63-a2a3-f89450905b41">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_93.265131@localhost/res1' id='8c6c9300-743c-455d-872b-003dab801048' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='81900e48-20f2-4f63-a2a3-f89450905b41'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,393}]},
    {jingle_SUITE,
      '-res...

Report log

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_3.290897@localhost/res1">>},
        {<<"id">>,<<"e43f985d-5cef-4890-bfb2-ddab65136d4a">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"1cb2fa98-46e3-483a-a459-1bd090cb2610">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_3.290897@localhost/res1' id='e43f985d-5cef-4890-bfb2-ddab65136d4a' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='1cb2fa98-46e3-483a-a459-1bd090cb2610'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,393}]},
    {jingle_SUITE,
      '-resp_...

Report log

mssql_mnesia_24 / odbc_mssql_mnesia / cb5db58
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

chrzaszcz

Looks good!

Premwoik added 6 commits September 17, 2021 12:31

Use host_type in mongoose_rdbms

7b70acc

Use host_type in helper function

0e47a83

Adapt rdbms_SUITE for dynamic domains

1293047

Enable rdbms_SUITE for dynamic domains

3510dfb

Adapt persistent_cluster_id_SUITE for dynamic domains

a23e980

Enable persistent_cluster_id_SUITE for dynamic domains

cb5db58

Premwoik force-pushed the dynamic-domains-rdbms-tests branch from cb82dd6 to cb5db58 Compare September 17, 2021 11:22

Premwoik marked this pull request as ready for review September 17, 2021 13:32

chrzaszcz approved these changes Sep 17, 2021

View reviewed changes

chrzaszcz merged commit 28bf705 into master Sep 17, 2021

chrzaszcz deleted the dynamic-domains-rdbms-tests branch September 17, 2021 13:50

Premwoik added this to the 5.0.0 milestone Oct 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable `rdbms_SUITE` and `persistent_cluster_id_SUITE` for dynamic domains #3287

Enable `rdbms_SUITE` and `persistent_cluster_id_SUITE` for dynamic domains #3287

Premwoik commented Sep 17, 2021

mongoose-im commented Sep 17, 2021 •

edited

Loading

codecov bot commented Sep 17, 2021 •

edited

Loading

mongoose-im commented Sep 17, 2021 •

edited

Loading

chrzaszcz left a comment

Enable rdbms_SUITE and persistent_cluster_id_SUITE for dynamic domains #3287

Enable rdbms_SUITE and persistent_cluster_id_SUITE for dynamic domains #3287

Conversation

Premwoik commented Sep 17, 2021

mongoose-im commented Sep 17, 2021 • edited Loading

codecov bot commented Sep 17, 2021 • edited Loading

Codecov Report

mongoose-im commented Sep 17, 2021 • edited Loading

chrzaszcz left a comment

Choose a reason for hiding this comment

Enable `rdbms_SUITE` and `persistent_cluster_id_SUITE` for dynamic domains #3287

Enable `rdbms_SUITE` and `persistent_cluster_id_SUITE` for dynamic domains #3287

mongoose-im commented Sep 17, 2021 •

edited

Loading

codecov bot commented Sep 17, 2021 •

edited

Loading

mongoose-im commented Sep 17, 2021 •

edited

Loading