-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link #3288
Fix broken link #3288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you check also:
doc/migrations/3.6.0_3.7.0.md
doc/migrations/3.7.0_4.0.0.md
doc/migrations/4.0.0_4.0.1.md
doc/migrations/4.0.1_4.1.0.md
doc/migrations/4.1.0_4.2.0.md
to similar problems with links? Do you check also other places where ../../
is used?
I didn't move the Migrations folder, but you are right - I see there are problems with links there, so why not fix them by the way. I will push a fix in a few minutes after I review them. |
8392027
to
398c92b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you check also other documentation places where ../../
is used in links?
Which places do you have in mind? From searching for |
I mean, do you check also those pages?
|
Yeah, sure, these were and are correct (they are a directory deeper - grouped in |
398c92b
to
dd158cc
Compare
small_tests_24 / small_tests / dd158cc internal_mnesia_24 / internal_mnesia / dd158cc small_tests_22 / small_tests / dd158cc small_tests_23 / small_tests / dd158cc dynamic_domains_24 / pgsql_mnesia / dd158cc ldap_mnesia_24 / ldap_mnesia / dd158cc dynamic_domains_23 / pgsql_mnesia / dd158cc ldap_mnesia_22 / ldap_mnesia / dd158cc ldap_mnesia_23 / ldap_mnesia / dd158cc mssql_mnesia_24 / odbc_mssql_mnesia / dd158cc carboncopy_SUITE:all:unavailable_resources_dont_get_carbons{error,{{assertion_failed,assert_many,false,[is_presence,is_presence],[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,story,4,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} pgsql_mnesia_24 / pgsql_mnesia / dd158cc elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / dd158cc mysql_redis_24 / mysql_redis / dd158cc pgsql_mnesia_22 / pgsql_mnesia / dd158cc riak_mnesia_24 / riak_mnesia / dd158cc |
Codecov Report
@@ Coverage Diff @@
## master #3288 +/- ##
=======================================
Coverage 80.25% 80.25%
=======================================
Files 398 398
Lines 32559 32559
=======================================
+ Hits 26129 26130 +1
+ Misses 6430 6429 -1
Continue to review full report at Codecov.
|
This is a follow up for #3259. The links to images in the index.md file got broken while moving files around, but worked locally for me for some reason, so I didn't notice. This fixes the issue.