Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #3288

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Fix broken link #3288

merged 1 commit into from
Sep 21, 2021

Conversation

gustawlippa
Copy link
Contributor

This is a follow up for #3259. The links to images in the index.md file got broken while moving files around, but worked locally for me for some reason, so I didn't notice. This fixes the issue.

Copy link
Contributor

@vkatsuba vkatsuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you check also:

  • doc/migrations/3.6.0_3.7.0.md
  • doc/migrations/3.7.0_4.0.0.md
  • doc/migrations/4.0.0_4.0.1.md
  • doc/migrations/4.0.1_4.1.0.md
  • doc/migrations/4.1.0_4.2.0.md

to similar problems with links? Do you check also other places where ../../ is used?

@gustawlippa
Copy link
Contributor Author

I didn't move the Migrations folder, but you are right - I see there are problems with links there, so why not fix them by the way. I will push a fix in a few minutes after I review them.

Copy link
Contributor

@vkatsuba vkatsuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you check also other documentation places where ../../ is used in links?

@gustawlippa
Copy link
Contributor Author

Which places do you have in mind? From searching for ../../ I think this is only used in the MongoosePush tutorials, and these links are not broken.

@vkatsuba
Copy link
Contributor

Which places do you have in mind? From searching for ../../ I think this is only used in the MongoosePush tutorials, and these links are not broken.

I mean, do you check also those pages?

  • doc/tutorials/push-notifications/MongoosePush-setup.md
  • doc/tutorials/push-notifications/Push-notifications.md

@gustawlippa
Copy link
Contributor Author

Yeah, sure, these were and are correct (they are a directory deeper - grouped in tutorials/push-notifications/).

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 21, 2021

small_tests_24 / small_tests / dd158cc
Reports root / small


internal_mnesia_24 / internal_mnesia / dd158cc
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 290 / Auto-skipped: 0


small_tests_22 / small_tests / dd158cc
Reports root / small


small_tests_23 / small_tests / dd158cc
Reports root / small


dynamic_domains_24 / pgsql_mnesia / dd158cc
Reports root/ big
OK: 2675 / Failed: 0 / User-skipped: 183 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / dd158cc
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / dd158cc
Reports root/ big
OK: 2675 / Failed: 0 / User-skipped: 183 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / dd158cc
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / dd158cc
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / dd158cc
Reports root/ big
OK: 3075 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

carboncopy_SUITE:all:unavailable_resources_dont_get_carbons
{error,{{assertion_failed,assert_many,false,[is_presence,is_presence],[],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log


pgsql_mnesia_24 / pgsql_mnesia / dd158cc
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / dd158cc
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / dd158cc
Reports root/ big
OK: 3047 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / dd158cc
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / dd158cc
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 319 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #3288 (dd158cc) into master (3c5df56) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3288   +/-   ##
=======================================
  Coverage   80.25%   80.25%           
=======================================
  Files         398      398           
  Lines       32559    32559           
=======================================
+ Hits        26129    26130    +1     
+ Misses       6430     6429    -1     
Impacted Files Coverage Δ
src/domain/mongoose_domain_sql.erl 82.85% <0.00%> (-2.86%) ⬇️
src/mam/mod_mam_meta.erl 94.73% <0.00%> (-2.11%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/domain/mongoose_domain_loader.erl 77.35% <0.00%> (-1.89%) ⬇️
src/global_distrib/mod_global_distrib_receiver.erl 78.88% <0.00%> (-1.12%) ⬇️
src/mam/mod_mam.erl 88.33% <0.00%> (-0.84%) ⬇️
src/pubsub/mod_pubsub.erl 73.17% <0.00%> (-0.06%) ⬇️
src/mod_muc_room.erl 77.12% <0.00%> (-0.06%) ⬇️
src/mod_muc_log.erl 77.88% <0.00%> (ø)
src/ejabberd_c2s.erl 89.22% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c5df56...dd158cc. Read the comment docs.

@vkatsuba vkatsuba merged commit aee9d48 into master Sep 21, 2021
@vkatsuba vkatsuba deleted the fix-img-link branch September 21, 2021 09:42
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants