-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support domain removal in the RDBMS auth backend #3295
Conversation
small_tests_24 / small_tests / 23185ce internal_mnesia_24 / internal_mnesia / 23185ce small_tests_23 / small_tests / 23185ce dynamic_domains_24 / pgsql_mnesia / 23185ce ldap_mnesia_24 / ldap_mnesia / 23185ce dynamic_domains_23 / pgsql_mnesia / 23185ce ldap_mnesia_23 / ldap_mnesia / 23185ce pgsql_mnesia_24 / pgsql_mnesia / 23185ce elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 23185ce mysql_redis_24 / mysql_redis / 23185ce mssql_mnesia_24 / odbc_mssql_mnesia / 23185ce pgsql_mnesia_23 / pgsql_mnesia / 23185ce riak_mnesia_24 / riak_mnesia / 23185ce |
Codecov Report
@@ Coverage Diff @@
## master #3295 +/- ##
==========================================
- Coverage 80.22% 80.21% -0.02%
==========================================
Files 398 398
Lines 32574 32577 +3
==========================================
- Hits 26134 26133 -1
- Misses 6440 6444 +4
Continue to review full report at Codecov.
|
23185ce
to
2f5005b
Compare
small_tests_24 / small_tests / 2f5005b internal_mnesia_24 / internal_mnesia / 2f5005b small_tests_23 / small_tests / 2f5005b ldap_mnesia_24 / ldap_mnesia / 2f5005b dynamic_domains_24 / pgsql_mnesia / 2f5005b ldap_mnesia_23 / ldap_mnesia / 2f5005b dynamic_domains_23 / pgsql_mnesia / 2f5005b elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 2f5005b mysql_redis_24 / mysql_redis / 2f5005b mssql_mnesia_24 / odbc_mssql_mnesia / 2f5005b pgsql_mnesia_24 / pgsql_mnesia / 2f5005b pgsql_mnesia_23 / pgsql_mnesia / 2f5005b riak_mnesia_24 / riak_mnesia / 2f5005b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I have only one question.
Please resolve conflicts with |
- Check with XMPP and SQL - Additional check that a user from a different domain can connect - Export all functions for flexibility in tests
2f5005b
to
baf4758
Compare
small_tests_24 / small_tests / baf4758 internal_mnesia_24 / internal_mnesia / baf4758 small_tests_23 / small_tests / baf4758 dynamic_domains_24 / pgsql_mnesia / baf4758 dynamic_domains_23 / pgsql_mnesia / baf4758 pgsql_mnesia_24 / pgsql_mnesia / baf4758 ldap_mnesia_23 / ldap_mnesia / baf4758 mysql_redis_24 / mysql_redis / baf4758 mssql_mnesia_24 / odbc_mssql_mnesia / baf4758 ldap_mnesia_24 / ldap_mnesia / baf4758 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / baf4758 pgsql_mnesia_23 / pgsql_mnesia / baf4758 riak_mnesia_24 / riak_mnesia / baf4758 |
Implement callback, add tests.
Also: export all functions from the test suite for easier debugging. We are doing this for most test suites.