Handler records don't need the key #3342
Conversation
Handlers are all queried by a known key, and when the ets is fetched by the key, the handlers are all deeply-copied, no sharing of keys, which means the hook key, with all the host types, are copied into the reader many times. This field can be entirely dropped, it is not used by run_fold.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #3342 +/- ##
==========================================
- Coverage 80.72% 80.64% -0.09%
==========================================
Files 397 397
Lines 32430 32432 +2
==========================================
- Hits 26179 26154 -25
- Misses 6251 6278 +27
Continue to review full report at Codecov.
|
|
small_tests_24 / small_tests / 6bb6dc8 internal_mnesia_24 / internal_mnesia / 6bb6dc8 small_tests_23 / small_tests / 6bb6dc8 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6bb6dc8 ldap_mnesia_24 / ldap_mnesia / 6bb6dc8 dynamic_domains_mysql_redis_24 / mysql_redis / 6bb6dc8 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 6bb6dc8 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 6bb6dc8 ldap_mnesia_23 / ldap_mnesia / 6bb6dc8 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 6bb6dc8 pgsql_mnesia_24 / pgsql_mnesia / 6bb6dc8 mysql_redis_24 / mysql_redis / 6bb6dc8 pgsql_mnesia_23 / pgsql_mnesia / 6bb6dc8 mssql_mnesia_24 / odbc_mssql_mnesia / 6bb6dc8 inbox_SUITE:one_to_one:reset_unread_counter_and_show_only_unread{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"mike_reset_unread_counter_and_show_only_unread_73.229543@localhost/res1">>,
escalus_tcp,<0.17223.0>,
[{event_manager,<0.17145.0>},
{server,<<"localhost">>},
{username,
<<"mike_reset_unread_counter_and_show_only_unread_73.229543">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.17145.0>},
{server,<<"localhost">>},
{username,
<<"mike_reset_unread_counter_and_show_only_unread_73.229543">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"mike_reset_unread_counter_and_show_only_unread_73.229543">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"mike_reset_unread_counter_and_show_only_unread_73.229543">>},
{server,<<"localhost">>},
{password,<<"nicniema">>},
{stream_id,<<"70ac1705211933fa">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,get_inbox,3,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,221}]},
{inbox_SUITE,'-...pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_74.859375@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_74.859375@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"vW9T7W+2pr2ZymNTFG2zlw==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/app/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}riak_mnesia_24 / riak_mnesia / 6bb6dc8 mssql_mnesia_24 / odbc_mssql_mnesia / 6bb6dc8 |
Handlers are all queried by a known key, and when the ets is fetched
by the key, the handlers are all deeply-copied, no sharing of keys,
which means the hook key, with all the host types, are copied into
the reader many times. This field can be entirely dropped,
it is not used by run_fold.