-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mod roster remove dynamic modules #3364
Mod roster remove dynamic modules #3364
Conversation
small_tests_24 / small_tests / 6c14607 internal_mnesia_24 / internal_mnesia / 6c14607 small_tests_23 / small_tests / 6c14607 ldap_mnesia_24 / ldap_mnesia / 6c14607 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6c14607 dynamic_domains_mysql_redis_24 / mysql_redis / 6c14607 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 6c14607 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 6c14607 ldap_mnesia_23 / ldap_mnesia / 6c14607 pgsql_mnesia_24 / pgsql_mnesia / 6c14607 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 6c14607 mysql_redis_24 / mysql_redis / 6c14607 pgsql_mnesia_23 / pgsql_mnesia / 6c14607 mssql_mnesia_24 / odbc_mssql_mnesia / 6c14607 riak_mnesia_24 / riak_mnesia / 6c14607 |
Codecov Report
@@ Coverage Diff @@
## without-dynamic-backend-modules #3364 +/- ##
===================================================================
- Coverage 80.92% 80.85% -0.08%
===================================================================
Files 412 413 +1
Lines 32613 32639 +26
===================================================================
- Hits 26391 26389 -2
- Misses 6222 6250 +28
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / 42ed2ab internal_mnesia_24 / internal_mnesia / 42ed2ab small_tests_23 / small_tests / 42ed2ab dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 42ed2ab ldap_mnesia_24 / ldap_mnesia / 42ed2ab dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 42ed2ab ldap_mnesia_23 / ldap_mnesia / 42ed2ab dynamic_domains_mysql_redis_24 / mysql_redis / 42ed2ab dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 42ed2ab pgsql_mnesia_23 / pgsql_mnesia / 42ed2ab mysql_redis_24 / mysql_redis / 42ed2ab pgsql_mnesia_24 / pgsql_mnesia / 42ed2ab elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 42ed2ab mssql_mnesia_24 / odbc_mssql_mnesia / 42ed2ab riak_mnesia_24 / riak_mnesia / 42ed2ab |
small_tests_24 / small_tests / d653ba0 internal_mnesia_24 / internal_mnesia / d653ba0 small_tests_23 / small_tests / d653ba0 ldap_mnesia_24 / ldap_mnesia / d653ba0 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d653ba0 dynamic_domains_mysql_redis_24 / mysql_redis / d653ba0 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / d653ba0 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d653ba0 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d653ba0 ldap_mnesia_23 / ldap_mnesia / d653ba0 pgsql_mnesia_24 / pgsql_mnesia / d653ba0 pgsql_mnesia_23 / pgsql_mnesia / d653ba0 mysql_redis_24 / mysql_redis / d653ba0 riak_mnesia_24 / riak_mnesia / d653ba0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, only the conflict in rebar.config
should be resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
small_tests_24 / small_tests / e29d70a internal_mnesia_24 / internal_mnesia / e29d70a small_tests_23 / small_tests / e29d70a ldap_mnesia_24 / ldap_mnesia / e29d70a dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / e29d70a dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / e29d70a ldap_mnesia_23 / ldap_mnesia / e29d70a dynamic_domains_mysql_redis_24 / mysql_redis / e29d70a mam_SUITE:rdbms_prefs_cases:prefs_set_cdata_request{error,{test_case_failed,"ASSERT EQUAL\n\tExpected {prefs_result_iq,<<\"roster\">>,\n [<<\"[email protected]\">>,\n <<\"[email protected]\">>],\n []}\n\tValue {prefs_result_iq,<<\"always\">>,\n [<<\"[email protected]\">>,\n <<\"[email protected]\">>],\n []}\n"}} dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / e29d70a elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / e29d70a pgsql_mnesia_24 / pgsql_mnesia / e29d70a pgsql_mnesia_23 / pgsql_mnesia / e29d70a mysql_redis_24 / mysql_redis / e29d70a mam_SUITE:rdbms_async_pool_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}} mssql_mnesia_24 / odbc_mssql_mnesia / e29d70a riak_mnesia_24 / riak_mnesia / e29d70a |
Removing dynamically compiled modules from mod_roster