MAM cassandra backend without dynamicly compiled modules #3373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arcusfelis
commented
Oct 27, 2021
arcusfelis
commented
- Also, converted MAM cassandra modules to use HostType
Add host types into mod_mam_cassandra_arch
Use db_message_format=mam_message_xml by default now in mod_mam_muc_cassandra_arch and mod_mam_cassandra_arch Get rid of mod_mam_muc_cassandra_arch_params
Codecov Report
@@ Coverage Diff @@
## without-dynamic-backend-modules #3373 +/- ##
====================================================================
- Coverage 80.87% 60.69% -20.18%
====================================================================
Files 410 411 +1
Lines 32666 32573 -93
====================================================================
- Hits 26417 19771 -6646
- Misses 6249 12802 +6553
Continue to review full report at Codecov.
|
|
small_tests_24 / small_tests / 91c7982 internal_mnesia_24 / internal_mnesia / 91c7982 small_tests_23 / small_tests / 91c7982 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 91c7982 dynamic_domains_mysql_redis_24 / mysql_redis / 91c7982 mam_SUITE:rdbms_cache_prefs_cases:messages_filtered_when_prefs_default_policy_is_never{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}mam_SUITE:rdbms_cache_prefs_cases:messages_filtered_when_prefs_default_policy_is_never{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}ldap_mnesia_24 / ldap_mnesia / 91c7982 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 91c7982 inbox_SUITE:one_to_one:check_total_unread_count_and_active_conv_count{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"mike_check_total_unread_count_and_active_conv_count_74.273604@domain.example.com/res1">>,
escalus_tcp,<0.16430.0>,
[{event_manager,<0.16355.0>},
{server,<<"domain.example.com">>},
{username,
<<"mike_check_total_unread_count_and_active_conv_count_74.273604">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16355.0>},
{server,<<"domain.example.com">>},
{username,
<<"mike_check_total_unread_count_and_active_conv_count_74.273604">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"mike_check_total_unread_count_and_active_conv_count_74.273604">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"mike_check_total_unread_count_and_active_conv_count_74.273604">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"nicniema">>},
{stream_id,<<"29fe3117ac8db019">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,send_msg,3,
[...inbox_SUITE:one_to_one:user_has_two_conversations{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.16435.0>,
[{event_manager,<0.16283.0>},
{server,<<"domain.example.com">>},
{username,<<"kate_user_has_two_conversations_74.237610">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16283.0>},
{server,<<"domain.example.com">>},
{username,
<<"kate_user_has_two_conversations_74.237610">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_user_has_two_conversations_74.237610">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_user_has_two_conversations_74.237610">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"12728526cca53cd8">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,420}]},
{lists,foldl,3,[{file...inbox_SUITE:one_to_one:carbons_are_not_stored{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.16433.0>,
[{event_manager,<0.16262.0>},
{server,<<"domain.example.com">>},
{username,<<"bOb_carbons_are_not_stored_74.231724">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16262.0>},
{server,<<"domain.example.com">>},
{username,<<"bOb_carbons_are_not_stored_74.231724">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bOb_carbons_are_not_stored_74.231724">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_carbons_are_not_stored_74.231724">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"aceaafccf6189fe2">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,420}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{inbox...inbox_SUITE:one_to_one:other_resources_do_not_interfere{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"mike_other_resources_do_not_interfere_74.259765@domain.example.com/res1">>,
escalus_tcp,<0.16436.0>,
[{event_manager,<0.16318.0>},
{server,<<"domain.example.com">>},
{username,
<<"mike_other_resources_do_not_interfere_74.259765">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16318.0>},
{server,<<"domain.example.com">>},
{username,
<<"mike_other_resources_do_not_interfere_74.259765">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"mike_other_resources_do_not_interfere_74.259765">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"mike_other_resources_do_not_interfere_74.259765">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"nicniema">>},
{stream_id,<<"e9c780412d5af685">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,send_msg,3,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
...inbox_SUITE:one_to_one:user_has_only_unread_messages_or_only_read{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"kate_user_has_only_unread_messages_or_only_read_74.236314@domain.example.com/res1">>,
escalus_tcp,<0.16448.0>,
[{event_manager,<0.16276.0>},
{server,<<"domain.example.com">>},
{username,
<<"kate_user_has_only_unread_messages_or_only_read_74.236314">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16276.0>},
{server,<<"domain.example.com">>},
{username,
<<"kate_user_has_only_unread_messages_or_only_read_74.236314">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"kate_user_has_only_unread_messages_or_only_read_74.236314">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"kate_user_has_only_unread_messages_or_only_read_74.236314">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"4366a045ca37897e">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-'...inbox_SUITE:one_to_one:reset_unread_counter_and_show_only_unread{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"mike_reset_unread_counter_and_show_only_unread_74.272119@domain.example.com/res1">>,
escalus_tcp,<0.16432.0>,
[{event_manager,<0.16346.0>},
{server,<<"domain.example.com">>},
{username,
<<"mike_reset_unread_counter_and_show_only_unread_74.272119">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16346.0>},
{server,<<"domain.example.com">>},
{username,
<<"mike_reset_unread_counter_and_show_only_unread_74.272119">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"mike_reset_unread_counter_and_show_only_unread_74.272119">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"mike_reset_unread_counter_and_show_only_unread_74.272119">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"nicniema">>},
{stream_id,<<"d995d0426a7e6851">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,get_inbox,3,
[{file,"/home/circleci/ap...inbox_SUITE:muclight:groupchat_markers_all_reset_room_created{error,
{{badrpc,
{'EXIT',
{timeout,
{gen_server,call,
['wpool_pool-mongoose_wpool$rdbms$global$default-2',
{sql_cmd,
{sql_execute,auth_get_password,
[<<"domain.example.com">>,
<<"bob_groupchat_markers_all_reset_room_created_80.303328">>]},
-576460470670},
60000]}}}},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"bOb_groupchat_markers_all_reset_room_created_80.303328">>,
<<"domain.example.com">>,<<"makrolika">>],
3000,ejabberd],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server...inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox{error,
{{badrpc,
{'EXIT',
{timeout,
{gen_server,call,
['wpool_pool-mongoose_wpool$rdbms$global$default-3',
{sql_cmd,
{sql_execute,auth_get_password,
[<<"domain.example.com">>,
<<"alice_simple_groupchat_stored_in_all_inbox_80.316838">>]},
-576460470662},
60000]}}}},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_simple_groupchat_stored_in_all_inbox_80.316838">>,
<<"domain.example.com">>,<<"matygrysa">>],
3000,ejabberd],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl...inbox_SUITE:muclight:groupchat_reset_stanza_resets_inbox{error,
{{badrpc,
{'EXIT',
{timeout,
{gen_server,call,
['wpool_pool-mongoose_wpool$rdbms$global$default-3',
{sql_cmd,
{sql_execute,auth_get_password,
[<<"domain.example.com">>,
<<"alice_groupchat_reset_stanza_resets_inbox_80.320065">>]},
-576460470662},
60000]}}}},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_groupchat_reset_stanza_resets_inbox_80.320065">>,
<<"domain.example.com">>,<<"matygrysa">>],
3000,ejabberd],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"}...dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 91c7982 rest_client_SUITE:muc:messages_can_be_paginated_in_room{error,
{{assertion_failed,assert,is_chat_message,
[<<"2813a97b">>],
{xmlel,<<"message">>,
[{<<"to">>,<<"[email protected]">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"e9c7207f">>}]}]},
"<message to='[email protected]' type='chat'><body>e9c7207f</body></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{rest_client_SUITE,assert_room_messages,2,
[{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
{line,772}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1784}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1293}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1225}]}]}}ldap_mnesia_23 / ldap_mnesia / 91c7982 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 91c7982 pgsql_mnesia_24 / pgsql_mnesia / 91c7982 mysql_redis_24 / mysql_redis / 91c7982 rest_client_SUITE:muc:messages_can_be_paginated_in_room{error,
{{assertion_failed,assert,is_chat_message,
[<<"bccc4126">>],
{xmlel,<<"message">>,
[{<<"to">>,<<"[email protected]">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"eea1063d">>}]}]},
"<message to='[email protected]' type='chat'><body>eea1063d</body></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{rest_client_SUITE,assert_room_messages,2,
[{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
{line,772}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}mssql_mnesia_24 / odbc_mssql_mnesia / 91c7982 pep_SUITE:pep_tests:delayed_receive{error,{{badmatch,[]},
[{pep_SUITE,'-delayed_receive/1-fun-0-',3,
[{file,"/home/circleci/app/big_tests/tests/pep_SUITE.erl"},
{line,276}]},
{escalus_story,story,4,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}pep_SUITE:pep_tests:delayed_receive_with_sm{error,{{badmatch,[]},
[{pep_SUITE,'-delayed_receive_with_sm/1-fun-0-',3,
[{file,"/home/circleci/app/big_tests/tests/pep_SUITE.erl"},
{line,295}]},
{escalus_story,story,4,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}pep_SUITE:pep_tests:publish_and_notify_test{error,
{{assertion_failed,assert_many,false,
[is_roster_set,is_presence,is_presence],
[{xmlel,<<"presence">>,
[{<<"from">>,
<<"bOb_publish_and_notify_test_14.307702@localhost/res1">>},
{<<"to">>,
<<"alice_publish_and_notify_test_14.307702@localhost/res1">>},
{<<"xml:lang">>,<<"en">>}],
[{xmlel,<<"c">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/caps">>},
{<<"hash">>,<<"sha-1">>},
{<<"node">>,<<"http://www.chatopus.com">>},
{<<"ver">>,<<"4SHv7I4xaxA21Oadrepl5qBTBl4=">>}],
[]}]}],
" <presence from='bOb_publish_and_notify_test_14.307702@localhost/res1' to='alice_publish_and_notify_test_14.307702@localhost/res1' xml:lang='en'><c xmlns='http://jabber.org/protocol/caps' hash='sha-1' node='http://www.chatopus.com' ver='4SHv7I4xaxA21Oadrepl5qBTBl4='/></presence>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-make_all_clients_friends/1-fun-0-',2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,114}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_utils,'-each_...pgsql_mnesia_23 / pgsql_mnesia / 91c7982 riak_mnesia_24 / riak_mnesia / 91c7982 |
|
small_tests_24 / small_tests / c94502a internal_mnesia_24 / internal_mnesia / c94502a small_tests_23 / small_tests / c94502a ldap_mnesia_24 / ldap_mnesia / c94502a ldap_mnesia_23 / ldap_mnesia / c94502a dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c94502a dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / c94502a dynamic_domains_mysql_redis_24 / mysql_redis / c94502a mam_SUITE:rdbms_prefs_cases:prefs_set_cdata_request{error,{test_case_failed,"ASSERT EQUAL\n\tExpected {prefs_result_iq,<<\"roster\">>,\n [<<\"[email protected]\">>,\n <<\"[email protected]\">>],\n []}\n\tValue {prefs_result_iq,<<\"always\">>,\n [<<\"[email protected]\">>,\n <<\"[email protected]\">>],\n []}\n"}}dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / c94502a elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / c94502a pgsql_mnesia_24 / pgsql_mnesia / c94502a mysql_redis_24 / mysql_redis / c94502a mam_SUITE:rdbms_async_pool_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}pgsql_mnesia_23 / pgsql_mnesia / c94502a mssql_mnesia_24 / odbc_mssql_mnesia / c94502a riak_mnesia_24 / riak_mnesia / c94502a |
vkatsuba
reviewed
Oct 27, 2021
src/mam/mod_mam_cassandra_arch.erl
Outdated
| @@ -30,8 +30,6 @@ | |||
|
|
|||
| -define(MOD_MAM_CASSANDRA_ARCH_PARAMS, mod_mam_cassandra_arch_params). | |||
There was a problem hiding this comment.
This macros is not used anymore in this module, please remove it.
vkatsuba
reviewed
Oct 27, 2021
| [Row] when | ||
| PoolName :: mongoose_cassandra:pool_name(), | ||
| RoomJID :: jid:jid(), | ||
| Host :: server_hostname(), | ||
| HostType :: server_hostname(), |
There was a problem hiding this comment.
Maybe make sense start use mongooseim:host_type() instead of server_hostname() in all HostType :: server_hostname() places.
|
small_tests_24 / small_tests / 01ba08c internal_mnesia_24 / internal_mnesia / 01ba08c |
vkatsuba
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.