Remove ejabberd_rdbms and mongoose_rdbms_type #3392
Conversation
Codecov Report
@@ Coverage Diff @@
## without-dynamic-backend-modules #3392 +/- ##
===================================================================
- Coverage 80.90% 80.87% -0.04%
===================================================================
Files 415 414 -1
Lines 32654 32647 -7
===================================================================
- Hits 26419 26402 -17
- Misses 6235 6245 +10
Continue to review full report at Codecov.
|
|
small_tests_24 / small_tests / 714bbe7 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 714bbe7 mssql_mnesia_24 / odbc_mssql_mnesia / 714bbe7 internal_mnesia_24 / internal_mnesia / 714bbe7 small_tests_23 / small_tests / 714bbe7 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 714bbe7 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 714bbe7 ldap_mnesia_24 / ldap_mnesia / 714bbe7 ldap_mnesia_23 / ldap_mnesia / 714bbe7 dynamic_domains_mysql_redis_24 / mysql_redis / 714bbe7 pgsql_mnesia_24 / pgsql_mnesia / 714bbe7 amp_big_SUITE:offline:offline_failure:notify_deliver_to_unknown_domain_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alicE_notify_deliver_to_unknown_domain_test_82.122947@localhost/res1">>,
escalus_tcp,<0.7195.0>,
[{event_manager,<0.6942.0>},
{server,<<"localhost">>},
{username,
<<"alicE_notify_deliver_to_unknown_domain_test_82.122947">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.6942.0>},
{server,<<"localhost">>},
{username,
<<"alicE_notify_deliver_to_unknown_domain_test_82.122947">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alicE_notify_deliver_to_unknown_domain_test_82.122947">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_notify_deliver_to_unknown_domain_test_82.122947">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"378cfc328d3636c9">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{amp_big_SUITE,client_receives_generic_error,3,
[{file,"/home/circleci/app/big_tests/tests/amp_big_SUITE.erl"},
{line,796}]},
{amp_big_S...elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 714bbe7 pgsql_mnesia_23 / pgsql_mnesia / 714bbe7 mysql_redis_24 / mysql_redis / 714bbe7 mam_SUITE:rdbms_prefs_cases:messages_filtered_when_prefs_default_policy_is_never{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok,ok]\n"}}riak_mnesia_24 / riak_mnesia / 714bbe7 rest_client_SUITE:muc:messages_can_be_paginated_in_room{error,
{{assertion_failed,assert,is_chat_message,
[<<"537dd05a">>],
{xmlel,<<"message">>,
[{<<"to">>,<<"[email protected]">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"44c9e087">>}]}]},
"<message to='[email protected]' type='chat'><body>44c9e087</body></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{rest_client_SUITE,assert_room_messages,2,
[{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
{line,772}]},
{rest_client_SUITE,'-messages_can_be_paginated_in_room/1-fun-0-',3,
[{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
{line,538}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} |
gustawlippa
force-pushed
the
wdbm-ejabberd_rdbms
branch
from
714bbe7
to
49157c4
Compare
|
small_tests_24 / small_tests / 49157c4 internal_mnesia_24 / internal_mnesia / 49157c4 small_tests_23 / small_tests / 49157c4 ldap_mnesia_24 / ldap_mnesia / 49157c4 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 49157c4 ldap_mnesia_23 / ldap_mnesia / 49157c4 dynamic_domains_mysql_redis_24 / mysql_redis / 49157c4 mam_SUITE:rdbms_async_cache_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 49157c4 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 49157c4 mysql_redis_24 / mysql_redis / 49157c4 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 49157c4 mssql_mnesia_24 / odbc_mssql_mnesia / 49157c4 pgsql_mnesia_24 / pgsql_mnesia / 49157c4 pgsql_mnesia_23 / pgsql_mnesia / 49157c4 riak_mnesia_24 / riak_mnesia / 49157c4 |
Get rid of
ejabberd_rdbmsbecause all it did was compilemongoose_rdbms_type. In turn, all it did was get an option from the config.The functionality is left as it was. From what I understand, one can (in theory) use ODBC with different databases, so maybe the
rdbms_server_typeoption is needed, but it could at least be moved from thegeneralsection to the RDBMS pool options. This could be done after dynamically compiled modules are merged.