Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce config defaults for the 'general' section #3409

Merged
merged 5 commits into from
Nov 23, 2021
Merged

Introduce config defaults for the 'general' section #3409

merged 5 commits into from
Nov 23, 2021

Commits on Nov 22, 2021

  1. Support defaults in TOML sections 

    Default values should be valid and in the already processed form, so
only the 'format' step is performed for them.

This allows specifying defaults for subsections without having to put
them in the raw TOML format.
    @chrzaszcz
    chrzaszcz committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    16b7a92 View commit details
    Browse the repository at this point in the history

  2. Specify defaults for the 'general' section 

    rdbms_server_type had conflicting defaults, now it is 'generic';
this option needs to be removed anyway.
    @chrzaszcz
    chrzaszcz committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    0cead82 View commit details
    Browse the repository at this point in the history

  3. Set default options required by small tests 

    Setting them explicitly makes it clear which ones are required,
even though it is a bit more verbose.
    @chrzaszcz
    chrzaszcz committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    87a3e45 View commit details
    Browse the repository at this point in the history

  4. Add tests for defaults in the 'general' section 

    To make it easier, the 'parse' function was extended with the
'without' option, that prevents 'hosts' and 'default_server_domain'
from being inserted automatically.
    @chrzaszcz
    chrzaszcz committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    a2a2fcb View commit details
    Browse the repository at this point in the history

  5. Update expected TOML options with defaults

    @chrzaszcz
    chrzaszcz committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    c75b417 View commit details
    Browse the repository at this point in the history