-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL - Better error messages formatting #3454
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/graphql #3454 +/- ##
===================================================
- Coverage 80.84% 80.83% -0.02%
===================================================
Files 424 424
Lines 32529 32566 +37
===================================================
+ Hits 26298 26324 +26
- Misses 6231 6242 +11
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
385e621
to
5e16dec
Compare
This comment has been minimized.
This comment has been minimized.
5e16dec
to
5cf748d
Compare
This comment has been minimized.
This comment has been minimized.
5cf748d
to
c2f50e4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c0671d1
to
ae21392
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ae21392
to
8584d4e
Compare
This comment has been minimized.
This comment has been minimized.
8584d4e
to
2d44a28
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, error handling looks improved. I think some possible GraphQL errors are not fully tested - only formatting is checked. I guess it's just difficult to actually trigger all errors by faulty queries?
06bec49
to
88102c2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR addresses MIM-1569 and solves wrongly formatted messages returned to the user from the webserver.
Proposed changes include: