Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run MSSQL as root again #3456

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Run MSSQL as root again #3456

merged 1 commit into from
Dec 15, 2021

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Dec 15, 2021

This should fix an error on Linux with permissions (and Github Actions CI).
We used to have it there.
Circle CI does not need this. Mac does not need it too (weird)

Testing:

  • Get some linux and run
DB=mssql tools/setup-db.sh

This should fix an error on Linux with permissions (and Github Actions CI)
@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 15, 2021

small_tests_24 / small_tests / d8d9244
Reports root / small


small_tests_23 / small_tests / d8d9244
Reports root / small


dynamic_domains_mysql_redis_24 / mysql_redis / d8d9244
Reports root/ big
OK: 2710 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d8d9244
Reports root/ big
OK: 2727 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d8d9244
Reports root/ big
OK: 2727 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / d8d9244
Reports root/ big
OK: 2727 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / d8d9244
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / d8d9244
Reports root/ big
OK: 1504 / Failed: 1 / User-skipped: 386 / Auto-skipped: 0

sm_SUITE:unacknowledged_message_hook:unacknowledged_message_hook_bounce
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"msg-1">>],
     {xmlel,<<"message">>,
       [{<<"from">>,
         <<"bOb_unacknowledged_message_hook_bounce_1443@localhost/escalus-default-resource">>},
        {<<"to">>,
         <<"alicE_unacknowledged_message_hook_bounce_1445@localhost">>},
        {<<"xml:lang">>,<<"en">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"msg-2">>}]},
        {xmlel,<<"delay">>,
          [{<<"xmlns">>,<<"urn:xmpp:delay">>},
           {<<"stamp">>,<<"2021-12-15T16:48:06.397621Z">>},
           {<<"from">>,<<"localhost">>}],
          [{xmlcdata,<<"SM Storage">>}]}]},
     "<message from='bOb_unacknowledged_message_hook_bounce_1443@localhost/escalus-default-resource' to='alicE_unacknowledged_message_hook_bounce_1445@localhost' xml:lang='en' type='chat'><body>msg-2</body><delay xmlns='urn:xmpp:delay' stamp='2021-12-15T16:48:06.397621Z' from='localhost'>SM Storage</delay></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {sm_SUITE,unacknowledged_message_hook_common,2,
      [{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
       {line,885}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"tes...

Report log


internal_mnesia_24 / internal_mnesia / d8d9244
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 301 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / d8d9244
Reports root/ big
OK: 3114 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d8d9244
Reports root/ big
OK: 1880 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / d8d9244
Reports root/ big
OK: 3114 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / d8d9244
Reports root/ big
OK: 3114 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / d8d9244
Reports root/ big
OK: 3109 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / d8d9244
Reports root/ big
OK: 1726 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #3456 (d8d9244) into master (725d139) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3456      +/-   ##
==========================================
+ Coverage   80.83%   80.84%   +0.01%     
==========================================
  Files         415      415              
  Lines       32317    32317              
==========================================
+ Hits        26123    26128       +5     
+ Misses       6194     6189       -5     
Impacted Files Coverage Δ
src/mam/mod_mam_rdbms_async_pool_writer.erl 66.66% <0.00%> (-3.93%) ⬇️
src/cassandra/mongoose_cassandra.erl 77.77% <0.00%> (-3.71%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 65.72% <0.00%> (-2.82%) ⬇️
src/logger/mongoose_log_filter.erl 78.08% <0.00%> (-1.37%) ⬇️
src/mod_muc_room.erl 76.80% <0.00%> (-0.47%) ⬇️
src/mod_muc_log.erl 78.11% <0.00%> (ø)
src/ejabberd_c2s.erl 89.19% <0.00%> (+0.29%) ⬆️
src/mod_roster_rdbms.erl 96.15% <0.00%> (+0.76%) ⬆️
src/privacy/mod_privacy.erl 85.71% <0.00%> (+0.84%) ⬆️
src/mam/mod_mam_elasticsearch_arch.erl 86.84% <0.00%> (+1.75%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 725d139...d8d9244. Read the comment docs.

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Github actions is happy https://github.com/esl/MongooseIM/runs/4536925101, my linux machine is happy, we're all happy 😃

@NelsonVides NelsonVides merged commit 461a10a into master Dec 15, 2021
@NelsonVides NelsonVides deleted the mu-run-mssql-docker-as-root branch December 15, 2021 17:01
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants