Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventive fix, don't drop the host_type here #3464

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Preventive fix, don't drop the host_type here #3464

merged 1 commit into from
Dec 20, 2021

Conversation

NelsonVides
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #3464 (c443002) into master (1e94f3f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3464   +/-   ##
=======================================
  Coverage   80.82%   80.82%           
=======================================
  Files         415      415           
  Lines       32263    32264    +1     
=======================================
+ Hits        26075    26076    +1     
  Misses       6188     6188           
Impacted Files Coverage Δ
src/ejabberd_c2s.erl 88.97% <100.00%> (+0.23%) ⬆️
..._distrib/mod_global_distrib_outgoing_conns_sup.erl 80.00% <0.00%> (-8.00%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 75.47% <0.00%> (-1.89%) ⬇️
src/rdbms/mongoose_rdbms.erl 61.75% <0.00%> (-1.20%) ⬇️
src/mam/mod_mam_rdbms_arch_async.erl 86.90% <0.00%> (-1.20%) ⬇️
src/pubsub/mod_pubsub_db_mnesia.erl 92.43% <0.00%> (-0.43%) ⬇️
src/mod_muc_log.erl 78.11% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 73.19% <0.00%> (+0.05%) ⬆️
src/pubsub/mod_pubsub_db_rdbms.erl 95.34% <0.00%> (+0.25%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e94f3f...c443002. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 20, 2021

small_tests_24 / small_tests / c443002
Reports root / small


small_tests_23 / small_tests / c443002
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c443002
Reports root/ big
OK: 2724 / Failed: 1 / User-skipped: 186 / Auto-skipped: 0

mam_SUITE:rdbms_async_cache_muc_all:muc06:retract_muc_message
{error,
  {{badmatch,
     {forwarded_message,
       <<"[email protected]">>,
       <<"[email protected]/res1">>,<<"q1">>,
       <<"BKSI6RNB8G01">>,
       <<"[email protected]/unique_alicE_unnamed_1235_nickname">>,
       <<"2021-12-20T11:30:23Z">>,undefined,
       <<"[email protected]/unique_alicE_unnamed_1235_nickname">>,
       <<"groupchat">>,<<"Hi, Bob!">>,
       [{xmlel,<<"origin-id">>,
          [{<<"xmlns">>,<<"urn:xmpp:sid:0">>},
           {<<"id">>,<<"orig-id-1">>}],
          []}],
       [{xmlel,<<"x">>,
          [{<<"xmlns">>,<<"http://jabber.org/protocol/muc#user">>}],
          [{xmlel,<<"item">>,
             [{<<"affiliation">>,<<"owner">>},
            {<<"jid">>,
             <<"[email protected]/res1">>},
            {<<"role">>,<<"moderator">>}],
             []}]}],
       true,undefined}},
   [{mam_SUITE,expect_tombstone_and_retraction_message,2,
      [{file,"/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
       {line,3244}]},
    {mam_SUITE,'-retract_muc_message/1-fun-0-',4,
      [{file,"/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
       {line,2104}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{lin...

Report log


dynamic_domains_mysql_redis_24 / mysql_redis / c443002
Reports root/ big
OK: 2708 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / c443002
Reports root/ big
OK: 2725 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / c443002
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / c443002
Reports root/ big
OK: 2725 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / c443002
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / c443002
Reports root/ big
OK: 1585 / Failed: 0 / User-skipped: 301 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / c443002
Reports root/ big
OK: 3112 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / c443002
Reports root/ big
OK: 1878 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / c443002
Reports root/ big
OK: 3112 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / c443002
Reports root/ big
OK: 3110 / Failed: 2 / User-skipped: 195 / Auto-skipped: 0

service_mongoose_system_metrics_SUITE:system_metrics_are_reported_to_configurable_google_analytics
{error,
  {{assertEqual,
     [{module,service_mongoose_system_metrics_SUITE},
      {line,426},
      {expression,"ActualTrackingIds"},
      {expected,[<<"UA-151671255-1">>,<<"UA-EXTRA-TRACKING-ID">>]},
      {value,[<<"UA-151671255-1">>]}]},
   [{service_mongoose_system_metrics_SUITE,
      events_are_reported_to_tracking_ids,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
       {line,426}]},
    {service_mongoose_system_metrics_SUITE,
      system_metrics_are_reported_to_configurable_google_analytics,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
       {line,228}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

service_domain_db_SUITE:db:db_event_could_appear_with_lower_id
{error,
  {{badmatch,55},
   [{service_domain_db_SUITE,db_event_could_appear_with_lower_id,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,667}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


mysql_redis_24 / mysql_redis / c443002
Reports root/ big
OK: 3123 / Failed: 1 / User-skipped: 200 / Auto-skipped: 0

vcard_SUITE:ro_full:retrieve_own_card
{error,{test_case_failed,"Expected <<\"alice\">> got undefined\n"}}

Report log


riak_mnesia_24 / riak_mnesia / c443002
Reports root/ big
OK: 1723 / Failed: 1 / User-skipped: 314 / Auto-skipped: 0

sm_SUITE:parallel_unacknowledged_message_hook:unacknowledged_message_hook_bounce
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"msg-1">>],
     {xmlel,<<"message">>,
       [{<<"from">>,
         <<"bOb_unacknowledged_message_hook_bounce_1562@localhost/escalus-default-resource">>},
        {<<"to">>,
         <<"alicE_unacknowledged_message_hook_bounce_1564@localhost">>},
        {<<"xml:lang">>,<<"en">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"msg-2">>}]},
        {xmlel,<<"delay">>,
          [{<<"xmlns">>,<<"urn:xmpp:delay">>},
           {<<"stamp">>,<<"2021-12-20T11:41:22.686256Z">>},
           {<<"from">>,<<"localhost">>}],
          [{xmlcdata,<<"SM Storage">>}]}]},
     "<message from='bOb_unacknowledged_message_hook_bounce_1562@localhost/escalus-default-resource' to='alicE_unacknowledged_message_hook_bounce_1564@localhost' xml:lang='en' type='chat'><body>msg-2</body><delay xmlns='urn:xmpp:delay' stamp='2021-12-20T11:41:22.686256Z' from='localhost'>SM Storage</delay></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {sm_SUITE,unacknowledged_message_hook_common,2,
      [{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
       {line,803}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"tes...

Report log


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c443002
Reports root/ big
OK: 2725 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / c443002
Reports root/ big
OK: 3112 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / c443002
Reports root/ big
OK: 1724 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

@arcusfelis arcusfelis merged commit fc56d46 into master Dec 20, 2021
@arcusfelis arcusfelis deleted the c2s_fix branch December 20, 2021 12:49
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants