Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gen_mod:set_module_opt(s) #3468

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Remove gen_mod:set_module_opt(s) #3468

merged 1 commit into from
Dec 21, 2021

Conversation

chrzaszcz
Copy link
Member

These functions shouldn't be used anymore.
Removing them simplifies the upcoming rework of module config.

These functions shouldn't be used anymore.
Removing them simplifies the upcoming rework of module config.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 21, 2021

small_tests_24 / small_tests / 471eb78
Reports root / small


small_tests_23 / small_tests / 471eb78
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 471eb78
Reports root/ big
OK: 2682 / Failed: 0 / User-skipped: 230 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 471eb78
Reports root/ big
OK: 2665 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 471eb78
Reports root/ big
OK: 2682 / Failed: 0 / User-skipped: 230 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 471eb78
Reports root/ big
OK: 2682 / Failed: 0 / User-skipped: 230 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 471eb78
Reports root/ big
OK: 1501 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 471eb78
Reports root/ big
OK: 1542 / Failed: 0 / User-skipped: 345 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 471eb78
Reports root/ big
OK: 1835 / Failed: 0 / User-skipped: 357 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 471eb78
Reports root/ big
OK: 3069 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 471eb78
Reports root/ big
OK: 3069 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 471eb78
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 244 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 471eb78
Reports root/ big
OK: 3069 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 471eb78
Reports root/ big
OK: 1681 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #3468 (471eb78) into master (6e3409c) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3468      +/-   ##
==========================================
+ Coverage   80.83%   80.88%   +0.04%     
==========================================
  Files         415      415              
  Lines       32280    32274       -6     
==========================================
+ Hits        26094    26104      +10     
+ Misses       6186     6170      -16     
Impacted Files Coverage Δ
src/gen_mod.erl 68.21% <ø> (+3.03%) ⬆️
src/mam/mod_mam_meta.erl 93.47% <0.00%> (-2.18%) ⬇️
src/mam/mod_mam.erl 88.52% <0.00%> (-0.82%) ⬇️
src/pubsub/mod_pubsub_db_mnesia.erl 92.43% <0.00%> (-0.43%) ⬇️
src/mod_muc_room.erl 76.97% <0.00%> (-0.12%) ⬇️
src/mod_muc_log.erl 78.11% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 73.31% <0.00%> (+0.11%) ⬆️
src/pubsub/mod_pubsub_db_rdbms.erl 95.34% <0.00%> (+0.25%) ⬆️
src/mod_bosh_socket.erl 78.88% <0.00%> (+0.31%) ⬆️
src/mod_roster_rdbms.erl 96.15% <0.00%> (+0.76%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3409c...471eb78. Read the comment docs.

@chrzaszcz chrzaszcz marked this pull request as ready for review December 21, 2021 16:01
Copy link
Contributor

@Premwoik Premwoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! :D

@Premwoik Premwoik merged commit a6118cf into master Dec 21, 2021
@Premwoik Premwoik deleted the remove-unused-functions branch December 21, 2021 16:57
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants