Stanza api for graphql #3483

arcusfelis · 2021-12-29T10:52:24Z

This PR addresses MIM-1572

Proposed changes include:

API for stanzas
Tests are separate. Code is separate.
We reuse a bit of code from mod_commands.
Made jid scalar (maybe we can make it an object, but I really don't see that much point in it).

codecov · 2021-12-29T11:06:13Z

Codecov Report

Merging #3483 (d21a51c) into feature/graphql (1ec7a69) will increase coverage by 0.06%.
The diff coverage is 91.89%.

@@                 Coverage Diff                 @@
##           feature/graphql    #3483      +/-   ##
===================================================
+ Coverage            80.82%   80.88%   +0.06%     
===================================================
  Files                  427      433       +6     
  Lines                32578    32653      +75     
===================================================
+ Hits                 26330    26412      +82     
+ Misses                6248     6241       -7

Impacted Files	Coverage Δ
src/mongoose_graphql.erl	`91.11% <ø> (ø)`
src/mongoose_graphql/mongoose_graphql_scalar.erl	`72.22% <72.22%> (ø)`
src/mod_commands.erl	`91.97% <90.90%> (-1.12%)`	⬇️
src/mongoose_stanza_api.erl	`91.66% <91.66%> (ø)`
...l/admin/mongoose_graphql_stanza_admin_mutation.erl	`92.00% <92.00%> (ø)`
src/mam/mod_mam_utils.erl	`86.66% <100.00%> (+0.12%)`	⬆️
src/mod_muc_commands.erl	`94.82% <100.00%> (ø)`
src/mongoose_commands.erl	`94.71% <100.00%> (-0.03%)`	⬇️
..._graphql/admin/mongoose_graphql_admin_mutation.erl	`7.14% <100.00%> (+7.14%)`	⬆️
...ose_graphql/admin/mongoose_graphql_admin_query.erl	`40.00% <100.00%> (+6.66%)`	⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab4ddf1...d21a51c. Read the comment docs.

Update graphql_helper with new helpers Put tests into graphql_stanza_SUITE Add new types StanzaAdminMutation and StanzaAdminQuery

Premwoik

Looks good to me :D I have only minor suggestions. I noticed that in this PR only the admin API was implemented, so we need to implement the user API in another PR.

test/mongoose_graphql_SUITE.erl

big_tests/tests/graphql_stanza_SUITE.erl

src/mongoose_graphql/admin/mongoose_graphql_admin_stanza_mutation.erl

chrzaszcz · 2022-01-04T14:29:35Z

Please wait with the merge for my review, I will finish no later than tomorrow morning.

mongoose-im · 2022-01-05T13:55:35Z

small_tests_24 / small_tests / 136e370
Reports root / small

small_tests_23 / small_tests / 136e370
Reports root / small

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 136e370
Reports root/ big
OK: 2745 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 136e370
Reports root/ big
OK: 2745 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 136e370
Reports root/ big
OK: 2728 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 136e370
Reports root/ big
OK: 2745 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 136e370
Reports root/ big
OK: 1514 / Failed: 1 / User-skipped: 397 / Auto-skipped: 0

rest_client_SUITE:messages:msg_is_sent_and_delivered_over_sse

{error,{{badmap,{error,timeout}},
    [{erlang,map_get,[data,{error,timeout}],[]},
     {rest_client_SUITE,msg_is_sent_and_delivered_over_sse,1,
              [{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
               {line,217}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1263}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1195}]}]}}

Report log

ldap_mnesia_24 / ldap_mnesia / 136e370
Reports root/ big
OK: 1513 / Failed: 0 / User-skipped: 394 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / 136e370
Reports root/ big
OK: 1598 / Failed: 0 / User-skipped: 309 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 136e370
Reports root/ big
OK: 3132 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 136e370
Reports root/ big
OK: 3132 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 136e370
Reports root/ big
OK: 1899 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 136e370
Reports root/ big
OK: 3127 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 136e370
Reports root/ big
OK: 3132 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 136e370
Reports root/ big
OK: 1745 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

chrzaszcz

The code looks good, I like how we avoid calling modules from the old API like mod_commands. I have a few minor comments.

big_tests/tests/mam_helper.erl

src/mongoose_graphql/mongoose_graphql_scalar.erl

src/mongoose_graphql/admin/mongoose_graphql_admin_stanza_mutation.erl

src/mongoose_graphql/admin/mongoose_graphql_admin_stanza_query.erl

src/mongoose_graphql/admin/mongoose_graphql_admin_stanza_mutation.erl

Set default limit to 50 in schema

mongoose-im · 2022-01-10T20:41:30Z

small_tests_23 / small_tests / 1fccf9c
Reports root / small

small_tests_24 / small_tests / 1fccf9c
Reports root / small

dynamic_domains_mysql_redis_24 / mysql_redis / 1fccf9c
Reports root/ big
OK: 2732 / Failed: 1 / User-skipped: 203 / Auto-skipped: 0

graphql_stanza_SUITE:admin_stanza_category:get_last_messages_for_unknown_user

{error,{{assertEqual,[{module,graphql_stanza_SUITE},
            {line,214},
            {expression,"ErrMsg"},
            {expected,<<"#{jid => <<\"maybemaybebutnot@localhost\">>,what => non_existing_user}">>},
            {value,<<"#{jid => <<\"[email protected]\">>,what => non_existing_user}">>}]},
    [{graphql_stanza_SUITE,get_last_messages_for_unknown_user,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
                {line,214}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 1fccf9c
Reports root/ big
OK: 2749 / Failed: 1 / User-skipped: 186 / Auto-skipped: 0

graphql_stanza_SUITE:admin_stanza_category:get_last_messages_for_unknown_user

{error,{{assertEqual,[{module,graphql_stanza_SUITE},
            {line,214},
            {expression,"ErrMsg"},
            {expected,<<"#{jid => <<\"maybemaybebutnot@localhost\">>,what => non_existing_user}">>},
            {value,<<"#{jid => <<\"[email protected]\">>,what => non_existing_user}">>}]},
    [{graphql_stanza_SUITE,'-get_last_messages_for_unknown_user/1-fun-1-',
                 1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
                {line,214}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1263}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1195}]}]}}

Report log

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 1fccf9c
Reports root/ big
OK: 2749 / Failed: 1 / User-skipped: 186 / Auto-skipped: 0

graphql_stanza_SUITE:admin_stanza_category:get_last_messages_for_unknown_user

{error,{{assertEqual,[{module,graphql_stanza_SUITE},
            {line,214},
            {expression,"ErrMsg"},
            {expected,<<"#{jid => <<\"maybemaybebutnot@localhost\">>,what => non_existing_user}">>},
            {value,<<"#{jid => <<\"[email protected]\">>,what => non_existing_user}">>}]},
    [{graphql_stanza_SUITE,get_last_messages_for_unknown_user,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
                {line,214}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

ldap_mnesia_24 / ldap_mnesia / 1fccf9c
Reports root/ big
OK: 1513 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 1fccf9c
Reports root/ big
OK: 1520 / Failed: 1 / User-skipped: 399 / Auto-skipped: 0

sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_stop_c2s

{error,{thrown,{timeout,msg}}}

Report log

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1fccf9c
Reports root/ big
OK: 2749 / Failed: 1 / User-skipped: 186 / Auto-skipped: 0

graphql_stanza_SUITE:admin_stanza_category:get_last_messages_for_unknown_user

{error,{{assertEqual,[{module,graphql_stanza_SUITE},
            {line,214},
            {expression,"ErrMsg"},
            {expected,<<"#{jid => <<\"maybemaybebutnot@localhost\">>,what => non_existing_user}">>},
            {value,<<"#{jid => <<\"[email protected]\">>,what => non_existing_user}">>}]},
    [{graphql_stanza_SUITE,get_last_messages_for_unknown_user,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
                {line,214}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

internal_mnesia_24 / internal_mnesia / 1fccf9c
Reports root/ big
OK: 1598 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 1fccf9c
Reports root/ big
OK: 3137 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 1fccf9c
Reports root/ big
OK: 3132 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 1fccf9c
Reports root/ big
OK: 1904 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 1fccf9c
Reports root/ big
OK: 3137 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 1fccf9c
Reports root/ big
OK: 1757 / Failed: 1 / User-skipped: 314 / Auto-skipped: 0

sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_send_message

{error,
  {{assertion_failed,assert_many,true,
     [#Fun<sm_SUITE.22.68776247>,#Fun<sm_SUITE.22.68776247>,
      #Fun<sm_SUITE.22.68776247>],
     [{xmlel,<<"presence">>,
        [{<<"from">>,
        <<"alicE_resume_session_state_send_message_1659@localhost/escalus-default-resource">>},
         {<<"to">>,
        <<"alice_resume_session_state_send_message_1659@localhost/escalus-default-resource">>},
         {<<"xml:lang">>,<<"en">>}],
        []},
      {xmlel,<<"message">>,
        [{<<"from">>,
        <<"bOb_resume_session_state_send_message_1652@localhost/escalus-default-resource">>},
         {<<"to">>,
        <<"alicE_resume_session_state_send_message_1659@localhost">>},
         {<<"xml:lang">>,<<"en">>},
         {<<"type">>,<<"chat">>}],
        [{xmlel,<<"body">>,[],[{xmlcdata,<<"msg-1">>}]},
         {xmlel,<<"delay">>,
           [{<<"xmlns">>,<<"urn:xmpp:delay">>},
          {<<"stamp">>,<<"2022-01-10T20:49:59.155762Z">>},
          {<<"from">>,<<"localhost">>}],
           [{xmlcdata,<<"SM Storage">>}]}]},
      {xmlel,<<"message">>,
        [{<<"from">>,
        <<"bOb_resume_session_state_send_message_1652@localhost/escalus-default-resource">>},
         {<<"to">>,
        <<"alicE_resume_session_state_send_message_1659@localhost">>},
         {<<"xml:lang">>,<<"en">>},
         {<<"type">>,<<"chat">>}],
        [{xmlel,<<"body">>,[],[{xmlcdata,<<"msg-2">>}]},
         {xmlel,<<"delay">>,
           [{<<"xmlns">>,<<"urn:xmpp:delay">>},
          {<<"stamp...

Report log

mongoose-im · 2022-01-11T08:39:03Z

small_tests_24 / small_tests / b483730
Reports root / small

small_tests_23 / small_tests / b483730
Reports root / small

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / b483730
Reports root/ big
OK: 2750 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / b483730
Reports root/ big
OK: 2750 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / b483730
Reports root/ big
OK: 2733 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / b483730
Reports root/ big
OK: 1513 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / b483730
Reports root/ big
OK: 1513 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b483730
Reports root/ big
OK: 2778 / Failed: 1 / User-skipped: 186 / Auto-skipped: 0

sm_SUITE:parallel:messages_are_properly_flushed_during_resumption_p1_fsm_old

{error,
  {{badmatch,
     {error,
       {connection_step_failed,
         {#Fun<sm_SUITE.11.68776247>,
          {client,
            <<"alicE_messages_are_properly_flushed_during_resumption_p1_fsm_old_1933@domain.example.com">>,
            escalus_tcp,<0.32526.1>,undefined,
            [{username,
               <<"alicE_messages_are_properly_flushed_during_resumption_p1_fsm_old_1933">>},
             {server,<<"domain.example.com">>},
             {host,<<"localhost">>},
             {password,<<"matygrysa">>},
             {stream_management,true},
             {stream_id,<<"931769b3b9ded6f9">>}]},
          [{compression,[<<"zlib">>]},
           {starttls,true},
           {stream_management,true},
           {advanced_message_processing,true},
           {client_state_indication,false},
           {sasl_mechanisms,[<<"SCRAM-SHA-256">>,<<"PLAIN">>]},
           {caps,undefined}]},
         {timeout,get_resumed}}}},
   [{sm_SUITE,
      '-messages_are_properly_flushed_during_resumption_p1_fsm_old/1-fun-1-',
      3,
      [{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
       {line,1270}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_se...

Report log

internal_mnesia_24 / internal_mnesia / b483730
Reports root/ big
OK: 1598 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / b483730
Reports root/ big
OK: 1904 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / b483730
Reports root/ big
OK: 3132 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / b483730
Reports root/ big
OK: 3137 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / b483730
Reports root/ big
OK: 3137 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / b483730
Reports root/ big
OK: 3137 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / b483730
Reports root/ big
OK: 1750 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

chrzaszcz

It looks good in general, but I'd like to see the type specs which are missing from the new modules.

chrzaszcz · 2022-01-11T10:06:10Z

src/mongoose_graphql/mongoose_graphql_helper.erl

+       true ->
+           {ok, HostType};
+       false ->
+            {error, #{what => non_existing_user, jid => jid:to_binary(Jid)}}


Suggested change

{error, #{what => non_existing_user, jid => jid:to_binary(Jid)}}

{error, #{what => non_existing_user, jid => jid:to_binary(Jid)}}

src/mongoose_graphql/mongoose_graphql_helper.erl

src/mongoose_graphql/admin/mongoose_graphql_stanza_admin_query.erl

src/mongoose_graphql/admin/mongoose_graphql_stanza_admin_mutation.erl

chrzaszcz · 2022-01-11T10:07:21Z

src/mongoose_stanza_api.erl

+-include("jlib.hrl").
+-include("mongoose_rsm.hrl").
+
+lookup_recent_messages(_, _, _, Limit) when Limit > 500 ->


Please add type specs to this module

chrzaszcz · 2022-01-11T10:09:03Z

src/mongoose_graphql/admin/mongoose_graphql_stanza_admin_query.erl

+    {ok, #{<<"stanzas">> => Maps, <<"limit">> => Limit2}}.
+
+maybe_datetime_to_seconds(null) -> undefined;
+maybe_datetime_to_seconds(Microseconds) -> Microseconds / 1000000. %% Could be float


Why do we convert it to float instead of just passing Microseconds? We divide by 1M just to multiply by 1M later.

to be compatible with mod_commands way of calling actually (it passes before as seconds)

mongoose-im · 2022-01-11T12:16:05Z

small_tests_23 / small_tests / 1f146ab
Reports root / small

small_tests_24 / small_tests / 1f146ab
Reports root / small

dynamic_domains_mysql_redis_24 / mysql_redis / 1f146ab
Reports root/ big
OK: 2733 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1f146ab
Reports root/ big
OK: 2750 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 1f146ab
Reports root/ big
OK: 2750 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 1f146ab
Reports root/ big
OK: 1513 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 1f146ab
Reports root/ big
OK: 1513 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / 1f146ab
Reports root/ big
OK: 1605 / Failed: 1 / User-skipped: 314 / Auto-skipped: 0

sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_send_message

{error,
  {{assertion_failed,assert_many,true,
     [#Fun<sm_SUITE.22.68776247>,#Fun<sm_SUITE.22.68776247>,
      #Fun<sm_SUITE.22.68776247>],
     [{xmlel,<<"presence">>,
        [{<<"from">>,
        <<"alicE_resume_session_state_send_message_1459@localhost/escalus-default-resource">>},
         {<<"to">>,
        <<"alice_resume_session_state_send_message_1459@localhost/escalus-default-resource">>},
         {<<"xml:lang">>,<<"en">>}],
        []},
      {xmlel,<<"message">>,
        [{<<"from">>,
        <<"bOb_resume_session_state_send_message_1451@localhost/escalus-default-resource">>},
         {<<"to">>,
        <<"alicE_resume_session_state_send_message_1459@localhost">>},
         {<<"xml:lang">>,<<"en">>},
         {<<"type">>,<<"chat">>}],
        [{xmlel,<<"body">>,[],[{xmlcdata,<<"msg-1">>}]},
         {xmlel,<<"delay">>,
           [{<<"xmlns">>,<<"urn:xmpp:delay">>},
          {<<"stamp">>,<<"2022-01-11T12:22:25.374611Z">>},
          {<<"from">>,<<"localhost">>}],
           [{xmlcdata,<<"SM Storage">>}]}]},
      {xmlel,<<"message">>,
        [{<<"from">>,
        <<"bOb_resume_session_state_send_message_1451@localhost/escalus-default-resource">>},
         {<<"to">>,
        <<"alicE_resume_session_state_send_message_1459@localhost">>},
         {<<"xml:lang">>,<<"en">>},
         {<<"type">>,<<"chat">>}],
        [{xmlel,<<"body">>,[],[{xmlcdata,<<"msg-2">>}]},
         {xmlel,<<"delay">>,
           [{<<"xmlns">>,<<"urn:xmpp:delay">>},
          {<<"stamp...

Report log

pgsql_mnesia_23 / pgsql_mnesia / 1f146ab
Reports root/ big
OK: 3137 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 1f146ab
Reports root/ big
OK: 1904 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 1f146ab
Reports root/ big
OK: 3137 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 1f146ab
Reports root/ big
OK: 3132 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 1f146ab
Reports root/ big
OK: 3137 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 1f146ab
Reports root/ big
OK: 1750 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

big_tests/tests/graphql_helper.erl

mongoose-im · 2022-01-13T16:04:09Z

small_tests_24 / small_tests / d21a51c
Reports root / small

small_tests_23 / small_tests / d21a51c
Reports root / small

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / d21a51c
Reports root/ big
OK: 2750 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / d21a51c
Reports root/ big
OK: 2733 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d21a51c
Reports root/ big
OK: 2750 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d21a51c
Reports root/ big
OK: 2750 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / d21a51c
Reports root/ big
OK: 1513 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / d21a51c
Reports root/ big
OK: 1542 / Failed: 2 / User-skipped: 402 / Auto-skipped: 0

rest_client_SUITE:messages:msg_is_sent_and_delivered_over_sse

{error,{{badmap,{error,timeout}},
    [{erlang,map_get,
         [data,{error,timeout}],
         [{error_info,#{module => erl_erts_errors}}]},
     {rest_client_SUITE,msg_is_sent_and_delivered_over_sse,1,
              [{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
               {line,217}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

sm_SUITE:parallel:messages_are_properly_flushed_during_resumption_p1_fsm_old

{error,
  {{badmatch,
     {error,
       {connection_step_failed,
         {#Fun<sm_SUITE.11.68776247>,
          {client,
            <<"alicE_messages_are_properly_flushed_during_resumption_p1_fsm_old_1402@localhost">>,
            escalus_tcp,<0.18692.1>,undefined,
            [{username,
               <<"alicE_messages_are_properly_flushed_during_resumption_p1_fsm_old_1402">>},
             {server,<<"localhost">>},
             {password,<<"matygrysa">>},
             {stream_management,true},
             {host,<<"localhost">>},
             {stream_id,<<"0c81371690928f18">>}]},
          [{compression,[<<"zlib">>]},
           {starttls,true},
           {stream_management,true},
           {advanced_message_processing,true},
           {client_state_indication,false},
           {sasl_mechanisms,[<<"PLAIN">>]},
           {caps,undefined}]},
         {timeout,get_resumed}}}},
   [{sm_SUITE,
      '-messages_are_properly_flushed_during_resumption_p1_fsm_old/1-fun-1-',
      3,
      [{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
       {line,1270}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

internal_mnesia_24 / internal_mnesia / d21a51c
Reports root/ big
OK: 1598 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / d21a51c
Reports root/ big
OK: 3137 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d21a51c
Reports root/ big
OK: 1904 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / d21a51c
Reports root/ big
OK: 3132 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / d21a51c
Reports root/ big
OK: 3137 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / d21a51c
Reports root/ big
OK: 3142 / Failed: 1 / User-skipped: 195 / Auto-skipped: 0

muc_SUITE:register:user_submits_registration_form

{error,
  {{assertion_failed,assert,is_iq_result,
     [{xmlel,<<"iq">>,
        [{<<"type">>,<<"set">>},
         {<<"id">>,<<"8976c3941963f7ff8d22dd789086f6ed">>},
         {<<"to">>,<<"muc.localhost">>}],
        [{xmlel,<<"query">>,
           [{<<"xmlns">>,<<"jabber:iq:register">>}],
           [{xmlel,<<"x">>,
            [{<<"xmlns">>,<<"jabber:x:data">>},
             {<<"type">>,<<"submit">>}],
            [{xmlel,<<"field">>,
               [{<<"type">>,<<"hidden">>},
                {<<"var">>,<<"FORM_TYPE">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,<<"jabber:iq:register">>}]}]},
             {xmlel,<<"field">>,
               [{<<"type">>,<<"text-single">>},
                {<<"var">>,<<"nick">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,
                     <<"thirdwitchroom-c3b9fc8e0f">>}]}]}]}]}]}],
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"muc.localhost">>},
        {<<"to">>,
         <<"alicE_user_submits_registration_form_1805@localhost/res1">>},
        {<<"type">>,<<"error">>},
        {<<"xml:lang">>,<<"en">>},
        {<<"id">>,<<"8976c3941963f7ff8d22dd789086f6ed">>}],
       [{xmlel,<<"query">>,
          [{<<"xmlns">>,<<"jabber:iq:register">>}],
          [{xmlel,<<"x">>,
             [{<<"xmlns">>,<<"jabber:x:data">>},
            {<<"type">>,<<"submit">>}],
             [{xmlel,<<"field">>,
              [{<<"type">>,<<"hidden">>},
               {<<"var">>,<<"FORM_TYPE">>}],
            ...

Report log

riak_mnesia_24 / riak_mnesia / d21a51c
Reports root/ big
OK: 1750 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

chrzaszcz

Looks good!

arcusfelis marked this pull request as draft December 29, 2021 10:52

arcusfelis added the WIP 🚧 label Dec 29, 2021

arcusfelis changed the base branch from master to feature/graphql December 29, 2021 10:52

This comment has been minimized.

Sign in to view

arcusfelis force-pushed the graphql/mu-stanza-api branch from 2778c9b to 9113508 Compare January 3, 2022 15:40

This comment has been minimized.

Sign in to view

Add stanza GraphQL queries

6a6a587

Update graphql_helper with new helpers Put tests into graphql_stanza_SUITE Add new types StanzaAdminMutation and StanzaAdminQuery

arcusfelis force-pushed the graphql/mu-stanza-api branch from 9113508 to 6a6a587 Compare January 3, 2022 19:38

arcusfelis added waiting-for-review and removed WIP 🚧 labels Jan 3, 2022

arcusfelis marked this pull request as ready for review January 3, 2022 19:39

arcusfelis changed the title ~~Stanza api for graphql [WIP]~~ Stanza api for graphql Jan 3, 2022

This comment has been minimized.

Sign in to view

Premwoik approved these changes Jan 4, 2022

View reviewed changes

chrzaszcz reviewed Jan 5, 2022

View reviewed changes

arcusfelis added 8 commits January 10, 2022 19:30

Split schema

51c4f34

Return limit from getLastStanzas

03ff66c

Set default limit to 50 in schema

Move lookup_recent_messages into mongoose_stanza_api

1eedf73

Expect nulls in build_message_with_headline

e329ee0

Move parse_from_to/2 and build_message/3 to mongoose_stanza_helper

2daaf75

Add send_message_to_unparsable_jid

8d026eb

Add send_unparsable_stanza_story testcase

b3a5f09

Add send_stanza_from_non_existing_user

b139ae3

arcusfelis force-pushed the graphql/mu-stanza-api branch from 136e370 to 1fccf9c Compare January 10, 2022 20:27

mongoose-im mentioned this pull request Jan 10, 2022

CI build failures summary #3360

Closed

Add get_last_messages_for_unknown_user testcase

b483730

arcusfelis force-pushed the graphql/mu-stanza-api branch from 1fccf9c to b483730 Compare January 11, 2022 08:30

chrzaszcz reviewed Jan 11, 2022

View reviewed changes

Format errors

1f146ab

chrzaszcz reviewed Jan 13, 2022

View reviewed changes

big_tests/tests/graphql_helper.erl Outdated Show resolved Hide resolved

Add specs

d21a51c

arcusfelis force-pushed the graphql/mu-stanza-api branch from 2524bc2 to d21a51c Compare January 13, 2022 15:55

arcusfelis requested a review from chrzaszcz January 13, 2022 15:56

chrzaszcz approved these changes Jan 14, 2022

View reviewed changes

chrzaszcz merged commit c468ee6 into feature/graphql Jan 14, 2022

chrzaszcz deleted the graphql/mu-stanza-api branch January 14, 2022 07:37

chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stanza api for graphql #3483

Stanza api for graphql #3483

arcusfelis commented Dec 29, 2021 •

edited

Loading

This comment has been minimized.

codecov bot commented Dec 29, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Premwoik left a comment

chrzaszcz commented Jan 4, 2022

mongoose-im commented Jan 5, 2022 •

edited

Loading

chrzaszcz left a comment

mongoose-im commented Jan 10, 2022 •

edited

Loading

mongoose-im commented Jan 11, 2022 •

edited

Loading

chrzaszcz left a comment

chrzaszcz Jan 11, 2022

chrzaszcz Jan 11, 2022

chrzaszcz Jan 11, 2022

arcusfelis Jan 12, 2022

mongoose-im commented Jan 11, 2022 •

edited

Loading

mongoose-im commented Jan 13, 2022 •

edited

Loading

chrzaszcz left a comment

	{error, #{what => non_existing_user, jid => jid:to_binary(Jid)}}
	{error, #{what => non_existing_user, jid => jid:to_binary(Jid)}}

Stanza api for graphql #3483

Stanza api for graphql #3483

Conversation

arcusfelis commented Dec 29, 2021 • edited Loading

This comment has been minimized.

codecov bot commented Dec 29, 2021 • edited Loading

Codecov Report

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Premwoik left a comment

Choose a reason for hiding this comment

chrzaszcz commented Jan 4, 2022

mongoose-im commented Jan 5, 2022 • edited Loading

chrzaszcz left a comment

Choose a reason for hiding this comment

mongoose-im commented Jan 10, 2022 • edited Loading

mongoose-im commented Jan 11, 2022 • edited Loading

chrzaszcz left a comment

Choose a reason for hiding this comment

chrzaszcz Jan 11, 2022

Choose a reason for hiding this comment

chrzaszcz Jan 11, 2022

Choose a reason for hiding this comment

chrzaszcz Jan 11, 2022

Choose a reason for hiding this comment

arcusfelis Jan 12, 2022

Choose a reason for hiding this comment

mongoose-im commented Jan 11, 2022 • edited Loading

mongoose-im commented Jan 13, 2022 • edited Loading

chrzaszcz left a comment

Choose a reason for hiding this comment

arcusfelis commented Dec 29, 2021 •

edited

Loading

codecov bot commented Dec 29, 2021 •

edited

Loading

mongoose-im commented Jan 5, 2022 •

edited

Loading

mongoose-im commented Jan 10, 2022 •

edited

Loading

mongoose-im commented Jan 11, 2022 •

edited

Loading

mongoose-im commented Jan 11, 2022 •

edited

Loading

mongoose-im commented Jan 13, 2022 •

edited

Loading