Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration key for cache name #3518

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Fix configuration key for cache name #3518

merged 1 commit into from
Jan 27, 2022

Conversation

NelsonVides
Copy link
Collaborator

The configuration key that says what module to use is called module, not cache_name. This was simply ignoring the cache handlers, logging lots of error messages. This started failing after #3508, but in a sense it's a continuation of that one.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 26, 2022

small_tests_24 / small_tests / d6b3038
Reports root / small


small_tests_23 / small_tests / d6b3038
Reports root / small


internal_mnesia_24 / internal_mnesia / d6b3038
Reports root


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / d6b3038
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / d6b3038
Reports root/ big
OK: 2674 / Failed: 0 / User-skipped: 255 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d6b3038
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d6b3038
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / d6b3038
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / d6b3038
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / d6b3038
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / d6b3038
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d6b3038
Reports root/ big
OK: 1834 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / d6b3038
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / d6b3038
Reports root/ big
OK: 1680 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #3518 (476c3d7) into master (c9b7d21) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3518      +/-   ##
==========================================
- Coverage   81.02%   80.97%   -0.05%     
==========================================
  Files         419      419              
  Lines       32310    32312       +2     
==========================================
- Hits        26178    26165      -13     
- Misses       6132     6147      +15     
Impacted Files Coverage Δ
src/mongoose_user_cache.erl 92.50% <75.00%> (-2.24%) ⬇️
src/metrics/mongoose_metrics.erl 86.62% <0.00%> (-5.82%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/logger/mongoose_log_filter.erl 78.08% <0.00%> (-1.37%) ⬇️
src/mod_muc_room.erl 76.97% <0.00%> (-0.24%) ⬇️
src/pubsub/mod_pubsub.erl 73.19% <0.00%> (-0.12%) ⬇️
src/ejabberd_c2s.erl 88.66% <0.00%> (-0.08%) ⬇️
src/mod_muc_log.erl 78.11% <0.00%> (ø)
src/domain/mongoose_domain_loader.erl 90.17% <0.00%> (+0.89%) ⬆️
src/mam/mod_mam_rdbms_arch_async.erl 97.77% <0.00%> (+1.11%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b7d21...476c3d7. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 26, 2022

small_tests_24 / small_tests / 476c3d7
Reports root / small


small_tests_23 / small_tests / 476c3d7
Reports root / small


internal_mnesia_24 / internal_mnesia / 476c3d7
Reports root


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 476c3d7
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 476c3d7
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 476c3d7
Reports root/ big
OK: 2674 / Failed: 0 / User-skipped: 255 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 476c3d7
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 476c3d7
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 476c3d7
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 476c3d7
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 476c3d7
Reports root/ big
OK: 1834 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 476c3d7
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 476c3d7
Reports root/ big
OK: 3073 / Failed: 0 / User-skipped: 252 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 476c3d7
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 476c3d7
Reports root/ big
OK: 1680 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrzaszcz chrzaszcz merged commit 18eebd6 into master Jan 27, 2022
@chrzaszcz chrzaszcz deleted the cache_name branch January 27, 2022 06:58
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants