-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix configuration key for cache name #3518
Conversation
small_tests_24 / small_tests / d6b3038 small_tests_23 / small_tests / d6b3038 internal_mnesia_24 / internal_mnesia / d6b3038 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / d6b3038 dynamic_domains_mysql_redis_24 / mysql_redis / d6b3038 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d6b3038 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d6b3038 ldap_mnesia_24 / ldap_mnesia / d6b3038 ldap_mnesia_23 / ldap_mnesia / d6b3038 pgsql_mnesia_23 / pgsql_mnesia / d6b3038 pgsql_mnesia_24 / pgsql_mnesia / d6b3038 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d6b3038 mssql_mnesia_24 / odbc_mssql_mnesia / d6b3038 riak_mnesia_24 / riak_mnesia / d6b3038 |
Codecov Report
@@ Coverage Diff @@
## master #3518 +/- ##
==========================================
- Coverage 81.02% 80.97% -0.05%
==========================================
Files 419 419
Lines 32310 32312 +2
==========================================
- Hits 26178 26165 -13
- Misses 6132 6147 +15
Continue to review full report at Codecov.
|
d6b3038
to
476c3d7
Compare
small_tests_24 / small_tests / 476c3d7 small_tests_23 / small_tests / 476c3d7 internal_mnesia_24 / internal_mnesia / 476c3d7 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 476c3d7 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 476c3d7 dynamic_domains_mysql_redis_24 / mysql_redis / 476c3d7 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 476c3d7 ldap_mnesia_24 / ldap_mnesia / 476c3d7 ldap_mnesia_23 / ldap_mnesia / 476c3d7 pgsql_mnesia_23 / pgsql_mnesia / 476c3d7 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 476c3d7 pgsql_mnesia_24 / pgsql_mnesia / 476c3d7 mysql_redis_24 / mysql_redis / 476c3d7 mssql_mnesia_24 / odbc_mssql_mnesia / 476c3d7 riak_mnesia_24 / riak_mnesia / 476c3d7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The configuration key that says what module to use is called module, not cache_name. This was simply ignoring the cache handlers, logging lots of error messages. This started failing after #3508, but in a sense it's a continuation of that one.