Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put mod_version opts in a map with defaults #3552

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

gustawlippa
Copy link
Contributor

No description provided.

@gustawlippa gustawlippa changed the title Pud mod_version opts in a map with defaults Put mod_version opts in a map with defaults Feb 18, 2022
@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 18, 2022

small_tests_24 / small_tests / dcbfc78
Reports root / small


small_tests_23 / small_tests / dcbfc78
Reports root / small


dynamic_domains_mysql_redis_24 / mysql_redis / dcbfc78
Reports root/ big
OK: 2704 / Failed: 0 / User-skipped: 256 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / dcbfc78
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / dcbfc78
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / dcbfc78
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / dcbfc78
Reports root/ big
OK: 1510 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / dcbfc78
Reports root/ big
OK: 1510 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / dcbfc78
Reports root/ big
OK: 1551 / Failed: 0 / User-skipped: 349 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / dcbfc78
Reports root/ big
OK: 1685 / Failed: 0 / User-skipped: 369 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / dcbfc78
Reports root/ big
OK: 3095 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / dcbfc78
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 253 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / dcbfc78
Reports root/ big
OK: 3095 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / dcbfc78
Reports root/ big
OK: 3095 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / dcbfc78
Reports root/ big
OK: 1690 / Failed: 0 / User-skipped: 364 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #3552 (dcbfc78) into master (f75ee4c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3552      +/-   ##
==========================================
- Coverage   79.21%   79.20%   -0.01%     
==========================================
  Files         420      420              
  Lines       32263    32262       -1     
==========================================
- Hits        25557    25554       -3     
- Misses       6706     6708       +2     
Impacted Files Coverage Δ
src/mod_version.erl 93.75% <100.00%> (-0.37%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/mam/mod_mam_rdbms_arch_async.erl 96.62% <0.00%> (-1.13%) ⬇️
src/rdbms/mongoose_rdbms.erl 62.17% <0.00%> (-0.75%) ⬇️
src/mod_muc_room.erl 76.97% <0.00%> (-0.29%) ⬇️
src/pubsub/mod_pubsub.erl 73.31% <0.00%> (+0.17%) ⬆️
src/mod_roster.erl 78.75% <0.00%> (+0.23%) ⬆️
src/mam/mod_mam_elasticsearch_arch.erl 86.84% <0.00%> (+1.75%) ⬆️
src/elasticsearch/mongoose_elasticsearch.erl 84.61% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75ee4c...dcbfc78. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit c431f16 into master Feb 18, 2022
@chrzaszcz chrzaszcz deleted the map-mod_version branch February 18, 2022 12:31
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants