-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract common LDAP options and update mod_shared_roster_ldap config #3558
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## master #3558 +/- ##
==========================================
+ Coverage 81.01% 81.06% +0.04%
==========================================
Files 424 424
Lines 32337 32299 -38
==========================================
- Hits 26199 26184 -15
+ Misses 6138 6115 -23
Continue to review full report at Codecov.
|
109712b
to
c706a4f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
c706a4f
to
d8449dc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
d8449dc
to
b3be00c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
b3be00c
to
717530f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
74663d1
to
eeb92ff
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
9378d85
to
e2c100b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
e2c100b
to
6dec854
Compare
This comment was marked as outdated.
This comment was marked as outdated.
6dec854
to
9c65a76
Compare
This comment was marked as outdated.
This comment was marked as outdated.
9c65a76
to
350454a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
350454a
to
c3085e3
Compare
0c2b3ea
to
72bec62
Compare
small_tests_24 / small_tests / 72bec62 small_tests_23 / small_tests / 72bec62 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 72bec62 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 72bec62 dynamic_domains_mysql_redis_24 / mysql_redis / 72bec62 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 72bec62 internal_mnesia_24 / internal_mnesia / 72bec62 ldap_mnesia_24 / ldap_mnesia / 72bec62 ldap_mnesia_23 / ldap_mnesia / 72bec62 pgsql_mnesia_24 / pgsql_mnesia / 72bec62 mysql_redis_24 / mysql_redis / 72bec62 pgsql_mnesia_23 / pgsql_mnesia / 72bec62 mssql_mnesia_24 / odbc_mssql_mnesia / 72bec62 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 72bec62 riak_mnesia_24 / riak_mnesia / 72bec62 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good in general, I added a few comments.
small_tests_23 / small_tests / 260d49e small_tests_24 / small_tests / 260d49e dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 260d49e dynamic_domains_mysql_redis_24 / mysql_redis / 260d49e dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 260d49e ldap_mnesia_23 / ldap_mnesia / 260d49e ldap_mnesia_24 / ldap_mnesia / 260d49e dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 260d49e internal_mnesia_24 / internal_mnesia / 260d49e pgsql_mnesia_23 / pgsql_mnesia / 260d49e mssql_mnesia_24 / odbc_mssql_mnesia / 260d49e pgsql_mnesia_24 / pgsql_mnesia / 260d49e mysql_redis_24 / mysql_redis / 260d49e elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 260d49e riak_mnesia_24 / riak_mnesia / 260d49e |
77689c4
to
6488a21
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
b7079a5
to
aea4835
Compare
aea4835
to
1868792
Compare
small_tests_24 / small_tests / aea4835 small_tests_23 / small_tests / aea4835 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / aea4835 dynamic_domains_mysql_redis_24 / mysql_redis / aea4835 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / aea4835 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / aea4835 ldap_mnesia_23 / ldap_mnesia / aea4835 ldap_mnesia_24 / ldap_mnesia / aea4835 internal_mnesia_24 / internal_mnesia / aea4835 mysql_redis_24 / mysql_redis / aea4835 pgsql_mnesia_23 / pgsql_mnesia / aea4835 pgsql_mnesia_24 / pgsql_mnesia / aea4835 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / aea4835 mssql_mnesia_24 / odbc_mssql_mnesia / aea4835 riak_mnesia_24 / riak_mnesia / aea4835 |
small_tests_24 / small_tests / 1868792 small_tests_23 / small_tests / 1868792 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1868792 dynamic_domains_mysql_redis_24 / mysql_redis / 1868792 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 1868792 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 1868792 ldap_mnesia_23 / ldap_mnesia / 1868792 ldap_mnesia_24 / ldap_mnesia / 1868792 internal_mnesia_24 / internal_mnesia / 1868792 pgsql_mnesia_23 / pgsql_mnesia / 1868792 pgsql_mnesia_24 / pgsql_mnesia / 1868792 mysql_redis_24 / mysql_redis / 1868792 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 1868792 mssql_mnesia_24 / odbc_mssql_mnesia / 1868792 riak_mnesia_24 / riak_mnesia / 1868792 |
…et_mod_opt/4 This was the last place that was using it. It's better to use the new config with defaults, or maps directly.
Co-authored-by: Paweł Chrząszcz <[email protected]>
1868792
to
c227259
Compare
small_tests_24 / small_tests / c227259 small_tests_23 / small_tests / c227259 dynamic_domains_mysql_redis_24 / mysql_redis / c227259 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c227259 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / c227259 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / c227259 ldap_mnesia_23 / ldap_mnesia / c227259 ldap_mnesia_24 / ldap_mnesia / c227259 internal_mnesia_24 / internal_mnesia / c227259 pgsql_mnesia_24 / pgsql_mnesia / c227259 mysql_redis_24 / mysql_redis / c227259 pgsql_mnesia_23 / pgsql_mnesia / c227259 riak_mnesia_24 / riak_mnesia / c227259 mssql_mnesia_24 / odbc_mssql_mnesia / c227259 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / c227259 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good, LDAP logic is going in the right direction 🙂
mod_shared_roster_ldap
with defaults.ldap_X
option would now beldap.X
.mod_vcard_ldap
stores the state in a persistent_term, instead of recreating it with every request.ldap_helper