Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing config in mod_ping to map #3579

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Changing config in mod_ping to map #3579

merged 1 commit into from
Mar 9, 2022

Conversation

JanuszJakubiec
Copy link
Contributor

No description provided.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 8, 2022 •
edited
Loading

small_tests_24 / small_tests / c02b93d
Reports root / small

small_tests_23 / small_tests / c02b93d
Reports root / small

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / c02b93d
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c02b93d
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / c02b93d
Reports root/ big
OK: 2756 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / c02b93d
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / c02b93d
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / c02b93d
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / c02b93d
Reports root/ big
OK: 1545 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / c02b93d
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / c02b93d
Reports root/ big
OK: 1846 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / c02b93d
Reports root/ big
OK: 3142 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / c02b93d
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / c02b93d
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / c02b93d
Reports root/ big
OK: 1692 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Mar 8, 2022 •
edited
Loading

Codecov Report

Merging #3579 (f5a3620) into master (b52c96d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3579   +/-   ##
=======================================
  Coverage   81.00%   81.01%           
=======================================
  Files         424      424           
  Lines       32294    32292    -2     
=======================================
- Hits        26161    26160    -1     
+ Misses       6133     6132    -1
Impacted Files Coverage Δ
src/mod_ping.erl 95.23% <100.00%> (-0.15%) ⬇️
src/cassandra/mongoose_cassandra.erl 77.77% <0.00%> (-3.71%) ⬇️
src/mod_private.erl 80.00% <0.00%> (-3.34%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 65.72% <0.00%> (-2.82%) ⬇️
src/global_distrib/mod_global_distrib_receiver.erl 80.00% <0.00%> (-1.12%) ⬇️
src/domain/mongoose_domain_loader.erl 89.28% <0.00%> (-0.90%) ⬇️
src/mod_muc_room.erl 76.97% <0.00%> (-0.12%) ⬇️
src/mod_muc_log.erl 78.11% <0.00%> (ø)
src/ejabberd_c2s.erl 88.72% <0.00%> (+0.07%) ⬆️
src/pubsub/mod_pubsub.erl 73.31% <0.00%> (+0.11%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b52c96d...f5a3620. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 8, 2022 •
edited
Loading

small_tests_24 / small_tests / a58d195
Reports root / small

small_tests_23 / small_tests / a58d195
Reports root / small

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / a58d195
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / a58d195
Reports root/ big
OK: 2756 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / a58d195
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a58d195
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / a58d195
Reports root/ big
OK: 1545 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / a58d195
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / a58d195
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / a58d195
Reports root/ big
OK: 3142 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / a58d195
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / a58d195
Reports root/ big
OK: 1846 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / a58d195
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / a58d195
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / a58d195
Reports root/ big
OK: 1692 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 8, 2022 •
edited
Loading

small_tests_24 / small_tests / f5a3620
Reports root / small

small_tests_23 / small_tests / f5a3620
Reports root / small

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / f5a3620
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / f5a3620
Reports root/ big
OK: 2756 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / f5a3620
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / f5a3620
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / f5a3620
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / f5a3620
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / f5a3620
Reports root/ big
OK: 1545 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / f5a3620
Reports root/ big
OK: 1846 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / f5a3620
Reports root/ big
OK: 3142 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / f5a3620
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / f5a3620
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / f5a3620
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / f5a3620
Reports root/ big
OK: 1692 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

gustawlippa
gustawlippa approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@gustawlippa gustawlippa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@gustawlippa gustawlippa merged commit 30368d7 into master Mar 9, 2022
@gustawlippa gustawlippa deleted the module-opts-map-ping branch March 9, 2022 10:11
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustawlippa gustawlippa gustawlippa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JanuszJakubiec @mongoose-im @gustawlippa @Premwoik