Split can_change_ra function in mod_muc [refactoring]

[arcusfelis]

Proposed changes include:

• The old version is impossible to read
• Same logic, just two functions, one for role, one for affiliations

[mongoose-im]

small_tests_24 / small_tests / dd3e1d8
Reports root / small

---

small_tests_23 / small_tests / dd3e1d8
Reports root / small

---

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / dd3e1d8
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

---

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / dd3e1d8
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

---

dynamic_domains_mysql_redis_24 / mysql_redis / dd3e1d8
Reports root/ big
OK: 2756 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0

---

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / dd3e1d8
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

---

ldap_mnesia_23 / ldap_mnesia / dd3e1d8
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

---

ldap_mnesia_24 / ldap_mnesia / dd3e1d8
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

---

internal_mnesia_24 / internal_mnesia / dd3e1d8
Reports root/ big
OK: 1545 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0

---

pgsql_mnesia_23 / pgsql_mnesia / dd3e1d8
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

---

pgsql_mnesia_24 / pgsql_mnesia / dd3e1d8
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

---

mysql_redis_24 / mysql_redis / dd3e1d8
Reports root/ big
OK: 3142 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0

---

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / dd3e1d8
Reports root/ big
OK: 1846 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0

---

mssql_mnesia_24 / odbc_mssql_mnesia / dd3e1d8
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

---

riak_mnesia_24 / riak_mnesia / dd3e1d8
Reports root/ big
OK: 1692 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

[codecov]

Codecov Report

Merging #3581 (dd3e1d8) into master (7aff549) will increase coverage by 1.54%.
The diff coverage is 44.00%.

@@            Coverage Diff             @@
##           master    #3581      +/-   ##
==========================================
+ Coverage   79.26%   80.81%   +1.54%     
==========================================
  Files         424      424              
  Lines       32274    32288      +14     
==========================================
+ Hits        25581    26092     +511     
+ Misses       6693     6196     -497     

Impacted Files	Coverage Δ
src/mod_muc_room.erl	76.70% <44.00%> (-0.39%)	⬇️
src/muc_light/mod_muc_light_db_mnesia.erl	90.52% <0.00%> (-1.06%)	⬇️
src/domain/mongoose_domain_loader.erl	89.28% <0.00%> (-0.90%)	⬇️
src/rdbms/mongoose_rdbms.erl	63.27% <0.00%> (+0.72%)	⬆️
src/mam/mod_mam_utils.erl	85.89% <0.00%> (+0.96%)	⬆️
src/offline/mod_offline.erl	77.17% <0.00%> (+1.08%)	⬆️
src/logger/mongoose_log_filter.erl	79.45% <0.00%> (+1.36%)	⬆️
src/mam/mod_mam_muc_rdbms_arch_async.erl	85.71% <0.00%> (+2.85%)	⬆️
src/mod_private.erl	83.33% <0.00%> (+3.33%)	⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl	75.47% <0.00%> (+3.77%)	⬆️
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aff549...dd3e1d8. Read the comment docs.

[Premwoik]

Looks good to me :) I tried to trace the changes and it seems that nothing is missing.