Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure supervision flags in pools #3593

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Reconfigure supervision flags in pools #3593

merged 1 commit into from
Mar 16, 2022

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented Mar 15, 2022

Children of type supervisor should not have a shutdown flag other than
infinity according to the official documentation.

Children of type `supervisor` should not have a shutdown flag other than
`infinity` according to the official documentation.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 15, 2022

small_tests_24 / small_tests / 3e7c420
Reports root / small


small_tests_23 / small_tests / 3e7c420
Reports root / small


dynamic_domains_mysql_redis_24 / mysql_redis / 3e7c420
Reports root/ big
OK: 2805 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 3e7c420
Reports root/ big
OK: 2822 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 3e7c420
Reports root/ big
OK: 2822 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 3e7c420
Reports root/ big
OK: 2822 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 3e7c420
Reports root/ big
OK: 1505 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 3e7c420
Reports root/ big
OK: 1505 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 3e7c420
Reports root/ big
OK: 1546 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 3e7c420
Reports root/ big
OK: 3196 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 3e7c420
Reports root/ big
OK: 1853 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 3e7c420
Reports root/ big
OK: 3196 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 3e7c420
Reports root/ big
OK: 3191 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 3e7c420
Reports root/ big
OK: 3206 / Failed: 2 / User-skipped: 142 / Auto-skipped: 0

pep_SUITE:pep_tests:delayed_receive_with_sm
{error,{{badmatch,[]},
    [{pep_SUITE,'-delayed_receive_with_sm/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
           {line,295}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pep_SUITE:pep_tests:h_ok_after_notify_test
{error,
  {{assertion_failed,assert_many,false,
     [is_roster_set,is_presence,is_presence],
     [{xmlel,<<"iq">>,
        [{<<"from">>,<<"alicE_h_ok_after_notify_test_1861@localhost">>},
         {<<"to">>,
        <<"alicE_h_ok_after_notify_test_1861@localhost/res1">>},
         {<<"id">>,<<"push4bbd40f8f7d95d80">>},
         {<<"type">>,<<"set">>}],
        [{xmlel,<<"query">>,
           [{<<"xmlns">>,<<"jabber:iq:roster">>}],
           [{xmlel,<<"item">>,
            [{<<"subscription">>,<<"to">>},
             {<<"jid">>,
              <<"kate_h_ok_after_notify_test_1861@localhost">>}],
            []}]}]},
      {xmlel,<<"presence">>,
        [{<<"from">>,<<"kate_h_ok_after_notify_test_1861@localhost">>},
         {<<"to">>,
        <<"alicE_h_ok_after_notify_test_1861@localhost/res1">>},
         {<<"xml:lang">>,<<"en">>},
         {<<"type">>,<<"subscribed">>}],
        []}],
     "   <iq from='alicE_h_ok_after_notify_test_1861@localhost' to='alicE_h_ok_after_notify_test_1861@localhost/res1' id='push4bbd40f8f7d95d80' type='set'><query xmlns='jabber:iq:roster'><item subscription='to' jid='kate_h_ok_after_notify_test_1861@localhost'/></query></iq>   <presence from='kate_h_ok_after_notify_test_1861@localhost' to='alicE_h_ok_after_notify_test_1861@localhost/res1' xml:lang='en' type='subscribed'/>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]}...

Report log


riak_mnesia_24 / riak_mnesia / 3e7c420
Reports root/ big
OK: 1696 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #3593 (3e7c420) into master (3a875ec) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3593      +/-   ##
==========================================
+ Coverage   80.84%   80.87%   +0.02%     
==========================================
  Files         426      426              
  Lines       32379    32379              
==========================================
+ Hits        26177    26186       +9     
+ Misses       6202     6193       -9     
Impacted Files Coverage Δ
src/wpool/mongoose_wpool_mgr.erl 76.05% <ø> (ø)
src/wpool/mongoose_wpool_sup.erl 100.00% <ø> (ø)
...rc/smart_markers/mod_smart_markers_rdbms_async.erl 88.88% <0.00%> (-3.71%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/logger/mongoose_log_filter.erl 78.08% <0.00%> (-1.37%) ⬇️
src/pubsub/mod_pubsub.erl 73.13% <0.00%> (-0.06%) ⬇️
src/mod_muc_room.erl 76.87% <0.00%> (+0.17%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.85% <0.00%> (+0.42%) ⬆️
src/mod_roster.erl 79.47% <0.00%> (+0.71%) ⬆️
src/mod_bosh.erl 95.62% <0.00%> (+2.18%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a875ec...3e7c420. Read the comment docs.

@NelsonVides NelsonVides marked this pull request as ready for review March 15, 2022 17:36
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

@chrzaszcz chrzaszcz merged commit 33d44ca into master Mar 16, 2022
@chrzaszcz chrzaszcz deleted the pool_supervisors branch March 16, 2022 10:14
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants