-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconfigure supervision flags in pools #3593
Conversation
Children of type `supervisor` should not have a shutdown flag other than `infinity` according to the official documentation.
small_tests_24 / small_tests / 3e7c420 small_tests_23 / small_tests / 3e7c420 dynamic_domains_mysql_redis_24 / mysql_redis / 3e7c420 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 3e7c420 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 3e7c420 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 3e7c420 ldap_mnesia_23 / ldap_mnesia / 3e7c420 ldap_mnesia_24 / ldap_mnesia / 3e7c420 internal_mnesia_24 / internal_mnesia / 3e7c420 pgsql_mnesia_23 / pgsql_mnesia / 3e7c420 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 3e7c420 pgsql_mnesia_24 / pgsql_mnesia / 3e7c420 mysql_redis_24 / mysql_redis / 3e7c420 mssql_mnesia_24 / odbc_mssql_mnesia / 3e7c420 pep_SUITE:pep_tests:delayed_receive_with_sm{error,{{badmatch,[]},
[{pep_SUITE,'-delayed_receive_with_sm/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,295}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} pep_SUITE:pep_tests:h_ok_after_notify_test{error,
{{assertion_failed,assert_many,false,
[is_roster_set,is_presence,is_presence],
[{xmlel,<<"iq">>,
[{<<"from">>,<<"alicE_h_ok_after_notify_test_1861@localhost">>},
{<<"to">>,
<<"alicE_h_ok_after_notify_test_1861@localhost/res1">>},
{<<"id">>,<<"push4bbd40f8f7d95d80">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:roster">>}],
[{xmlel,<<"item">>,
[{<<"subscription">>,<<"to">>},
{<<"jid">>,
<<"kate_h_ok_after_notify_test_1861@localhost">>}],
[]}]}]},
{xmlel,<<"presence">>,
[{<<"from">>,<<"kate_h_ok_after_notify_test_1861@localhost">>},
{<<"to">>,
<<"alicE_h_ok_after_notify_test_1861@localhost/res1">>},
{<<"xml:lang">>,<<"en">>},
{<<"type">>,<<"subscribed">>}],
[]}],
" <iq from='alicE_h_ok_after_notify_test_1861@localhost' to='alicE_h_ok_after_notify_test_1861@localhost/res1' id='push4bbd40f8f7d95d80' type='set'><query xmlns='jabber:iq:roster'><item subscription='to' jid='kate_h_ok_after_notify_test_1861@localhost'/></query></iq> <presence from='kate_h_ok_after_notify_test_1861@localhost' to='alicE_h_ok_after_notify_test_1861@localhost/res1' xml:lang='en' type='subscribed'/>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]}... riak_mnesia_24 / riak_mnesia / 3e7c420 |
Codecov Report
@@ Coverage Diff @@
## master #3593 +/- ##
==========================================
+ Coverage 80.84% 80.87% +0.02%
==========================================
Files 426 426
Lines 32379 32379
==========================================
+ Hits 26177 26186 +9
+ Misses 6202 6193 -9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good 👍
Children of type
supervisor
should not have a shutdown flag other thaninfinity
according to the official documentation.