Fix MAM cache name #3594
Fix MAM cache name #3594
Conversation
|
small_tests_24 / small_tests / 11186ec small_tests_23 / small_tests / 11186ec dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 11186ec dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 11186ec dynamic_domains_mysql_redis_24 / mysql_redis / 11186ec dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 11186ec ldap_mnesia_24 / ldap_mnesia / 11186ec ldap_mnesia_23 / ldap_mnesia / 11186ec internal_mnesia_24 / internal_mnesia / 11186ec elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 11186ec pgsql_mnesia_23 / pgsql_mnesia / 11186ec pgsql_mnesia_24 / pgsql_mnesia / 11186ec mysql_redis_24 / mysql_redis / 11186ec mssql_mnesia_24 / odbc_mssql_mnesia / 11186ec riak_mnesia_24 / riak_mnesia / 11186ec |
Codecov Report
@@ Coverage Diff @@
## master #3594 +/- ##
==========================================
+ Coverage 80.84% 80.86% +0.01%
==========================================
Files 426 426
Lines 32379 32379
==========================================
+ Hits 26177 26182 +5
+ Misses 6202 6197 -5
Continue to review full report at Codecov.
|
When mod_mam_cache_user checks its cache, it gives its own module name to mongoose_user_cache so that this one fetches the config to see if it has configured its own cache or is reusing some other module's cache. The problem is that mongoose_user_cache will check for the module key, but it the current implementation, we are hiding it behind a cache key to contain the cache config. So by just moving the config a level up, mongoose_user_cache can find it.
NelsonVides
force-pushed
the
fix_mam_cache
branch
from
11186ec
to
f1b3b14
Compare
|
small_tests_24 / small_tests / f1b3b14 small_tests_23 / small_tests / f1b3b14 dynamic_domains_mysql_redis_24 / mysql_redis / f1b3b14 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / f1b3b14 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / f1b3b14 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / f1b3b14 ldap_mnesia_24 / ldap_mnesia / f1b3b14 ldap_mnesia_23 / ldap_mnesia / f1b3b14 internal_mnesia_24 / internal_mnesia / f1b3b14 pgsql_mnesia_23 / pgsql_mnesia / f1b3b14 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / f1b3b14 pgsql_mnesia_24 / pgsql_mnesia / f1b3b14 mssql_mnesia_24 / odbc_mssql_mnesia / f1b3b14 mysql_redis_24 / mysql_redis / f1b3b14 riak_mnesia_24 / riak_mnesia / f1b3b14 |
When mod_mam_cache_user checks its cache, it gives its own module name
to mongoose_user_cache so that this one fetches the config to see if it
has configured its own cache or is reusing some other module's cache.
The problem is that mongoose_user_cache will check for the module key,
but it the current implementation, we are hiding it behind a cache key
to contain the cache config.
So by just moving the config a level up, mongoose_user_cache can find it.