-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MAM return timestamps in microseconds #3595
Conversation
small_tests_23 / small_tests / f5038f9 small_tests_24 / small_tests / f5038f9 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / f5038f9 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / f5038f9 dynamic_domains_mysql_redis_24 / mysql_redis / f5038f9 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / f5038f9 service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>],
[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>,<<"example4.com">>]}}} ldap_mnesia_24 / ldap_mnesia / f5038f9 internal_mnesia_24 / internal_mnesia / f5038f9 ldap_mnesia_23 / ldap_mnesia / f5038f9 pgsql_mnesia_24 / pgsql_mnesia / f5038f9 pgsql_mnesia_23 / pgsql_mnesia / f5038f9 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / f5038f9 mysql_redis_24 / mysql_redis / f5038f9 mssql_mnesia_24 / odbc_mssql_mnesia / f5038f9 riak_mnesia_24 / riak_mnesia / f5038f9 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / f5038f9 |
Codecov Report
@@ Coverage Diff @@
## master #3595 +/- ##
=======================================
Coverage 80.86% 80.86%
=======================================
Files 426 426
Lines 32379 32378 -1
=======================================
+ Hits 26182 26183 +1
+ Misses 6197 6195 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
No need to convert any of these TS to seconds, XMPP admits microseconds just fine, and client devices this way can ensure they'll display the messages in the right order, otherwise there's a risk of messages arriving within the same 1s window and therefore having the same timestamp.
Also, inbox show timestamps in microseconds, so it is just consistent.