Inbox/small refactor #3596
Inbox/small refactor #3596
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## master #3596 +/- ##
==========================================
- Coverage 80.86% 80.82% -0.04%
==========================================
Files 426 426
Lines 32379 32378 -1
==========================================
- Hits 26182 26169 -13
- Misses 6197 6209 +12
Continue to review full report at Codecov.
|
This can be useful for hooks installed in custom code that want to operate on the xml structure early, at the current stage the xml structure is available only before routing, which is unnecessarily late.
NelsonVides
force-pushed
the
inbox/small_refactor
branch
from
82585d8
to
86285b9
Compare
|
small_tests_24 / small_tests / 86285b9 small_tests_23 / small_tests / 86285b9 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 86285b9 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 86285b9 dynamic_domains_mysql_redis_24 / mysql_redis / 86285b9 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 86285b9 ldap_mnesia_23 / ldap_mnesia / 86285b9 jingle_SUITE:init_per_suite{'EXIT',
{{badrpc,
{'EXIT',
{{badmatch,
{error,
{nkpacket,
{bad_return,
{{nkpacket_app,start,[normal,[]]},
{'EXIT',
{{badmatch,{error,eafnosupport}},
[{nkpacket_stun,check_stun_server,5,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,277}]},
{nkpacket_stun,get_stun_servers,4,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,261}]},
{nkpacket_stun,get_stun_servers,1,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,97}]},
{nkpacket_stun,ext_ip,1,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,75}]},
{nkpacket_app,get_auto_ips,0,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_app.erl"},
{line,113}]},
{nkpacket_app,start,2,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_app.erl"},
{line,58}]},
{application_master,start_it_old,4,
[{file,"application_master.erl"},{line,277}]}]}}}}}}},
[{mod_jingle_sip,start_nksip_service_or_error,1,
[{file,"/home/circleci/project/src/jingle_sip/mod_jingle_sip.erl"},
{line,62}]},
{mod_jingle_sip,start,2,
[{file,"/home/circleci/project/src/jingle_sip/mod_jingle_sip.erl"}...ldap_mnesia_24 / ldap_mnesia / 86285b9 internal_mnesia_24 / internal_mnesia / 86285b9 pgsql_mnesia_24 / pgsql_mnesia / 86285b9 bosh_SUITE:essential:accept_higher_hold_value{error,
{{assertEqual,
[{module,bosh_SUITE},
{line,251},
{expression,"get_bosh_sessions ( )"},
{expected,[]},
{value,
[{bosh_session,<<"69ef267e8b0dab0bf19646e42c0de27d8037c500">>,
<8644.6875.0>}]}]},
[{bosh_SUITE,accept_higher_hold_value,1,
[{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
{line,251}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}pgsql_mnesia_23 / pgsql_mnesia / 86285b9 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 86285b9 mysql_redis_24 / mysql_redis / 86285b9 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4383}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4124}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4120}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}mssql_mnesia_24 / odbc_mssql_mnesia / 86285b9 riak_mnesia_24 / riak_mnesia / 86285b9 ldap_mnesia_23 / ldap_mnesia / 86285b9 pgsql_mnesia_24 / pgsql_mnesia / 86285b9 |
tiny things that are useful to have in the right place in custom code