Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated mod_aws_sns #3607

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Remove deprecated mod_aws_sns #3607

merged 1 commit into from
Mar 24, 2022

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Mar 23, 2022 •
edited
Loading

  • It was deprecated for more than 4 years
  • All functionality is provided by mod_event_pusher now
  • Test suites named differently not to confuse them. I could add big and small suffixes, but I think this would make the names too awkward.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 23, 2022 •
edited
Loading

small_tests_24 / small_tests / 2637e50
Reports root / small

small_tests_23 / small_tests / 2637e50
Reports root / small

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 2637e50
Reports root/ big
OK: 2826 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 2637e50
Reports root/ big
OK: 2826 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 2637e50
Reports root/ big
OK: 2826 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 2637e50
Reports root/ big
OK: 2809 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 2637e50
Reports root/ big
OK: 1503 / Failed: 1 / User-skipped: 399 / Auto-skipped: 0

:error_in_suite 
{error,'mod_aws_sns_SUITE cannot be compiled or loaded'}

Report log

ldap_mnesia_23 / ldap_mnesia / 2637e50
Reports root/ big
OK: 1503 / Failed: 1 / User-skipped: 399 / Auto-skipped: 0

:error_in_suite 
{error,'mod_aws_sns_SUITE cannot be compiled or loaded'}

Report log

internal_mnesia_24 / internal_mnesia / 2637e50
Reports root/ big
OK: 1544 / Failed: 1 / User-skipped: 358 / Auto-skipped: 0

:error_in_suite 
{error,'mod_aws_sns_SUITE cannot be compiled or loaded'}

Report log

pgsql_mnesia_23 / pgsql_mnesia / 2637e50
Reports root/ big
OK: 3196 / Failed: 1 / User-skipped: 142 / Auto-skipped: 0

:error_in_suite 
{error,'mod_aws_sns_SUITE cannot be compiled or loaded'}

Report log

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 2637e50
Reports root/ big
OK: 1851 / Failed: 1 / User-skipped: 366 / Auto-skipped: 0

:error_in_suite 
{error,'mod_aws_sns_SUITE cannot be compiled or loaded'}

Report log

pgsql_mnesia_24 / pgsql_mnesia / 2637e50
Reports root/ big
OK: 3196 / Failed: 1 / User-skipped: 142 / Auto-skipped: 0

:error_in_suite 
{error,'mod_aws_sns_SUITE cannot be compiled or loaded'}

Report log

mysql_redis_24 / mysql_redis / 2637e50
Reports root/ big
OK: 3191 / Failed: 1 / User-skipped: 147 / Auto-skipped: 0

:error_in_suite 
{error,'mod_aws_sns_SUITE cannot be compiled or loaded'}

Report log

mssql_mnesia_24 / odbc_mssql_mnesia / 2637e50
Reports root/ big
OK: 3196 / Failed: 1 / User-skipped: 142 / Auto-skipped: 0

:error_in_suite 
{error,'mod_aws_sns_SUITE cannot be compiled or loaded'}

Report log

riak_mnesia_24 / riak_mnesia / 2637e50
Reports root/ big
OK: 1694 / Failed: 1 / User-skipped: 365 / Auto-skipped: 0

:error_in_suite 
{error,'mod_aws_sns_SUITE cannot be compiled or loaded'}

Report log

@codecov
Copy link

codecov bot commented Mar 23, 2022 •
edited
Loading

Codecov Report

Merging #3607 (65cc2ff) into master (17fbc73) will decrease coverage by 0.01%.
The diff coverage is 81.57%.

@@            Coverage Diff             @@
##           master    #3607      +/-   ##
==========================================
- Coverage   80.90%   80.89%   -0.02%     
==========================================
  Files         426      425       -1     
  Lines       32254    32247       -7     
==========================================
- Hits        26095    26086       -9     
- Misses       6159     6161       +2
Impacted Files Coverage Δ
src/ejabberd_node_id.erl 91.30% <75.00%> (-3.44%) ⬇️
src/ejabberd_local.erl 77.68% <82.35%> (+0.34%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 66.66% <0.00%> (-2.23%) ⬇️
src/ejabberd_s2s_out.erl 60.54% <0.00%> (-1.99%) ⬇️
src/domain/mongoose_domain_loader.erl 89.28% <0.00%> (-0.90%) ⬇️
src/pubsub/mod_pubsub_db_mnesia.erl 92.43% <0.00%> (-0.43%) ⬇️
src/mod_muc_log.erl 63.21% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 73.07% <0.00%> (+0.12%) ⬆️
src/rdbms/mongoose_rdbms.erl 63.63% <0.00%> (+1.09%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bda07f6...65cc2ff. Read the comment docs.

@mongoose-im

This comment was marked as outdated.

Sign in to view
@mongoose-im mongoose-im mentioned this pull request Mar 23, 2022
Closed
@chrzaszcz chrzaszcz marked this pull request as ready for review March 23, 2022 15:11
@chrzaszcz
Remove deprecated mod_aws_sns
65cc2ff 
- It was deprecated for more than 4 years
- All functionality is provided by mod_event_pusher now
@chrzaszcz chrzaszcz closed this Mar 23, 2022
@chrzaszcz chrzaszcz reopened this Mar 23, 2022
@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 23, 2022 •
edited
Loading

small_tests_24 / small_tests / 65cc2ff
Reports root / small

small_tests_23 / small_tests / 65cc2ff
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 65cc2ff
Reports root/ big
OK: 2826 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 65cc2ff
Reports root/ big
OK: 2826 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 65cc2ff
Reports root/ big
OK: 2809 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 65cc2ff
Reports root/ big
OK: 2826 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 65cc2ff
Reports root/ big
OK: 1507 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 65cc2ff
Reports root/ big
OK: 1507 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 65cc2ff
Reports root/ big
OK: 3200 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / 65cc2ff
Reports root/ big
OK: 1548 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 65cc2ff
Reports root/ big
OK: 3195 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 65cc2ff
Reports root/ big
OK: 1855 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 65cc2ff
Reports root/ big
OK: 3212 / Failed: 1 / User-skipped: 142 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive 
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4383}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4124}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4120}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pgsql_mnesia_24 / pgsql_mnesia / 65cc2ff
Reports root/ big
OK: 3200 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 65cc2ff
Reports root/ big
OK: 1698 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

small_tests_24 / small_tests / 65cc2ff
Reports root / small

small_tests_23 / small_tests / 65cc2ff
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 65cc2ff
Reports root/ big
OK: 2826 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 65cc2ff
Reports root/ big
OK: 2809 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 65cc2ff
Reports root/ big
OK: 2826 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 65cc2ff
Reports root/ big
OK: 2826 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 65cc2ff
Reports root/ big
OK: 1507 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 65cc2ff
Reports root/ big
OK: 1507 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / 65cc2ff
Reports root/ big
OK: 1548 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 65cc2ff
Reports root/ big
OK: 1855 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 65cc2ff
Reports root/ big
OK: 3200 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 65cc2ff
Reports root/ big
OK: 3200 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 65cc2ff
Reports root/ big
OK: 3195 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 65cc2ff
Reports root/ big
OK: 3200 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 65cc2ff
Reports root/ big
OK: 1698 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

Premwoik
Premwoik approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@Premwoik Premwoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Premwoik Premwoik merged commit dca553d into master Mar 24, 2022
@Premwoik Premwoik deleted the remove-mod_aws_sns branch March 24, 2022 07:20
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Premwoik Premwoik Premwoik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chrzaszcz @mongoose-im @Premwoik