Remove deprecated mod_revproxy #3617
Conversation
|
small_tests_24 / small_tests / e23b199 small_tests_23 / small_tests / e23b199 dynamic_domains_mysql_redis_24 / mysql_redis / e23b199 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / e23b199 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / e23b199 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / e23b199 ldap_mnesia_23 / ldap_mnesia / e23b199 ldap_mnesia_24 / ldap_mnesia / e23b199 internal_mnesia_24 / internal_mnesia / e23b199 mysql_redis_24 / mysql_redis / e23b199 pgsql_mnesia_23 / pgsql_mnesia / e23b199 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / e23b199 pgsql_mnesia_24 / pgsql_mnesia / e23b199 mssql_mnesia_24 / odbc_mssql_mnesia / e23b199 riak_mnesia_24 / riak_mnesia / e23b199 |
Codecov Report
@@ Coverage Diff @@
## master #3617 +/- ##
==========================================
+ Coverage 80.94% 80.95% +0.01%
==========================================
Files 425 424 -1
Lines 32219 32061 -158
==========================================
- Hits 26079 25955 -124
+ Misses 6140 6106 -34
Continue to review full report at Codecov.
|
chrzaszcz
force-pushed
the
delete-mod-revproxy
branch
2 times, most recently
from
4cd19d2
to
f7d56ec
Compare
|
small_tests_24 / small_tests / 4cd19d2 small_tests_23 / small_tests / 4cd19d2 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 4cd19d2 dynamic_domains_mysql_redis_24 / mysql_redis / 4cd19d2 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 4cd19d2 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 4cd19d2 ldap_mnesia_23 / ldap_mnesia / 4cd19d2 ldap_mnesia_24 / ldap_mnesia / 4cd19d2 internal_mnesia_24 / internal_mnesia / 4cd19d2 pgsql_mnesia_23 / pgsql_mnesia / 4cd19d2 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 4cd19d2 pgsql_mnesia_24 / pgsql_mnesia / 4cd19d2 mysql_redis_24 / mysql_redis / 4cd19d2 mssql_mnesia_24 / odbc_mssql_mnesia / 4cd19d2 riak_mnesia_24 / riak_mnesia / 4cd19d2 |
|
small_tests_24 / small_tests / f7d56ec small_tests_23 / small_tests / f7d56ec dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / f7d56ec dynamic_domains_mysql_redis_24 / mysql_redis / f7d56ec dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / f7d56ec dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / f7d56ec internal_mnesia_24 / internal_mnesia / f7d56ec ldap_mnesia_24 / ldap_mnesia / f7d56ec ldap_mnesia_23 / ldap_mnesia / f7d56ec pgsql_mnesia_23 / pgsql_mnesia / f7d56ec pgsql_mnesia_24 / pgsql_mnesia / f7d56ec mysql_redis_24 / mysql_redis / f7d56ec elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / f7d56ec mssql_mnesia_24 / odbc_mssql_mnesia / f7d56ec riak_mnesia_24 / riak_mnesia / f7d56ec |
|
small_tests_24 / small_tests / 6315f56 small_tests_23 / small_tests / 6315f56 dynamic_domains_mysql_redis_24 / mysql_redis / 6315f56 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6315f56 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 6315f56 ldap_mnesia_23 / ldap_mnesia / 6315f56 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 6315f56 ldap_mnesia_24 / ldap_mnesia / 6315f56 internal_mnesia_24 / internal_mnesia / 6315f56 pgsql_mnesia_24 / pgsql_mnesia / 6315f56 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 6315f56 pgsql_mnesia_23 / pgsql_mnesia / 6315f56 mysql_redis_24 / mysql_redis / 6315f56 mssql_mnesia_24 / odbc_mssql_mnesia / 6315f56 riak_mnesia_24 / riak_mnesia / 6315f56 |
The purpose was to use it as a regular web server (or to attach your custom Cowboy handlers AFAIR). We dropped it when introducing the TOML config because it was super-complicated... and we already removed the listener part of the code. |
|
There's one place with something relating to this I think: Line 24 in 66a1652 |
This module is dead - it was impossible to configure it since version 4.2.0 Also: add missing cleanup revealed by the removed test suite.
chrzaszcz
force-pushed
the
delete-mod-revproxy
branch
from
6315f56
to
ab4b9fc
Compare
Done |
|
small_tests_23 / small_tests / ab4b9fc small_tests_24 / small_tests / ab4b9fc dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ab4b9fc dynamic_domains_mysql_redis_24 / mysql_redis / ab4b9fc dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / ab4b9fc dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / ab4b9fc muc_SUITE:register:user_unregisters_nick{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"62f5c96576f5ddc4f0d0a86352c751c9">>},
{<<"to">>,<<"groupchats.domain.example.com">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitch1room-59efac9b8a">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"groupchats.domain.example.com">>},
{<<"to">>,
<<"[email protected]/res1">>},
{<<"type">>,<<"error">>},
{<<"xml:lang">>,<<"en">>},
{<<"id">>,<<"62f5c96576f5ddc4f0d0a86352c751c9">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">...ldap_mnesia_24 / ldap_mnesia / ab4b9fc internal_mnesia_24 / internal_mnesia / ab4b9fc ldap_mnesia_23 / ldap_mnesia / ab4b9fc pgsql_mnesia_23 / pgsql_mnesia / ab4b9fc elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / ab4b9fc mysql_redis_24 / mysql_redis / ab4b9fc pgsql_mnesia_24 / pgsql_mnesia / ab4b9fc mssql_mnesia_24 / odbc_mssql_mnesia / ab4b9fc riak_mnesia_24 / riak_mnesia / ab4b9fc |
This module is dead - it was impossible to configure it since version 4.2.0