Internal config cleanup #3659
Internal config cleanup #3659
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3659 +/- ##
==========================================
- Coverage 81.15% 81.15% -0.01%
==========================================
Files 433 433
Lines 31914 31911 -3
==========================================
- Hits 25901 25896 -5
- Misses 6013 6015 +2
Continue to review full report at Codecov.
|
This comment was marked as outdated.
This comment was marked as outdated.
Motivation: - Make the code easier to understand. - Discourage renaming, which is counter-intuitive.
chrzaszcz
force-pushed
the
internal-config-cleanup
branch
from
769afae
to
56a16ca
Compare
|
small_tests_24 / small_tests / 56a16ca small_tests_23 / small_tests / 56a16ca dynamic_domains_mysql_redis_24 / mysql_redis / 56a16ca dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 56a16ca dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 56a16ca mod_ping_SUITE:server_ping_kill:server_ping_pong{error,{{badmatch,[{[<<"test_type">>,mod_ping,ping_response],
{expected_diff,5},
{before_story,5},
{after_story,9}}]},
[{escalus_mongooseim,post_story_check_metrics,1,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
{line,74}]},
{escalus_mongooseim,maybe_check_metrics_post_story,1,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
{line,51}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,75}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}ldap_mnesia_23 / ldap_mnesia / 56a16ca dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 56a16ca ldap_mnesia_24 / ldap_mnesia / 56a16ca internal_mnesia_24 / internal_mnesia / 56a16ca pgsql_mnesia_23 / pgsql_mnesia / 56a16ca elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 56a16ca mysql_redis_24 / mysql_redis / 56a16ca pgsql_mnesia_24 / pgsql_mnesia / 56a16ca mssql_mnesia_24 / odbc_mssql_mnesia / 56a16ca muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4383}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4124}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4120}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}riak_mnesia_24 / riak_mnesia / 56a16ca |
Get rid of config key renaming.
The ability to rename a TOML key to a different internal config key (top-level or nested) was added when the parsed TOML tree used to be converted to the legacy configuration format. However, we don't need it anymore now. Having the functionality would encourage renaming keys, but that would bring no real value and would make reasoning about the code and debugging more difficult.