Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric parallel to the one for 1:1 chats #3678

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Conversation

NelsonVides
Copy link
Collaborator

This same metric exists for 1:1 chats, but not for groupchats, and it is quite useful for devops.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 9, 2022

small_tests_24 / small_tests / 1fe9050
Reports root / small


small_tests_25 / small_tests / 1fe9050
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1fe9050
Reports root/ big
OK: 2909 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 1fe9050
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 1fe9050
Reports root/ big
OK: 2892 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1fe9050
Reports root/ big
OK: 2909 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 1fe9050
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 1fe9050
Reports root/ big
OK: 2909 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 1fe9050
Reports root/ big
OK: 1593 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 1fe9050
Reports root/ big
OK: 3283 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 1fe9050
Reports root/ big
OK: 3283 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 1fe9050
Reports root/ big
OK: 3289 / Failed: 1 / User-skipped: 102 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_1879@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_1879@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"1PeRuYb8FH10Kf8c2SR8pQ==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 1fe9050
Reports root/ big
OK: 1900 / Failed: 0 / User-skipped: 324 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 1fe9050
Reports root/ big
OK: 1743 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 1fe9050
Reports root/ big
OK: 3283 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #3678 (1fe9050) into master (7b2787b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3678      +/-   ##
==========================================
+ Coverage   81.12%   81.14%   +0.01%     
==========================================
  Files         433      433              
  Lines       31883    31888       +5     
==========================================
+ Hits        25866    25876      +10     
+ Misses       6017     6012       -5     
Impacted Files Coverage Δ
src/mam/mod_mam_muc.erl 75.23% <100.00%> (+0.59%) ⬆️
src/pubsub/nodetree_tree.erl 87.87% <0.00%> (-3.04%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 66.66% <0.00%> (-2.23%) ⬇️
src/pubsub/node_pep.erl 77.77% <0.00%> (-1.86%) ⬇️
src/pubsub/node_flat.erl 74.30% <0.00%> (-0.40%) ⬇️
src/pubsub/mod_pubsub_db_rdbms.erl 95.34% <0.00%> (-0.26%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/mod_muc_room.erl 76.85% <0.00%> (+0.34%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 77.58% <0.00%> (+0.57%) ⬆️
src/mam/mod_mam_muc_rdbms_arch_async.erl 85.71% <0.00%> (+2.85%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2787b...1fe9050. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit 7aabb41 into master Jun 10, 2022
@chrzaszcz chrzaszcz deleted the mam_muc_lookup_metric branch June 10, 2022 08:57
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants