Enable dialyzer for both OTP 24 and OTP 25 #3680
Conversation
chrzaszcz
force-pushed
the
dialyzer-in-otp24
branch
from
c00fe93
to
a3e400b
Compare
Codecov Report
@@ Coverage Diff @@
## otp-25.0.1 #3680 +/- ##
=============================================
Coverage ? 81.12%
=============================================
Files ? 433
Lines ? 31888
Branches ? 0
=============================================
Hits ? 25869
Misses ? 6019
Partials ? 0 Continue to review full report at Codecov.
|
|
small_tests_24 / small_tests / a3e400b small_tests_25 / small_tests / a3e400b dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a3e400b dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / a3e400b ldap_mnesia_24 / ldap_mnesia / a3e400b dynamic_domains_mysql_redis_25 / mysql_redis / a3e400b dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / a3e400b pgsql_mnesia_24 / pgsql_mnesia / a3e400b ldap_mnesia_25 / ldap_mnesia / a3e400b internal_mnesia_25 / internal_mnesia / a3e400b pgsql_mnesia_25 / pgsql_mnesia / a3e400b elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / a3e400b mysql_redis_25 / mysql_redis / a3e400b pep_SUITE:pep_tests:authorize_access_model{error,{{badmatch,false},
[{pubsub_tools,check_notification,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,509}]},
{pubsub_tools,receive_notification,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,505}]},
{pubsub_tools,receive_item_notification,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,303}]},
{pep_SUITE,'-authorize_access_model/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,356}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_1909@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_1909@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"IM5hZ+LS++lxZCHbWAdyQw==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_1921@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_1921@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"k+ApYPeHUeXwYyyES0OI9A==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}riak_mnesia_24 / riak_mnesia / a3e400b mssql_mnesia_25 / odbc_mssql_mnesia / a3e400b |
|
small_tests_24 / small_tests / 46efde3 small_tests_25 / small_tests / 46efde3 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 46efde3 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 46efde3 dynamic_domains_mysql_redis_25 / mysql_redis / 46efde3 ldap_mnesia_24 / ldap_mnesia / 46efde3 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 46efde3 ldap_mnesia_25 / ldap_mnesia / 46efde3 internal_mnesia_25 / internal_mnesia / 46efde3 pgsql_mnesia_24 / pgsql_mnesia / 46efde3 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 46efde3 mysql_redis_25 / mysql_redis / 46efde3 pgsql_mnesia_25 / pgsql_mnesia / 46efde3 riak_mnesia_24 / riak_mnesia / 46efde3 mssql_mnesia_25 / odbc_mssql_mnesia / 46efde3 |
chrzaszcz
force-pushed
the
dialyzer-in-otp24
branch
2 times, most recently
from
798672d
to
46efde3
Compare
|
small_tests_24 / small_tests / 798672d small_tests_25 / small_tests / 798672d dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 798672d dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 798672d dynamic_domains_mysql_redis_25 / mysql_redis / 798672d service_mongoose_system_metrics_SUITE:module_opts:rdbms_module_opts_are_reported{error,
{{assertEqual,
[{module,service_mongoose_system_metrics_SUITE},
{line,372},
{expression,"is_module_opt_reported ( Module , Key , Value )"},
{expected,true},
{value,false}]},
[{service_mongoose_system_metrics_SUITE,check_module_opt,3,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,372}]},
{service_mongoose_system_metrics_SUITE,rdbms_module_opts_are_reported,
1,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,238}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}ldap_mnesia_24 / ldap_mnesia / 798672d ldap_mnesia_25 / ldap_mnesia / 798672d dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 798672d internal_mnesia_25 / internal_mnesia / 798672d elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 798672d pgsql_mnesia_24 / pgsql_mnesia / 798672d pgsql_mnesia_25 / pgsql_mnesia / 798672d riak_mnesia_24 / riak_mnesia / 798672d mysql_redis_25 / mysql_redis / 798672d mssql_mnesia_25 / odbc_mssql_mnesia / 798672d |
gen_server:request_id is not exported in OTP 24, but let's keep the changes limited for now.
chrzaszcz
force-pushed
the
dialyzer-in-otp24
branch
from
46efde3
to
16f7632
Compare
|
small_tests_24 / small_tests / 16f7632 small_tests_25 / small_tests / 16f7632 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 16f7632 ldap_mnesia_24 / ldap_mnesia / 16f7632 dynamic_domains_mysql_redis_25 / mysql_redis / 16f7632 pgsql_mnesia_24 / pgsql_mnesia / 16f7632 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 16f7632 ldap_mnesia_25 / ldap_mnesia / 16f7632 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 16f7632 internal_mnesia_25 / internal_mnesia / 16f7632 riak_mnesia_24 / riak_mnesia / 16f7632 pgsql_mnesia_25 / pgsql_mnesia / 16f7632 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 16f7632 mysql_redis_25 / mysql_redis / 16f7632 mssql_mnesia_25 / odbc_mssql_mnesia / 16f7632 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_1936@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_1936@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"YFaZjozKrbZlSy2UrSoAwg==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} |
There are some dialyzer errors caught only on OTP 24, and not on OTP 25, because e.g. some types have changed. We support both, so let's run Dialyzer checks for both.
One type spec fixed to make it pass on OTP 24.