Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL - Implement inbox API #3694

Merged
merged 6 commits into from
Jun 30, 2022
Merged

GraphQL - Implement inbox API #3694

merged 6 commits into from
Jun 30, 2022

Conversation

Premwoik
Copy link
Contributor

@Premwoik Premwoik commented Jun 24, 2022 •
edited
Loading

This PR addresses MIM-1669 and implements the inbox category in GraphQL. The commands allow clearing the bin for the user, domain, or globally. I added a possibility to clear bin per domain because it fits perfectly for domain admin.

I didn't check if the inbox module is loaded because we are thinking about doing it outside the API modules.

@Premwoik Premwoik changed the base branch from master to feature/graphql June 24, 2022 13:42
@mongoose-im

This comment was marked as outdated.

Sign in to view
@codecov
Copy link

codecov bot commented Jun 24, 2022 •
edited
Loading

Codecov Report

Merging #3694 (cb6ae8f) into master (d0e2e34) will decrease coverage by 0.02%.
The diff coverage is 94.23%.

@@            Coverage Diff             @@
##           master    #3694      +/-   ##
==========================================
- Coverage   82.14%   82.12%   -0.03%     
==========================================
  Files         510      513       +3     
  Lines       33596    33638      +42     
==========================================
+ Hits        27599    27624      +25     
- Misses       5997     6014      +17
Impacted Files Coverage Δ
src/graphql/mongoose_graphql.erl 91.11% <ø> (ø)
src/graphql/mongoose_graphql_scalar.erl 68.75% <50.00%> (-2.68%) ⬇️
src/inbox/mod_inbox_commands.erl 90.90% <85.71%> (-9.10%) ⬇️
.../graphql/admin/mongoose_graphql_admin_mutation.erl 100.00% <100.00%> (ø)
...ql/admin/mongoose_graphql_inbox_admin_mutation.erl 100.00% <100.00%> (ø)
...phql/user/mongoose_graphql_inbox_user_mutation.erl 100.00% <100.00%> (ø)
...rc/graphql/user/mongoose_graphql_user_mutation.erl 100.00% <100.00%> (ø)
src/inbox/mod_inbox_api.erl 100.00% <100.00%> (ø)
src/inbox/mod_inbox_backend.erl 100.00% <100.00%> (ø)
src/inbox/mod_inbox_rdbms.erl 92.22% <100.00%> (+0.13%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e2e34...cb6ae8f. Read the comment docs.

@mongoose-im mongoose-im mentioned this pull request Jun 24, 2022
Closed
Base automatically changed from feature/graphql to master June 27, 2022 10:54
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 28, 2022 •
edited
Loading

small_tests_24 / small_tests / e218283
Reports root / small

small_tests_25 / small_tests / e218283
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / e218283
Reports root/ big
OK: 3120 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / e218283
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 459 / Auto-skipped: 7

graphql_inbox_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {badarg,
         [{ets,insert_new,
            [prepared_statements,
             {muc_light_config_delete_all,<<"muc_light_config">>,
               [],<<"DELETE FROM muc_light_config">>}],
            [{error_info,
               #{cause => id,module => erl_stdlib_errors}}]},
          {mongoose_rdbms,prepare,4,
            [{file,
               "/home/circleci/project/src/rdbms/mongoose_rdbms.erl"},
             {line,212}]},
          {mod_muc_light_db_rdbms,prepare_cleaning_queries,0,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,93}]},
          {mod_muc_light_db_rdbms,prepare_queries,0,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,84}]},
          {mod_muc_light_db_rdbms,start,2,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,74}]},
          {mod_muc_light,start,2,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light.erl"},
             {line,173}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]}]}}},
   [{distributed_helper,...

Report log

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / e218283
Reports root/ big
OK: 3120 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / e218283
Reports root/ big
OK: 3103 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / e218283
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 459 / Auto-skipped: 7

graphql_inbox_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {badarg,
         [{ets,insert_new,
            [prepared_statements,
             {muc_light_config_delete_all,<<"muc_light_config">>,
               [],<<"DELETE FROM muc_light_config">>}],
            [{error_info,
               #{cause => id,module => erl_stdlib_errors}}]},
          {mongoose_rdbms,prepare,4,
            [{file,
               "/home/circleci/project/src/rdbms/mongoose_rdbms.erl"},
             {line,212}]},
          {mod_muc_light_db_rdbms,prepare_cleaning_queries,0,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,93}]},
          {mod_muc_light_db_rdbms,prepare_queries,0,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,84}]},
          {mod_muc_light_db_rdbms,start,2,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,74}]},
          {mod_muc_light,start,2,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light.erl"},
             {line,173}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]}]}}},
   [{distributed_helper,...

Report log

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / e218283
Reports root/ big
OK: 3120 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / e218283
Reports root/ big
OK: 1844 / Failed: 0 / User-skipped: 353 / Auto-skipped: 7

graphql_inbox_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {badarg,
         [{ets,insert_new,
            [prepared_statements,
             {muc_light_config_delete_all,<<"muc_light_config">>,
               [],<<"DELETE FROM muc_light_config">>}],
            [{error_info,
               #{cause => id,module => erl_stdlib_errors}}]},
          {mongoose_rdbms,prepare,4,
            [{file,
               "/home/circleci/project/src/rdbms/mongoose_rdbms.erl"},
             {line,212}]},
          {mod_muc_light_db_rdbms,prepare_cleaning_queries,0,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,93}]},
          {mod_muc_light_db_rdbms,prepare_queries,0,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,84}]},
          {mod_muc_light_db_rdbms,start,2,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,74}]},
          {mod_muc_light,start,2,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light.erl"},
             {line,173}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]}]}}},
   [{distributed_helper,...

Report log

pgsql_mnesia_24 / pgsql_mnesia / e218283
Reports root/ big
OK: 3494 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / e218283
Reports root/ big
OK: 2134 / Failed: 0 / User-skipped: 354 / Auto-skipped: 7

graphql_inbox_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {badarg,
         [{ets,insert_new,
            [prepared_statements,
             {muc_light_config_delete_all,<<"muc_light_config">>,
               [],<<"DELETE FROM muc_light_config">>}],
            [{error_info,
               #{cause => id,module => erl_stdlib_errors}}]},
          {mongoose_rdbms,prepare,4,
            [{file,
               "/home/circleci/project/src/rdbms/mongoose_rdbms.erl"},
             {line,212}]},
          {mod_muc_light_db_rdbms,prepare_cleaning_queries,0,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,93}]},
          {mod_muc_light_db_rdbms,prepare_queries,0,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,84}]},
          {mod_muc_light_db_rdbms,start,2,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,74}]},
          {mod_muc_light,start,2,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light.erl"},
             {line,173}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]}]}}},
   [{distributed_helper,...

Report log

pgsql_mnesia_25 / pgsql_mnesia / e218283
Reports root/ big
OK: 3494 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / e218283
Reports root/ big
OK: 3489 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / e218283
Reports root/ big
OK: 1993 / Failed: 0 / User-skipped: 349 / Auto-skipped: 7

graphql_inbox_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {badarg,
         [{ets,insert_new,
            [prepared_statements,
             {muc_light_config_delete_all,<<"muc_light_config">>,
               [],<<"DELETE FROM muc_light_config">>}],
            [{error_info,
               #{cause => id,module => erl_stdlib_errors}}]},
          {mongoose_rdbms,prepare,4,
            [{file,
               "/home/circleci/project/src/rdbms/mongoose_rdbms.erl"},
             {line,212}]},
          {mod_muc_light_db_rdbms,prepare_cleaning_queries,0,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,93}]},
          {mod_muc_light_db_rdbms,prepare_queries,0,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,84}]},
          {mod_muc_light_db_rdbms,start,2,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light_db_rdbms.erl"},
             {line,74}]},
          {mod_muc_light,start,2,
            [{file,
               "/home/circleci/project/src/muc_light/mod_muc_light.erl"},
             {line,173}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]}]}}},
   [{distributed_helper,...

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / e218283
Reports root/ big
OK: 3505 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2132@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2132@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"3AU8N5wmFvEX+lqrFWFLpA==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 28, 2022 •
edited
Loading

small_tests_24 / small_tests / de87049
Reports root / small

small_tests_25 / small_tests / de87049
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / de87049
Reports root/ big
OK: 3120 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / de87049
Reports root/ big
OK: 3120 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / de87049
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 460 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / de87049
Reports root/ big
OK: 3103 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / de87049
Reports root/ big
OK: 3120 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / de87049
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 460 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / de87049
Reports root/ big
OK: 3494 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / de87049
Reports root/ big
OK: 1844 / Failed: 0 / User-skipped: 354 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / de87049
Reports root/ big
OK: 2134 / Failed: 0 / User-skipped: 355 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / de87049
Reports root/ big
OK: 3494 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / de87049
Reports root/ big
OK: 3489 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / de87049
Reports root/ big
OK: 1993 / Failed: 0 / User-skipped: 350 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / de87049
Reports root/ big
OK: 3494 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@Premwoik Premwoik marked this pull request as ready for review June 29, 2022 08:00
chrzaszcz
chrzaszcz reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, I added a few comments.

big_tests/tests/graphql_inbox_SUITE.erl Outdated Show resolved Hide resolved
big_tests/tests/graphql_inbox_SUITE.erl Outdated Show resolved Hide resolved
priv/graphql/schemas/admin/inbox.gql Outdated Show resolved Hide resolved
priv/graphql/schemas/admin/inbox.gql Outdated Show resolved Hide resolved
src/inbox/mod_inbox_api.erl Outdated Show resolved Hide resolved
@Premwoik
Apply review - Add PosInt scalar type and use it in inbox schemas
07f7dd3 
Now the user needs to give a positive integer value to remove older than `n` days or null to flush all.
@mongoose-im

This comment was marked as outdated.

Sign in to view
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 30, 2022 •
edited
Loading

small_tests_24 / small_tests / cb6ae8f
Reports root / small

small_tests_25 / small_tests / cb6ae8f
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / cb6ae8f
Reports root/ big
OK: 3121 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / cb6ae8f
Reports root/ big
OK: 3121 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / cb6ae8f
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 460 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / cb6ae8f
Reports root/ big
OK: 3104 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / cb6ae8f
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 460 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / cb6ae8f
Reports root/ big
OK: 3495 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / cb6ae8f
Reports root/ big
OK: 1844 / Failed: 0 / User-skipped: 354 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / cb6ae8f
Reports root/ big
OK: 2134 / Failed: 0 / User-skipped: 355 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / cb6ae8f
Reports root/ big
OK: 3495 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / cb6ae8f
Reports root/ big
OK: 3501 / Failed: 1 / User-skipped: 102 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2096@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2096@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"EP9lejYWqQKJ02Qj1OI5wg==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / cb6ae8f
Reports root/ big
OK: 1993 / Failed: 0 / User-skipped: 350 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / cb6ae8f
Reports root/ big
OK: 3530 / Failed: 3 / User-skipped: 97 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive 
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4383}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4124}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4120}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive 
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4383}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4124}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4120}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2225@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2225@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"W6T+fZ6QZLRbxbWhO5zxzw==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / cb6ae8f
Reports root/ big
OK: 3495 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

chrzaszcz
chrzaszcz approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit bbdc781 into master Jun 30, 2022
@chrzaszcz chrzaszcz deleted the graphql/inbox-api branch June 30, 2022 09:15
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Premwoik @mongoose-im @chrzaszcz