Test GraphQL CLI for all categories #3710

chrzaszcz · 2022-07-15T07:52:46Z

Finish testing GraphQL with CLI in a unified way, making use of generated queries.

Categories included in this PR:

Also: fix a race condition in offline_SUITE, that for some reason started presenting itself in this PR.

codecov · 2022-07-15T08:01:30Z

Codecov Report

Merging #3710 (c4ac2e2) into feature/graphql-cli (a169204) will increase coverage by 0.04%.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##           feature/graphql-cli    #3710      +/-   ##
=======================================================
+ Coverage                82.15%   82.20%   +0.04%     
=======================================================
  Files                      514      514              
  Lines                    33754    33754              
=======================================================
+ Hits                     27732    27748      +16     
+ Misses                    6022     6006      -16

Impacted Files	Coverage Δ
src/mam/mod_mam_muc_rdbms_arch_async.erl	`82.85% <0.00%> (-2.86%)`	⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl	`66.66% <0.00%> (-2.23%)`	⬇️
src/mod_muc_log.erl	`62.82% <0.00%> (ø)`
src/pubsub/mod_pubsub.erl	`73.42% <0.00%> (+0.06%)`	⬆️
src/mam/mod_mam_pm.erl	`89.51% <0.00%> (+0.40%)`	⬆️
src/pubsub/mod_pubsub_db_mnesia.erl	`92.82% <0.00%> (+0.42%)`	⬆️
src/rdbms/mongoose_rdbms.erl	`66.31% <0.00%> (+1.05%)`	⬆️
src/inbox/mod_inbox_rdbms_async.erl	`73.52% <0.00%> (+1.47%)`	⬆️
src/mam/mod_mam_elasticsearch_arch.erl	`88.39% <0.00%> (+1.78%)`	⬆️
src/pubsub/node_pep.erl	`81.48% <0.00%> (+1.85%)`	⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a169204...c4ac2e2. Read the comment docs.

In this case CLI returns 1 as the exit status.

Also fix the test for old messages - it was actually working, because the previous test did not clean up the messages, and the new messages were not old enough. Now the cases are correct and more complete.

mongoose-im · 2022-07-19T13:20:23Z

small_tests_24 / small_tests / c4ac2e2
Reports root / small

small_tests_25 / small_tests / c4ac2e2
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c4ac2e2
Reports root/ big
OK: 3313 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / c4ac2e2
Reports root/ big
OK: 1883 / Failed: 0 / User-skipped: 500 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / c4ac2e2
Reports root/ big
OK: 3216 / Failed: 0 / User-skipped: 104 / Auto-skipped: 81

mam_SUITE:rdbms_async_cache_mam_all:init_per_group

{'EXIT',
 {{badrpc,
   {'EXIT',
  {{start_child_failed,
    {error,
     {{shutdown,
     {failed_to_start_child,'pm_mam_async_pool_test type',
      {shutdown,
       {failed_to_start_child,
      'wpool_pool-pm_mam_async_pool_test type-process-sup',
      {shutdown,
       {failed_to_start_child,
        'wpool_pool-pm_mam_async_pool_test type-4',
        {already_started,<9139.5192.1>}}}}}}},
    {child,undefined,'pm_mam_sup_async_pool_test type',
     {mongoose_async_pools,start_link,
      [<<"test type">>,pm_mam,
       #{batch_name => insert_mam_messages30,batch_size => 30,
       enabled => true,
       flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
       flush_extra =>
        #{batch_name => insert_mam_messages30,batch_size => 30,
        enabled => true,flush_interval => 1,pool_size => 16},
       flush_interval => 1,pool_size => 16,pool_type => batch}]},
     transient,false,infinity,supervisor,
     [mongoose_async_pools]}}},
    #{id => 'pm_mam_sup_async_pool_test type',restart => transient,
    start =>
     {mongoose_async_pools,start_link,
      [<<"test type">>,pm_mam,
       #{batch_name => insert_mam_messages30,batch_size => 30,
       enabled => true,
       flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
       flush_extra =>
        #{batch_name => insert_mam_messages30,batch_size => 30,
        enabled => true,flush_interval => 1,pool_size => 16},
       flush_interval => 1,pool_size => 16,pool_type => batch}]},
    type => supervisor...

Report log

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c4ac2e2
Reports root/ big
OK: 3313 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / c4ac2e2
Reports root/ big
OK: 1883 / Failed: 0 / User-skipped: 500 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c4ac2e2
Reports root/ big
OK: 3313 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / c4ac2e2
Reports root/ big
OK: 3687 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / c4ac2e2
Reports root/ big
OK: 2004 / Failed: 0 / User-skipped: 379 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c4ac2e2
Reports root/ big
OK: 2300 / Failed: 0 / User-skipped: 374 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / c4ac2e2
Reports root/ big
OK: 3682 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / c4ac2e2
Reports root/ big
OK: 2161 / Failed: 0 / User-skipped: 367 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / c4ac2e2
Reports root/ big
OK: 3296 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

JanuszJakubiec

looks good

Premwoik

All good 👌🏻 500 lines less of doc definitions

Premwoik · 2022-07-21T21:47:09Z

big_tests/tests/graphql_domain_SUITE.erl

-        true -> escalus:init_per_suite(init_admin_handler(Config));
-        false -> {skip, require_rdbms}
+        true ->
+            Config1 = ejabberd_node_utils:init(mim(), Config),


What is this doing? 😀

It sets up the helpers for calling mongooseimctl

This comment was marked as outdated.

Sign in to view

Base automatically changed from graphql-user-commands to feature/graphql-cli July 15, 2022 08:48

This comment was marked as outdated.

Sign in to view

mongoose-im mentioned this pull request Jul 15, 2022

CI build failures summary - part 2 #3685

Closed

This comment was marked as outdated.

Sign in to view

chrzaszcz force-pushed the graphql-cli-test branch from e2d3a95 to a3420a7 Compare July 18, 2022 07:54

This comment was marked as outdated.

Sign in to view

chrzaszcz force-pushed the graphql-cli-test branch from a3420a7 to e4d2fbc Compare July 18, 2022 11:54

This comment was marked as outdated.

Sign in to view

chrzaszcz force-pushed the graphql-cli-test branch from 81b70f1 to 86ce428 Compare July 19, 2022 07:33

This comment was marked as outdated.

Sign in to view

chrzaszcz added 3 commits July 19, 2022 12:51

Add a utility for getting result values if there was an error

a197694

In this case CLI returns 1 as the exit status.

Add input coercion error helper

f1da16c

Test GraphQL CLI for domains

c6b8642

chrzaszcz force-pushed the graphql-cli-test branch from 86ce428 to 72d8994 Compare July 19, 2022 10:51

This comment was marked as outdated.

Sign in to view

chrzaszcz added 4 commits July 19, 2022 14:24

Test GraphQL CLI for http_upload

d29a9bd

Test GraphQL CLI for inbox

0d8e4b2

Test GraphQL CLI for last

812c114

Test GraphQL CLI for muc

5ebbed1

chrzaszcz force-pushed the graphql-cli-test branch from 72d8994 to 7a34b16 Compare July 19, 2022 12:25

chrzaszcz added 3 commits July 19, 2022 14:27

Test GraphQL CLI for muc_light

486d7ce

Test GraphQL CLI for offline

8da679e

Also fix the test for old messages - it was actually working, because the previous test did not clean up the messages, and the new messages were not old enough. Now the cases are correct and more complete.

Test GraphQL CLI for private

35baf4f

chrzaszcz added 3 commits July 19, 2022 14:27

Test GraphQL CLI for roster

80a9b35

Test GraphQL CLI for session

d67b9dd

Test GraphQL CLI for stanza

f45ab32

chrzaszcz force-pushed the graphql-cli-test branch from 7a34b16 to f45ab32 Compare July 19, 2022 12:27

This comment was marked as outdated.

Sign in to view

Fix missing wait, resulting in a race condition

c4ac2e2

chrzaszcz marked this pull request as ready for review July 19, 2022 13:41

JanuszJakubiec approved these changes Jul 21, 2022

View reviewed changes

Premwoik approved these changes Jul 21, 2022

View reviewed changes

JanuszJakubiec merged commit 2b58ad3 into feature/graphql-cli Jul 22, 2022

JanuszJakubiec deleted the graphql-cli-test branch July 22, 2022 12:16

chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test GraphQL CLI for all categories #3710

Test GraphQL CLI for all categories #3710

chrzaszcz commented Jul 15, 2022 •

edited

Loading

This comment was marked as outdated.

codecov bot commented Jul 15, 2022 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Jul 19, 2022 •

edited

Loading

JanuszJakubiec left a comment

Premwoik left a comment

Premwoik Jul 21, 2022

chrzaszcz Jul 22, 2022 •

edited

Loading

Test GraphQL CLI for all categories #3710

Test GraphQL CLI for all categories #3710

Conversation

chrzaszcz commented Jul 15, 2022 • edited Loading

This comment was marked as outdated.

codecov bot commented Jul 15, 2022 • edited Loading

Codecov Report

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Jul 19, 2022 • edited Loading

JanuszJakubiec left a comment

Choose a reason for hiding this comment

Premwoik left a comment

Choose a reason for hiding this comment

Premwoik Jul 21, 2022

Choose a reason for hiding this comment

chrzaszcz Jul 22, 2022 • edited Loading

Choose a reason for hiding this comment

chrzaszcz commented Jul 15, 2022 •

edited

Loading

codecov bot commented Jul 15, 2022 •

edited

Loading

mongoose-im commented Jul 19, 2022 •

edited

Loading

chrzaszcz Jul 22, 2022 •

edited

Loading