-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix passing the off_heap flag in the right place #3727
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## master #3727 +/- ##
==========================================
- Coverage 82.28% 82.24% -0.04%
==========================================
Files 526 526
Lines 33853 33853
==========================================
- Hits 27856 27844 -12
- Misses 5997 6009 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1063d59
to
5cad292
Compare
small_tests_24 / small_tests / 5cad292 small_tests_25 / small_tests / 5cad292 ldap_mnesia_24 / ldap_mnesia / 5cad292 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5cad292 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5cad292 ldap_mnesia_25 / ldap_mnesia / 5cad292 internal_mnesia_25 / internal_mnesia / 5cad292 dynamic_domains_mysql_redis_25 / mysql_redis / 5cad292 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5cad292 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 5cad292 pgsql_mnesia_25 / pgsql_mnesia / 5cad292 riak_mnesia_24 / riak_mnesia / 5cad292 pgsql_mnesia_24 / pgsql_mnesia / 5cad292 mssql_mnesia_25 / odbc_mssql_mnesia / 5cad292 mysql_redis_25 / mysql_redis / 5cad292 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This one I detected it with the new eqwalizer tool, the flag as given in the current place is ignored.