Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing the off_heap flag in the right place #3727

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

NelsonVides
Copy link
Collaborator

This one I detected it with the new eqwalizer tool, the flag as given in the current place is ignored.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #3727 (5cad292) into master (5a18d5a) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3727      +/-   ##
==========================================
- Coverage   82.28%   82.24%   -0.04%     
==========================================
  Files         526      526              
  Lines       33853    33853              
==========================================
- Hits        27856    27844      -12     
- Misses       5997     6009      +12     
Impacted Files Coverage Δ
src/async_pools/mongoose_async_pools.erl 91.66% <ø> (ø)
src/ejabberd.erl 55.00% <0.00%> (-5.00%) ⬇️
src/cassandra/mongoose_cassandra.erl 77.77% <0.00%> (-3.71%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 66.03% <0.00%> (-2.84%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 66.66% <0.00%> (-2.23%) ⬇️
src/mod_muc_room.erl 78.39% <0.00%> (-0.29%) ⬇️
src/pubsub/node_pep.erl 79.62% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 73.42% <0.00%> (+0.06%) ⬆️
src/ejabberd_sm.erl 84.91% <0.00%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 10, 2022

small_tests_24 / small_tests / 5cad292
Reports root / small


small_tests_25 / small_tests / 5cad292
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 5cad292
Reports root/ big
OK: 1897 / Failed: 0 / User-skipped: 513 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5cad292
Reports root/ big
OK: 3340 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5cad292
Reports root/ big
OK: 3340 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 5cad292
Reports root/ big
OK: 1897 / Failed: 0 / User-skipped: 513 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 5cad292
Reports root/ big
OK: 2018 / Failed: 0 / User-skipped: 392 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 5cad292
Reports root/ big
OK: 3323 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5cad292
Reports root/ big
OK: 3340 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 5cad292
Reports root/ big
OK: 2314 / Failed: 0 / User-skipped: 387 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 5cad292
Reports root/ big
OK: 3714 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 5cad292
Reports root/ big
OK: 2175 / Failed: 0 / User-skipped: 380 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 5cad292
Reports root/ big
OK: 3714 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 5cad292
Reports root/ big
OK: 3714 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 5cad292
Reports root/ big
OK: 3709 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit ea14994 into master Aug 11, 2022
@chrzaszcz chrzaszcz deleted the quickfix/async_pool_spawn_opt branch August 11, 2022 06:07
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants