Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'mongooseimctl started' #3737

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Fix 'mongooseimctl started' #3737

merged 2 commits into from
Aug 24, 2022

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Aug 23, 2022

  • Pass arguments to ctl and ctlexec to allow calling ctl status, which is needed by mongooseimctl started and mongooseimctl stopped.
  • Add tests for started and status.
  • Check started, status and stopped manually.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #3737 (26701b0) into master (26701b0) will not change coverage.
The diff coverage is n/a.

❗ Current head 26701b0 differs from pull request most recent head 423e34c. Consider uploading reports for the commit 423e34c to get more accurate results

@@           Coverage Diff           @@
##           master    #3737   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files         529      529           
  Lines       33945    33945           
=======================================
  Hits        28037    28037           
  Misses       5908     5908           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

Paweł Chrząszcz added 2 commits August 23, 2022 15:31
This way the 'ctl' function can be reused with different arguments.
Tests are minimal so far, testing stopped nodes would be more
complicated, and it can be done separately.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 23, 2022

small_tests_24 / small_tests / 423e34c
Reports root / small


small_tests_25 / small_tests / 423e34c
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 423e34c
Reports root/ big
OK: 3556 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 423e34c
Reports root/ big
OK: 1943 / Failed: 0 / User-skipped: 529 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 423e34c
Reports root/ big
OK: 3556 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 423e34c
Reports root/ big
OK: 3539 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 423e34c
Reports root/ big
OK: 1943 / Failed: 0 / User-skipped: 529 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 423e34c
Reports root/ big
OK: 3556 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 423e34c
Reports root/ big
OK: 3930 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 423e34c
Reports root/ big
OK: 2064 / Failed: 0 / User-skipped: 408 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 423e34c
Reports root/ big
OK: 2404 / Failed: 0 / User-skipped: 403 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 423e34c
Reports root/ big
OK: 3930 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 423e34c
Reports root/ big
OK: 3936 / Failed: 1 / User-skipped: 102 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2231@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2231@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"nJpyjoCYDwc5NtbicY4Lyw==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


riak_mnesia_24 / riak_mnesia / 423e34c
Reports root/ big
OK: 2243 / Failed: 0 / User-skipped: 396 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 423e34c
Reports root/ big
OK: 3930 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@chrzaszcz chrzaszcz marked this pull request as ready for review August 23, 2022 16:37
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and fixed my issue with test-runner

@arcusfelis arcusfelis merged commit 3aa9fe7 into master Aug 24, 2022
@arcusfelis arcusfelis deleted the mongooseimctl-fix branch August 24, 2022 14:45
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants