Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting and getting custom configuration options in MUC Light GraphQL API #3742

Merged
merged 8 commits into from
Aug 31, 2022
Merged

Support setting and getting custom configuration options in MUC Light GraphQL API #3742

merged 8 commits into from
Aug 31, 2022

Conversation

arcusfelis
Copy link
Contributor

This PR addresses #3664 MIM-1686

Proposed changes include:

  • Setting/getting fields
  • Tests

@codecov
Copy link

codecov bot commented Aug 29, 2022 •
edited
Loading

Codecov Report

Merging #3742 (f9d89a0) into master (918421a) will increase coverage by 0.05%.
The diff coverage is 93.93%.

@@            Coverage Diff             @@
##           master    #3742      +/-   ##
==========================================
+ Coverage   82.70%   82.75%   +0.05%     
==========================================
  Files         529      529              
  Lines       33947    33956       +9     
==========================================
+ Hits        28075    28101      +26     
+ Misses       5872     5855      -17
Impacted Files Coverage Δ
src/muc_light/mod_muc_light_commands.erl 82.35% <0.00%> (-2.50%) ⬇️
...dmin/mongoose_graphql_muc_light_admin_mutation.erl 100.00% <100.00%> (ø)
src/graphql/mongoose_graphql_muc_light_helper.erl 100.00% <100.00%> (ø)
.../user/mongoose_graphql_muc_light_user_mutation.erl 100.00% <100.00%> (ø)
...se_client_api/mongoose_client_api_rooms_config.erl 85.71% <100.00%> (+0.71%) ⬆️
src/muc_light/mod_muc_light_api.erl 96.45% <100.00%> (+0.15%) ⬆️
src/pubsub/node_pep.erl 77.77% <0.00%> (-1.86%) ⬇️
src/mod_roster_riak.erl 96.92% <0.00%> (-1.54%) ⬇️
src/mod_roster.erl 79.18% <0.00%> (-0.24%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 29, 2022 •
edited
Loading

small_tests_24 / small_tests / b6cb86b
Reports root / small

small_tests_25 / small_tests / b6cb86b
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b6cb86b
Reports root/ big
OK: 3561 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / b6cb86b
Reports root/ big
OK: 1948 / Failed: 0 / User-skipped: 529 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / b6cb86b
Reports root/ big
OK: 3544 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b6cb86b
Reports root/ big
OK: 3561 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / b6cb86b
Reports root/ big
OK: 1948 / Failed: 0 / User-skipped: 529 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / b6cb86b
Reports root/ big
OK: 3935 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / b6cb86b
Reports root/ big
OK: 2069 / Failed: 0 / User-skipped: 408 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b6cb86b
Reports root/ big
OK: 3561 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b6cb86b
Reports root/ big
OK: 2409 / Failed: 0 / User-skipped: 403 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / b6cb86b
Reports root/ big
OK: 3935 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / b6cb86b
Reports root/ big
OK: 3930 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / b6cb86b
Reports root/ big
OK: 3935 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / b6cb86b
Reports root/ big
OK: 2248 / Failed: 0 / User-skipped: 396 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 30, 2022 •
edited
Loading

small_tests_24 / small_tests / bf99100
Reports root / small

small_tests_25 / small_tests / bf99100
Reports root / small

ldap_mnesia_24 / ldap_mnesia / bf99100
Reports root/ big
OK: 1948 / Failed: 0 / User-skipped: 529 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / bf99100
Reports root/ big
OK: 3561 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / bf99100
Reports root/ big
OK: 3561 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / bf99100
Reports root/ big
OK: 3544 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / bf99100
Reports root/ big
OK: 1948 / Failed: 0 / User-skipped: 529 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / bf99100
Reports root/ big
OK: 3935 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / bf99100
Reports root/ big
OK: 3561 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / bf99100
Reports root/ big
OK: 2069 / Failed: 0 / User-skipped: 408 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / bf99100
Reports root/ big
OK: 2409 / Failed: 0 / User-skipped: 403 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / bf99100
Reports root/ big
OK: 3935 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / bf99100
Reports root/ big
OK: 2248 / Failed: 0 / User-skipped: 396 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / bf99100
Reports root/ big
OK: 3935 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / bf99100
Reports root/ big
OK: 3930 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

chrzaszcz
chrzaszcz reviewed Aug 31, 2022
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added minor comments.

priv/graphql/schemas/global/muc_light.gql Outdated Show resolved Hide resolved
src/muc_light/mod_muc_light_api.erl Outdated Show resolved Hide resolved
@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 31, 2022 •
edited
Loading

small_tests_24 / small_tests / f9d89a0
Reports root / small

small_tests_25 / small_tests / f9d89a0
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / f9d89a0
Reports root/ big
OK: 3561 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / f9d89a0
Reports root/ big
OK: 1948 / Failed: 0 / User-skipped: 529 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / f9d89a0
Reports root/ big
OK: 3544 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / f9d89a0
Reports root/ big
OK: 3561 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / f9d89a0
Reports root/ big
OK: 1948 / Failed: 0 / User-skipped: 529 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / f9d89a0
Reports root/ big
OK: 3935 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / f9d89a0
Reports root/ big
OK: 2069 / Failed: 0 / User-skipped: 408 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / f9d89a0
Reports root/ big
OK: 3561 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / f9d89a0
Reports root/ big
OK: 2409 / Failed: 0 / User-skipped: 403 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / f9d89a0
Reports root/ big
OK: 3935 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / f9d89a0
Reports root/ big
OK: 3930 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / f9d89a0
Reports root/ big
OK: 3935 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / f9d89a0
Reports root/ big
OK: 2248 / Failed: 0 / User-skipped: 396 / Auto-skipped: 0

@chrzaszcz chrzaszcz merged commit 6b39a79 into master Aug 31, 2022
@chrzaszcz chrzaszcz deleted the graphql/muclightopts branch August 31, 2022 16:33
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
waiting-for-review
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arcusfelis @mongoose-im @chrzaszcz