Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C2s/ping #3748

Merged
merged 3 commits into from
Oct 4, 2022
Merged

C2s/ping #3748

merged 3 commits into from
Oct 4, 2022

Conversation

NelsonVides
Copy link
Collaborator

No description provided.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@NelsonVides NelsonVides force-pushed the c2s_prototype branch 2 times, most recently from a21bb34 to 225849a Compare September 19, 2022 10:44
Base automatically changed from c2s_prototype to feature/mongoose_c2s September 20, 2022 13:10
@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 64.42% // Head: 64.71% // Increases project coverage by +0.28% 🎉

Coverage data is based on head (a73bc33) compared to base (6f9302e).
Patch coverage: 97.50% of modified lines in pull request are covered.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/mongoose_c2s    #3748      +/-   ##
========================================================
+ Coverage                 64.42%   64.71%   +0.28%     
========================================================
  Files                       536      536              
  Lines                     35002    34997       -5     
========================================================
+ Hits                      22551    22649      +98     
+ Misses                    12451    12348     -103     
Impacted Files Coverage Δ
src/mod_ping.erl 98.30% <97.43%> (+96.71%) ⬆️
src/mongoose_hooks.erl 82.74% <100.00%> (+2.43%) ⬆️
src/metrics/mongoose_metrics_probe.erl 57.14% <0.00%> (-9.53%) ⬇️
src/pubsub/node_pep.erl 68.51% <0.00%> (-3.71%) ⬇️
src/pubsub/mod_pubsub.erl 37.30% <0.00%> (+0.24%) ⬆️
src/pubsub/mod_pubsub_db_rdbms.erl 69.76% <0.00%> (+0.25%) ⬆️
src/mod_bosh_socket.erl 77.95% <0.00%> (+0.31%) ⬆️
src/pubsub/node_flat.erl 40.71% <0.00%> (+0.39%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 74.68% <0.00%> (+0.42%) ⬆️
src/mod_roster.erl 76.55% <0.00%> (+0.71%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 23, 2022

ldap_mnesia_24 / ldap_mnesia / c526baf
Reports root/ big
OK: 829 / Failed: 0 / User-skipped: 427 / Auto-skipped: 0


small_tests_24 / small_tests / c526baf
Reports root / small


ldap_mnesia_25 / ldap_mnesia / c526baf
Reports root/ big
OK: 829 / Failed: 0 / User-skipped: 427 / Auto-skipped: 0


small_tests_25 / small_tests / c526baf
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c526baf
Reports root/ big
OK: 2570 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / c526baf
Reports root/ big
OK: 891 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / c526baf
Reports root/ big
OK: 2638 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / c526baf
Reports root/ big
OK: 2553 / Failed: 0 / User-skipped: 69 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c526baf
Reports root/ big
OK: 2570 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c526baf
Reports root/ big
OK: 1227 / Failed: 0 / User-skipped: 364 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / c526baf
Reports root/ big
OK: 1072 / Failed: 0 / User-skipped: 351 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / c526baf
Reports root/ big
OK: 2638 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c526baf
Reports root/ big
OK: 2568 / Failed: 1 / User-skipped: 52 / Auto-skipped: 1

last_SUITE:valid_queries:last_offline_user
{error,
  {{assertion_failed,assert,is_last_result,
     {xmlel,<<"presence">>,
       [{<<"from">>,<<"[email protected]/res1">>},
        {<<"to">>,<<"[email protected]/res1">>},
        {<<"type">>,<<"unavailable">>}],
       [{xmlel,<<"status">>,[],[{xmlcdata,<<"Unknown condition">>}]}]},
     "<presence from='[email protected]/res1' to='[email protected]/res1' type='unavailable'><status>Unknown condition</status></presence>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {last_SUITE,'-last_offline_user/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/last_SUITE.erl"},
       {line,133}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mysql_redis_25 / mysql_redis / c526baf
Reports root/ big
OK: 2631 / Failed: 1 / User-skipped: 66 / Auto-skipped: 1

metrics_session_SUITE:session_global:session_global
{error,
  {{totalSessionCount,
     {value,1},
     [{times,25,
        {error,
          {badmatch,{value,0}},
          [{metrics_helper,assert_counter,3,
             [{file,
              "/home/circleci/project/big_tests/tests/metrics_helper.erl"},
            {line,36}]},
           {mongoose_helper,do_wait_until,2,
             [{file,
              "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
            {line,374}]},
           {escalus_story,story,4,
             [{file,
              "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
            {line,72}]},
           {test_server,ts_tc,3,
             [{file,"test_server.erl"},{line,1782}]},
           {test_server,run_test_case_eval1,6,
             [{file,"test_server.erl"},{line,1291}]},
           {test_server,run_test_case_eval,9,
             [{file,"test_server.erl"},{line,1223}]}]}}]},
   [{mongoose_helper,do_wait_until,2,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,371}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mssql_mnesia_25 / odbc_mssql_mnesia / c526baf
Reports root/ big
OK: 2638 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 3, 2022

small_tests_24 / small_tests / 002eb93
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 002eb93
Reports root/ big
OK: 1059 / Failed: 0 / User-skipped: 427 / Auto-skipped: 0


small_tests_25 / small_tests / 002eb93
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 002eb93
Reports root/ big
OK: 1059 / Failed: 0 / User-skipped: 427 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 002eb93
Reports root/ big
OK: 2896 / Failed: 0 / User-skipped: 68 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 002eb93
Reports root/ big
OK: 2964 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 002eb93
Reports root/ big
OK: 1121 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 002eb93
Reports root/ big
OK: 2896 / Failed: 0 / User-skipped: 68 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 002eb93
Reports root/ big
OK: 1457 / Failed: 0 / User-skipped: 364 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 002eb93
Reports root/ big
OK: 2879 / Failed: 0 / User-skipped: 85 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 002eb93
Reports root/ big
OK: 2959 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 002eb93
Reports root/ big
OK: 2896 / Failed: 0 / User-skipped: 68 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 002eb93
Reports root/ big
OK: 2964 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 002eb93
Reports root/ big
OK: 1302 / Failed: 0 / User-skipped: 351 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 002eb93
Reports root/ big
OK: 2964 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0

Copy link

@kamilwaz kamilwaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I just have one small comment.

src/mod_ping.erl Outdated
_ ->
{ok, Acc}
end;
{_, {error, not_found}} ->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clause is redundant as a next one returns the same result.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed 👌🏽

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 4, 2022

small_tests_24 / small_tests / a73bc33
Reports root / small


ldap_mnesia_25 / ldap_mnesia / a73bc33
Reports root/ big
OK: 1059 / Failed: 0 / User-skipped: 427 / Auto-skipped: 0


small_tests_25 / small_tests / a73bc33
Reports root / small


ldap_mnesia_24 / ldap_mnesia / a73bc33
Reports root/ big
OK: 1059 / Failed: 0 / User-skipped: 427 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a73bc33
Reports root/ big
OK: 2896 / Failed: 0 / User-skipped: 68 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / a73bc33
Reports root/ big
OK: 2963 / Failed: 1 / User-skipped: 77 / Auto-skipped: 0

inbox_SUITE:regular:one_to_one:msg_sent_to_offline_user
{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"message">>,
       [{<<"from">>,
         <<"alice_msg_sent_to_offline_user_982@localhost/res1">>},
        {<<"to">>,<<"bob_msg_sent_to_offline_user_982@localhost/res1">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"test">>}]},
        {xmlel,<<"stanza-id">>,
          [{<<"by">>,<<"bob_msg_sent_to_offline_user_982@localhost">>},
           {<<"id">>,<<"BQHJJK5AFJO1">>},
           {<<"xmlns">>,<<"urn:xmpp:sid:0">>}],
          []}]},
     "<message from='alice_msg_sent_to_offline_user_982@localhost/res1' to='bob_msg_sent_to_offline_user_982@localhost/res1' type='chat'><body>test</body><stanza-id by='bob_msg_sent_to_offline_user_982@localhost' id='BQHJJK5AFJO1' xmlns='urn:xmpp:sid:0'/></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {escalus_session,session,1,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
       {line,131}]},
    {escalus_session,session,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
       {line,273}]},
    {escalus_connection,connection_step,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
       {line,160}]},
    {lists,fo...

Report log


internal_mnesia_25 / internal_mnesia / a73bc33
Reports root/ big
OK: 1121 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / a73bc33
Reports root/ big
OK: 1457 / Failed: 0 / User-skipped: 364 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / a73bc33
Reports root/ big
OK: 2896 / Failed: 0 / User-skipped: 68 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / a73bc33
Reports root/ big
OK: 2879 / Failed: 0 / User-skipped: 85 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / a73bc33
Reports root/ big
OK: 2896 / Failed: 0 / User-skipped: 68 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / a73bc33
Reports root/ big
OK: 2964 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / a73bc33
Reports root/ big
OK: 2959 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / a73bc33
Reports root/ big
OK: 2964 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / a73bc33
Reports root/ big
OK: 1302 / Failed: 0 / User-skipped: 351 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / a73bc33
Reports root/ big
OK: 2964 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0

Copy link

@kamilwaz kamilwaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👍

@kamilwaz kamilwaz merged commit 87e25f6 into feature/mongoose_c2s Oct 4, 2022
@kamilwaz kamilwaz deleted the c2s/ping branch October 4, 2022 11:42
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants