-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c2s/mod_register #3751
c2s/mod_register #3751
Conversation
7b68709
to
2a5694a
Compare
b4892bf
to
d6da30f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
c6105e8
to
7b8e99c
Compare
1edaa0f
to
4152aa9
Compare
d6da30f
to
ffd44e1
Compare
small_tests_24 / small_tests / ffd44e1 ldap_mnesia_24 / ldap_mnesia / ffd44e1 ldap_mnesia_25 / ldap_mnesia / ffd44e1 small_tests_25 / small_tests / ffd44e1 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ffd44e1 pgsql_mnesia_24 / pgsql_mnesia / ffd44e1 internal_mnesia_25 / internal_mnesia / ffd44e1 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ffd44e1 dynamic_domains_mysql_redis_25 / mysql_redis / ffd44e1 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ffd44e1 mysql_redis_25 / mysql_redis / ffd44e1 metrics_session_SUITE:session_global:session_global{error,
{{totalSessionCount,
{value,1},
[{times,25,
{error,
{badmatch,{value,0}},
[{metrics_helper,assert_counter,3,
[{file,
"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,36}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ffd44e1 mssql_mnesia_25 / odbc_mssql_mnesia / ffd44e1 service_domain_db_SUITE:db:db_event_could_appear_with_lower_id{error,
{{badmatch,13},
[{service_domain_db_SUITE,db_event_could_appear_with_lower_id,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,710}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} pgsql_mnesia_25 / pgsql_mnesia / ffd44e1 riak_mnesia_24 / riak_mnesia / ffd44e1 |
Codecov ReportBase: 57.73% // Head: 58.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## c2s/presences #3751 +/- ##
=================================================
+ Coverage 57.73% 58.22% +0.49%
=================================================
Files 536 536
Lines 34809 34820 +11
=================================================
+ Hits 20096 20274 +178
+ Misses 14713 14546 -167
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
https://xmpp.org/extensions/xep-0077.html