Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c2s/mod_register #3751

Merged
merged 2 commits into from
Sep 23, 2022
Merged

c2s/mod_register #3751

merged 2 commits into from
Sep 23, 2022

Conversation

NelsonVides
Copy link
Collaborator

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 20, 2022

small_tests_24 / small_tests / ffd44e1
Reports root / small


ldap_mnesia_24 / ldap_mnesia / ffd44e1
Reports root/ big
OK: 808 / Failed: 0 / User-skipped: 427 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / ffd44e1
Reports root/ big
OK: 808 / Failed: 0 / User-skipped: 427 / Auto-skipped: 0


small_tests_25 / small_tests / ffd44e1
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ffd44e1
Reports root/ big
OK: 2549 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / ffd44e1
Reports root/ big
OK: 2617 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / ffd44e1
Reports root/ big
OK: 870 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ffd44e1
Reports root/ big
OK: 1206 / Failed: 0 / User-skipped: 364 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / ffd44e1
Reports root/ big
OK: 2532 / Failed: 0 / User-skipped: 69 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ffd44e1
Reports root/ big
OK: 2549 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / ffd44e1
Reports root/ big
OK: 2610 / Failed: 1 / User-skipped: 66 / Auto-skipped: 1

metrics_session_SUITE:session_global:session_global
{error,
  {{totalSessionCount,
     {value,1},
     [{times,25,
        {error,
          {badmatch,{value,0}},
          [{metrics_helper,assert_counter,3,
             [{file,
              "/home/circleci/project/big_tests/tests/metrics_helper.erl"},
            {line,36}]},
           {mongoose_helper,do_wait_until,2,
             [{file,
              "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
            {line,374}]},
           {escalus_story,story,4,
             [{file,
              "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
            {line,72}]},
           {test_server,ts_tc,3,
             [{file,"test_server.erl"},{line,1782}]},
           {test_server,run_test_case_eval1,6,
             [{file,"test_server.erl"},{line,1291}]},
           {test_server,run_test_case_eval,9,
             [{file,"test_server.erl"},{line,1223}]}]}}]},
   [{mongoose_helper,do_wait_until,2,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,371}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ffd44e1
Reports root/ big
OK: 2549 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / ffd44e1
Reports root/ big
OK: 2616 / Failed: 1 / User-skipped: 61 / Auto-skipped: 0

service_domain_db_SUITE:db:db_event_could_appear_with_lower_id
{error,
  {{badmatch,13},
   [{service_domain_db_SUITE,db_event_could_appear_with_lower_id,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,710}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


pgsql_mnesia_25 / pgsql_mnesia / ffd44e1
Reports root/ big
OK: 2617 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / ffd44e1
Reports root/ big
OK: 1051 / Failed: 0 / User-skipped: 351 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 57.73% // Head: 58.22% // Increases project coverage by +0.49% 🎉

Coverage data is based on head (ffd44e1) compared to base (4152aa9).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           c2s/presences    #3751      +/-   ##
=================================================
+ Coverage          57.73%   58.22%   +0.49%     
=================================================
  Files                536      536              
  Lines              34809    34820      +11     
=================================================
+ Hits               20096    20274     +178     
+ Misses             14713    14546     -167     
Impacted Files Coverage Δ
src/mod_register.erl 75.24% <85.71%> (+56.78%) ⬆️
src/cassandra/mongoose_cassandra.erl 77.77% <0.00%> (-3.71%) ⬇️
src/smart_markers/mod_smart_markers_rdbms.erl 91.66% <0.00%> (-3.34%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 66.03% <0.00%> (-2.84%) ⬇️
src/muc_light/mod_muc_light_db_mnesia.erl 88.42% <0.00%> (-1.06%) ⬇️
src/pubsub/mod_pubsub_db_rdbms.erl 68.99% <0.00%> (-0.52%) ⬇️
src/jlib.erl 75.72% <0.00%> (+0.57%) ⬆️
src/auth/ejabberd_auth_riak.erl 70.00% <0.00%> (+1.25%) ⬆️
src/mod_muc.erl 61.26% <0.00%> (+1.40%) ⬆️
src/c2s/mongoose_c2s_socket.erl 23.52% <0.00%> (+1.47%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NelsonVides NelsonVides marked this pull request as ready for review September 20, 2022 13:50
Base automatically changed from c2s/presences to feature/mongoose_c2s September 20, 2022 13:51
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit 1976436 into feature/mongoose_c2s Sep 23, 2022
@chrzaszcz chrzaszcz deleted the c2s/register branch September 23, 2022 12:21
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants