-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cache affiliations key in the accumulator #3761
Conversation
In 884ca87, with the good intention of introducing an API to manage the accumulated affiliations, I didn't realise the old keying was used elsewhere: in the muc cache. So we've been missing using the cache recently. This is fixed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
small_tests_24 / small_tests / 3ce9205 small_tests_25 / small_tests / 3ce9205 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 3ce9205 ldap_mnesia_24 / ldap_mnesia / 3ce9205 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 3ce9205 ldap_mnesia_25 / ldap_mnesia / 3ce9205 dynamic_domains_mysql_redis_25 / mysql_redis / 3ce9205 pgsql_mnesia_24 / pgsql_mnesia / 3ce9205 internal_mnesia_25 / internal_mnesia / 3ce9205 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 3ce9205 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 3ce9205 pgsql_mnesia_25 / pgsql_mnesia / 3ce9205 mysql_redis_25 / mysql_redis / 3ce9205 riak_mnesia_24 / riak_mnesia / 3ce9205 mssql_mnesia_25 / odbc_mssql_mnesia / 3ce9205 pep_SUITE:pep_tests:publish_and_notify_test{error,{{assertion_failed,assert_many,false,[is_presence],[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-make_all_clients_friends/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,109}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{escalus_utils,distinct_pairs,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,60}]},
{escalus_story,make_all_clients_friends,1,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,106}]}]}} |
Codecov ReportBase: 82.72% // Head: 82.73% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3761 +/- ##
==========================================
+ Coverage 82.72% 82.73% +0.01%
==========================================
Files 529 529
Lines 33970 33970
==========================================
+ Hits 28102 28106 +4
+ Misses 5868 5864 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
In 884ca87, with the good intention of introducing an API to manage the accumulated affiliations, I didn't realise the old keying was used elsewhere: in the muc cache. So we've been missing using the cache recently. This is fixed now.