Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache affiliations key in the accumulator #3761

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

NelsonVides
Copy link
Collaborator

In 884ca87, with the good intention of introducing an API to manage the accumulated affiliations, I didn't realise the old keying was used elsewhere: in the muc cache. So we've been missing using the cache recently. This is fixed now.

In 884ca87, with the good intention of
introducing an API to manage the accumulated affiliations, I didn't
realise the old keying was used elsewhere: in the muc cache. So we've
been missing using the cache recently. This is fixed now.
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 15, 2022

small_tests_24 / small_tests / 3ce9205
Reports root / small


small_tests_25 / small_tests / 3ce9205
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 3ce9205
Reports root/ big
OK: 3583 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 3ce9205
Reports root/ big
OK: 1948 / Failed: 0 / User-skipped: 551 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 3ce9205
Reports root/ big
OK: 3583 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 3ce9205
Reports root/ big
OK: 1948 / Failed: 0 / User-skipped: 551 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 3ce9205
Reports root/ big
OK: 3566 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 3ce9205
Reports root/ big
OK: 3957 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 3ce9205
Reports root/ big
OK: 2069 / Failed: 0 / User-skipped: 430 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 3ce9205
Reports root/ big
OK: 3583 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 3ce9205
Reports root/ big
OK: 2409 / Failed: 0 / User-skipped: 425 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 3ce9205
Reports root/ big
OK: 3957 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 3ce9205
Reports root/ big
OK: 3952 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 3ce9205
Reports root/ big
OK: 2248 / Failed: 0 / User-skipped: 418 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 3ce9205
Reports root/ big
OK: 3968 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:publish_and_notify_test
{error,{{assertion_failed,assert_many,false,[is_presence],[],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,109}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 82.72% // Head: 82.73% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (3ce9205) compared to base (7e19c4f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3761      +/-   ##
==========================================
+ Coverage   82.72%   82.73%   +0.01%     
==========================================
  Files         529      529              
  Lines       33970    33970              
==========================================
+ Hits        28102    28106       +4     
+ Misses       5868     5864       -4     
Impacted Files Coverage Δ
src/muc_light/mod_muc_light.erl 85.60% <ø> (+0.36%) ⬆️
src/muc_light/mod_muc_light_cache.erl 85.71% <100.00%> (-2.39%) ⬇️
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 66.66% <0.00%> (-2.23%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 86.60% <0.00%> (-1.79%) ⬇️
src/ejabberd_c2s.erl 88.93% <0.00%> (-0.30%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/mod_muc_room.erl 78.68% <0.00%> (+0.17%) ⬆️
src/mod_roster.erl 79.66% <0.00%> (+0.23%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chrzaszcz chrzaszcz merged commit 9e8aa5d into master Sep 15, 2022
@chrzaszcz chrzaszcz deleted the fix_muclight_cache branch September 15, 2022 15:57
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants