Documented missing GraphQL types #3773

jacekwegr · 2022-09-23T14:52:48Z

This PR adds documentation to the GraphQL types that were missing before

codecov · 2022-09-26T11:05:49Z

Codecov Report

Base: 82.82% // Head: 82.82% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (86bd669) compared to base (6c3819f).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3773   +/-   ##
=======================================
  Coverage   82.82%   82.82%           
=======================================
  Files         531      531           
  Lines       34083    34083           
=======================================
+ Hits        28228    28230    +2     
+ Misses       5855     5853    -2

Impacted Files	Coverage Δ
src/ejabberd_ctl.erl	`54.14% <ø> (ø)`
src/mam/mod_mam_muc_rdbms_arch_async.erl	`82.85% <0.00%> (-2.86%)`	⬇️
src/mod_roster_riak.erl	`96.92% <0.00%> (-1.54%)`	⬇️
src/global_distrib/mod_global_distrib_bounce.erl	`84.21% <0.00%> (-1.32%)`	⬇️
src/muc_light/mod_muc_light_db_mnesia.erl	`91.57% <0.00%> (-1.06%)`	⬇️
src/mod_roster.erl	`78.70% <0.00%> (-0.72%)`	⬇️
src/mod_muc_log.erl	`62.82% <0.00%> (ø)`
src/pubsub/mod_pubsub.erl	`73.23% <0.00%> (+0.18%)`	⬆️
src/pubsub/mod_pubsub_db_rdbms.erl	`95.34% <0.00%> (+0.25%)`	⬆️
src/inbox/mod_inbox_rdbms_async.erl	`73.52% <0.00%> (+1.47%)`	⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

chrzaszcz

It's going in the right direction, I added some comments for the current version.

priv/graphql/schemas/admin/metric.gql

priv/graphql/schemas/admin/mnesia.gql

priv/graphql/schemas/global/muc.gql

priv/graphql/schemas/global/stanza.gql

priv/graphql/schemas/global/scalar_types.gql

chrzaszcz

Looks good 👍

priv/graphql/schemas/admin/last.gql

mongoose-im · 2022-10-04T12:28:58Z

small_tests_24 / small_tests / 86bd669
Reports root / small

small_tests_25 / small_tests / 86bd669
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 86bd669
Reports root/ big
OK: 1991 / Failed: 1 / User-skipped: 742 / Auto-skipped: 0

graphql_roster_SUITE:admin_roster_http:admin_decline_subscription_ask

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bob_admin_decline_subscription_ask_795@localhost/res1">>,
          escalus_tcp,<0.21684.0>,
          [{event_manager,<0.21682.0>},
           {server,<<"localhost">>},
           {username,<<"bOb_admin_decline_subscription_ask_795">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.21682.0>},
            {server,<<"localhost">>},
            {username,
              <<"bOb_admin_decline_subscription_ask_795">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bob_admin_decline_subscription_ask_795">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_admin_decline_subscription_ask_795">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"700349c0ba527e5f">>}]},
        1],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {graphql_roster_SUITE,admin_decline_subscription_ask_story,3,
       [{file,
          "/home/circleci/project/big_tests/tests/graphql_roster_SUITE.erl"},
        {line,255}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_bui...

Report log

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 86bd669
Reports root/ big
OK: 3826 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 86bd669
Reports root/ big
OK: 1992 / Failed: 0 / User-skipped: 742 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 86bd669
Reports root/ big
OK: 3826 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 86bd669
Reports root/ big
OK: 3798 / Failed: 2 / User-skipped: 114 / Auto-skipped: 0

bosh_SUITE:essential:accept_higher_hold_value

{error,
  {{assertEqual,
     [{module,bosh_SUITE},
      {line,251},
      {expression,"get_bosh_sessions ( )"},
      {expected,[]},
      {value,
        [{bosh_session,<<"e969f80aa58fd77686167e3e22b77d823d188ff9">>,
           <9147.5673.0>}]}]},
   [{bosh_SUITE,accept_higher_hold_value,1,
      [{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
       {line,251}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive

{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

internal_mnesia_25 / internal_mnesia / 86bd669
Reports root/ big
OK: 2113 / Failed: 0 / User-skipped: 621 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 86bd669
Reports root/ big
OK: 4211 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2513@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2513@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"bg6FjjVxPCugdU/lnnFc9Q==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 86bd669
Reports root/ big
OK: 2453 / Failed: 0 / User-skipped: 616 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 86bd669
Reports root/ big
OK: 3826 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 86bd669
Reports root/ big
OK: 4200 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 86bd669
Reports root/ big
OK: 4200 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 86bd669
Reports root/ big
OK: 4186 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 86bd669
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 609 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 86bd669
Reports root/ big
OK: 3799 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive

{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

ldap_mnesia_24 / ldap_mnesia / 86bd669
Reports root/ big
OK: 1992 / Failed: 0 / User-skipped: 742 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 86bd669
Reports root/ big
OK: 3800 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

jacekwegr force-pushed the document-graphql-types branch from 4df1ea3 to d154112 Compare September 23, 2022 14:57

This comment was marked as outdated.

Sign in to view

esl deleted a comment from mongoose-im Sep 23, 2022

Documented missing GraphQL types

fed9dcb

jacekwegr force-pushed the document-graphql-types branch from d154112 to fed9dcb Compare September 26, 2022 10:54

esl deleted a comment from mongoose-im Sep 26, 2022

This comment was marked as outdated.

Sign in to view

mongoose-im mentioned this pull request Sep 26, 2022

CI build failures summary - part 2 #3685

Closed

chrzaszcz reviewed Sep 28, 2022

View reviewed changes

This comment was marked as outdated.

Sign in to view

jacekwegr force-pushed the document-graphql-types branch from c30fa13 to 6aa12ab Compare October 3, 2022 14:58

This comment was marked as outdated.

Sign in to view

jacekwegr marked this pull request as ready for review October 4, 2022 08:51

chrzaszcz approved these changes Oct 4, 2022

View reviewed changes

priv/graphql/schemas/admin/last.gql Outdated Show resolved Hide resolved

More specific CLI help

86bd669

jacekwegr force-pushed the document-graphql-types branch from 6aa12ab to 86bd669 Compare October 4, 2022 12:20

chrzaszcz merged commit 6748ca4 into master Oct 4, 2022

chrzaszcz deleted the document-graphql-types branch October 4, 2022 13:35

chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Documented missing GraphQL types #3773

Documented missing GraphQL types #3773

jacekwegr commented Sep 23, 2022

This comment was marked as outdated.

This comment was marked as outdated.

codecov bot commented Sep 26, 2022 •

edited

Loading

chrzaszcz left a comment

This comment was marked as outdated.

This comment was marked as outdated.

chrzaszcz left a comment

mongoose-im commented Oct 4, 2022 •

edited

Loading

Documented missing GraphQL types #3773

Documented missing GraphQL types #3773

Conversation

jacekwegr commented Sep 23, 2022

This comment was marked as outdated.

This comment was marked as outdated.

codecov bot commented Sep 26, 2022 • edited Loading

Codecov Report

chrzaszcz left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

chrzaszcz left a comment

Choose a reason for hiding this comment

mongoose-im commented Oct 4, 2022 • edited Loading

codecov bot commented Sep 26, 2022 •

edited

Loading

mongoose-im commented Oct 4, 2022 •

edited

Loading