Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MySQL version #3779

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Update MySQL version #3779

merged 1 commit into from
Sep 28, 2022

Conversation

chrzaszcz
Copy link
Member

This PR allows testing with MySQL on the Apple M1 chip.

8.0.20 does not work on arm64, while 8.0.30 does.

8.0.20 does not work on arm64, while 8.0.30 does.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 28, 2022

small_tests_24 / small_tests / 03043cb
Reports root / small


small_tests_25 / small_tests / 03043cb
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 03043cb
Reports root/ big
OK: 1992 / Failed: 0 / User-skipped: 743 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 03043cb
Reports root/ big
OK: 3827 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 03043cb
Reports root/ big
OK: 1992 / Failed: 0 / User-skipped: 743 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 03043cb
Reports root/ big
OK: 3801 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 03043cb
Reports root/ big
OK: 3827 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 03043cb
Reports root/ big
OK: 3827 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 03043cb
Reports root/ big
OK: 2113 / Failed: 0 / User-skipped: 622 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 03043cb
Reports root/ big
OK: 2453 / Failed: 0 / User-skipped: 617 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 03043cb
Reports root/ big
OK: 4201 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 03043cb
Reports root/ big
OK: 4187 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 03043cb
Reports root/ big
OK: 4201 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 03043cb
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 610 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 03043cb
Reports root/ big
OK: 4201 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 82.48% // Head: 82.80% // Increases project coverage by +0.32% 🎉

Coverage data is based on head (03043cb) compared to base (faecc8d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3779      +/-   ##
==========================================
+ Coverage   82.48%   82.80%   +0.32%     
==========================================
  Files         531      531              
  Lines       34109    34109              
==========================================
+ Hits        28134    28244     +110     
+ Misses       5975     5865     -110     
Impacted Files Coverage Δ
src/ejabberd.erl 45.00% <0.00%> (-15.00%) ⬇️
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 69.11% <0.00%> (-4.42%) ⬇️
src/pubsub/node_pep.erl 77.77% <0.00%> (-1.86%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 86.60% <0.00%> (-1.79%) ⬇️
src/mod_roster_riak.erl 96.92% <0.00%> (-1.54%) ⬇️
src/mod_roster.erl 78.70% <0.00%> (-0.72%) ⬇️
src/mod_muc_room.erl 78.51% <0.00%> (-0.18%) ⬇️
src/ejabberd_c2s.erl 89.23% <0.00%> (+0.29%) ⬆️
src/rdbms/mongoose_rdbms.erl 66.31% <0.00%> (+1.05%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chrzaszcz chrzaszcz marked this pull request as ready for review September 28, 2022 12:25
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant 👌🏽

@NelsonVides
Copy link
Collaborator

For the record, https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-30.html says it's here where they added M1 support

1 similar comment
@NelsonVides
Copy link
Collaborator

For the record, https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-30.html says it's here where they added M1 support

@NelsonVides NelsonVides merged commit 6ddc8b4 into master Sep 28, 2022
@NelsonVides NelsonVides deleted the update-mysql-version branch September 28, 2022 12:52
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants